Re: [PATCH v9 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue

2019-11-15 Thread Kan Yan
> +static inline u16 > +ieee80211_info_set_tx_time_est(struct ieee80211_tx_info *info, u16 > tx_time_est) > +{ > + /* We only have 10 bits in tx_time_est, so store airtime > +* in increments of 4us and clamp the maximum to 2**12-1 > +*/ > + info->tx_time_est =

[PATCH v9 3/4] mac80211: Implement Airtime-based Queue Limit (AQL)

2019-11-15 Thread Toke Høiland-Jørgensen
From: Kan Yan In order for the Fq_CoDel algorithm integrated in mac80211 layer to operate effectively to control excessive queueing latency, the CoDel algorithm requires an accurate measure of how long packets stays in the queue, AKA sojourn time. The sojourn time measured at the mac80211 layer

[PATCH v9 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue

2019-11-15 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen The previous commit added the ability to throttle stations when they queue too much airtime in the hardware. This commit enables the functionality by calculating the expected airtime usage of each packet that is dequeued from the TXQs in mac80211, and accounting that

[PATCH v9 1/4] mac80211: Add new sta_info getter by sta/vif addrs

2019-11-15 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen In ieee80211_tx_status() we don't have an sdata struct when looking up the destination sta. Instead, we just do a lookup by the vif addr that is the source of the packet being completed. Factor this out into a new sta_info getter helper, since we need to use it for

[PATCH v9 0/4] Add Airtime Queue Limits (AQL) to mac80211

2019-11-15 Thread Toke Høiland-Jørgensen
This series is a first attempt at porting the Airtime Queue Limits concept from the out-of-tree ath10k implementation[0] to mac80211. This version takes Kan's patch to do the throttling in mac80211, and replaces the driver API with the mechanism from the previous version of my series, which

[PATCH v9 2/4] mac80211: Import airtime calculation code from mt76

2019-11-15 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen Felix recently added code to calculate airtime of packets to the mt76 driver. Import this into mac80211 so we can use it for airtime queue limit calculations. The airtime.c file is copied verbatim from the mt76 driver, and adjusted to be usable in mac80211. This

Re: [PATCH net-next v2] ath10k: fix RX of frames with broken FCS in monitor mode

2019-11-15 Thread Kalle Valo
Linus Lüssing writes: > From: Linus Lüssing > > So far, frames were forwarded regardless of the FCS correctness leading > to userspace applications listening on the monitor mode interface to > receive potentially broken frames, even with the "fcsfail" flag unset. > > By default, with the

[PATCH net-next v2] ath10k: fix RX of frames with broken FCS in monitor mode

2019-11-15 Thread Linus Lüssing
From: Linus Lüssing So far, frames were forwarded regardless of the FCS correctness leading to userspace applications listening on the monitor mode interface to receive potentially broken frames, even with the "fcsfail" flag unset. By default, with the "fcsfail" flag of a monitor mode interface

[PATCH RFC, v2] Revert "ath10k: fix DMA related firmware crashes on multiple devices"

2019-11-15 Thread Zhi Chen
This reverts commit 76d164f582150fd0259ec0fcbc485470bcd8033e. PCIe hung issue was observed on multiple platforms. The issue was reproduced when DUT was configured as AP and associated with 50+ STAs. With PCIe protocol analyzer, we can see DMA Read crossing 4KB boundary when issue happened. It