Re: [PATCH 3/5] ath10k: change ath10k_offchan_tx_work() peer present msg to a warn

Shuah Khan wrote: > Based on the comment block in this function and the FIXME for this, peer > being present for the offchannel tx is unlikely. Peer is deleted once tx > is complete. Change peer present msg to a warn to detect this condition. > > Signed-off-by: Shuah Khan > Signed-off-by:

Re: [PATCH] ath10k: restore tx sk_buff of htt header for SDIO

Wen Gong wrote: > ieee80211_report_used_skb of mac80211 use the frame_control of > ieee80211_hdr in sk_buff and indicate it to another function > ieee80211_mgd_conn_tx_status, then it queue work ieee80211_sta_work, > but ieee80211_is_auth(fc) in ieee80211_sta_work check fail when the >

Re: [PATCH 4/5] ath10k: detect conf_mutex held ath10k_drain_tx() calls

. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Shuah-Khan/ath10k-fixes-for-warns/20210210-085259 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git

[PATCH v2] ath10k: hold RCU lock when calling ieee80211_find_sta_by_ifaddr()

ieee80211_find_sta_by_ifaddr() must be called under the RCU lock and the resulting pointer is only valid under RCU lock as well. Fix ath10k_wmi_tlv_op_pull_peer_stats_info() to hold RCU lock before it calls ieee80211_find_sta_by_ifaddr() and release it when the resulting pointer is no longer

Re: [PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size

On Wed, 10 Feb 2021 11:48:23 -0500 Steven Rostedt wrote: > On Wed, 10 Feb 2021 11:30:26 -0500 > Steven Rostedt wrote: > > > Can you test this patch? > > v2: Bah! v3: diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index b79bcacdd6f9..90d7ade03499 100644 ---

Re: [PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size

On Wed, 10 Feb 2021 11:30:26 -0500 Steven Rostedt wrote: > Can you test this patch? v2: diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index b79bcacdd6f9..c5c3d826d420 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -2739,7 +2739,7 @@

Re: [PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size

On Wed, 10 Feb 2021 10:01:57 +0800 Wen Gong wrote: > Not tested with latest kernel. > The reason is below which I said in > https://lore.kernel.org/lkml/b504b3d7e989cae108669a0cd3072...@codeaurora.org/ > > the per cpu buffer seems it is initilized in > trace_buffered_event_enable, > it is

Re: [PATCH 2/5] ath10k: fix WARNING: suspicious RCU usage

On 2/10/21 1:13 AM, Kalle Valo wrote: Shuah Khan wrote: ieee80211_find_sta_by_ifaddr() must be called under the RCU lock and the resulting pointer is only valid under RCU lock as well. Fix ath10k_wmi_tlv_parse_peer_stats_info() to hold RCU lock before it calls ieee80211_find_sta_by_ifaddr()

Re: [PATCH 1/5] ath10k: fix conf_mutex lock assert in ath10k_debug_fw_stats_request()

On 2/10/21 1:09 AM, Kalle Valo wrote: Shuah Khan wrote: ath10k_debug_fw_stats_request() is called ath10k_sta_statistics() without holding conf_mutex. ath10k_debug_fw_stats_request() simply returns when CONFIG_ATH10K_DEBUGFS is disabled. When CONFIG_ATH10K_DEBUGFS is enabled,

Re: [PATCH 5/5] ath10k: reduce invalid ht params rate message noise

On 2/10/21 1:28 AM, Kalle Valo wrote: Wen Gong writes: On 2021-02-10 08:42, Shuah Khan wrote: ath10k_mac_get_rate_flags_ht() floods dmesg with the following messages, when it fails to find a match for mcs=7 and rate=1440. supported_ht_mcs_rate_nss2: {7, {1300, 2700, 1444, 3000} }

Re: [PATCH 4/5] ath10k: detect conf_mutex held ath10k_drain_tx() calls

On 2/10/21 1:25 AM, Kalle Valo wrote: Shuah Khan writes: ath10k_drain_tx() must not be called with conf_mutex held as workers can use that also. Add check to detect conf_mutex held calls. Signed-off-by: Shuah Khan The commit log does not answer to "Why?". How did you find this? What

Re: [PATCH 5/5] ath10k: reduce invalid ht params rate message noise

Wen Gong writes: > On 2021-02-10 08:42, Shuah Khan wrote: >> ath10k_mac_get_rate_flags_ht() floods dmesg with the following >> messages, >> when it fails to find a match for mcs=7 and rate=1440. >> >> supported_ht_mcs_rate_nss2: >> {7, {1300, 2700, 1444, 3000} } >> >> ath10k_pci :02:00.0:

Re: [PATCH 4/5] ath10k: detect conf_mutex held ath10k_drain_tx() calls

Shuah Khan writes: > ath10k_drain_tx() must not be called with conf_mutex held as workers can > use that also. Add check to detect conf_mutex held calls. > > Signed-off-by: Shuah Khan The commit log does not answer to "Why?". How did you find this? What actual problem are you trying to solve?

Re: [PATCH 2/5] ath10k: fix WARNING: suspicious RCU usage

Shuah Khan wrote: > ieee80211_find_sta_by_ifaddr() must be called under the RCU lock and > the resulting pointer is only valid under RCU lock as well. > > Fix ath10k_wmi_tlv_parse_peer_stats_info() to hold RCU lock before it > calls ieee80211_find_sta_by_ifaddr() and release it when the

Re: [PATCH 1/5] ath10k: fix conf_mutex lock assert in ath10k_debug_fw_stats_request()

Shuah Khan wrote: > ath10k_debug_fw_stats_request() is called ath10k_sta_statistics() > without holding conf_mutex. ath10k_debug_fw_stats_request() simply > returns when CONFIG_ATH10K_DEBUGFS is disabled. > > When CONFIG_ATH10K_DEBUGFS is enabled, ath10k_debug_fw_stats_request() > code path

Re: [PATCH 4/5] ath10k: detect conf_mutex held ath10k_drain_tx() calls

. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Shuah-Khan/ath10k-fixes-for-warns/20210210-085259 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git