[PATCH v2] wifi: ath10k: fix NULL pointer dereference in ath10k_wmi_tlv_op_pull_mgmt_tx_compl_ev()

2023-12-07 Thread Xingyuan Mo
We should check whether the WMI_TLV_TAG_STRUCT_MGMT_TX_COMPL_EVENT tlv is present before accessing it, otherwise a null pointer deference error will occur. Fixes: dc405152bb64 ("ath10k: handle mgmt tx completion event") Signed-off-by: Xingyuan Mo --- Compared with the previous version,

Re: [PATCH] ath10k: Don't touch the CE interrupt registers after power up

2023-12-07 Thread Yongqin Liu
On Fri, 8 Dec 2023 at 00:49, Doug Anderson wrote: > > Hi, > > On Thu, Dec 7, 2023 at 6:49 AM Kalle Valo wrote: > > > > > Recently during our Android build test on the Dragonboard 845c board, > > > with the Android Common Kernel android11-5.4-lts and android12-5.4-lts > > > branches, > > > > > >

Re: [PATCH] ath10k: Don't touch the CE interrupt registers after power up

2023-12-07 Thread Doug Anderson
Hi, On Thu, Dec 7, 2023 at 6:49 AM Kalle Valo wrote: > > > Recently during our Android build test on the Dragonboard 845c board, > > with the Android Common Kernel android11-5.4-lts and android12-5.4-lts > > branches, > > > > we found there are some ufshcd related changes printed, > > and the

ath10k-firmware: WCN3990: Add board file for the Qualcomm SDM845 MTP platform

2023-12-07 Thread Dmitry Baryshkov
Hello Kalle, We'd like to ask for inclusion of the board file for the Qualcomm SDM845 MTP board. It is a hardware development kit manufactured by Qualcomm, using the Snapdragon SDM845 SoC and a variant of wcn3990 BT/WiFi chip. Following the questions from the ath10k wiki page: * description for

Re: ath10k-firmware: WCN3990: Add board file for the Qualcomm SDM845 MTP platform

2023-12-07 Thread Dmitry Baryshkov
On Thu, 7 Dec 2023 at 16:59, Kalle Valo wrote: > > > I don't see any attachments, forgot to attach to it? Please resend the > whole file. Oops. Done. -- With best wishes Dmitry

Re: Fwd: ath10k-firmware: QCA9888 hw2.0: Add BDF for ASUS MAP-AC2200

2023-12-07 Thread Kalle Valo
Erkki hietaranta writes: > ASUS MAP-AC2200 is IPQ4019 based device with three radios. > - one QCA40xx radio is used as 2.4GHz radio > - one QCA40xx radio is used as 5GHz radio > -- Both allready supported: > https://www.mail-archive.com/ath10k@lists.infradead.org/msg09696.html > - one QCA9888

Re: ath10k-firmware: WCN3990: Add board file for the Qualcomm SDM845 MTP platform

2023-12-07 Thread Kalle Valo
Dmitry Baryshkov writes: > We'd like to ask for inclusion of the board file for the Qualcomm > SDM845 MTP board. It is a hardware development kit manufactured by > Qualcomm, using the Snapdragon SDM845 SoC and a variant of wcn3990 > BT/WiFi chip. > > Following the questions from the ath10k wiki

Re: ath10k-firmware: WCN3990: Add board file for Xiaomi POCOPHONE F1

2023-12-07 Thread Kalle Valo
Dylan Van Assche writes: > I would like to include the board file for the Xiaomi POCOPHONE F1 > smartphone. > This smartphone is manufactured by Xiaomi and uses the Snapdragon > SDM845 SoC. > At postmarketOS, we run the mainline kernel on this phone so shipping > this board file > from upstream

Re: ath10k-firmware: WCN3990: Add board file for SHIFTPHONES SHIFT6mq

2023-12-07 Thread Kalle Valo
Dylan Van Assche writes: > I would like to include the board file for the SHIFTPHONES SHIFT6mq > smartphone. > This smartphone is manufactured by SHIFTPHONES and uses the Snapdragon > SDM845 SoC. > At postmarketOS, we run the mainline kernel on this phone so shipping > this board file > from

Re: ath10k-firmware: WCN3990: Add board file for the Qualcomm Robotics RB2 platform

2023-12-07 Thread Kalle Valo
Dmitry Baryshkov writes: > We'd like to ask for inclusion of the board file for the Qualcomm > Robotics RB2 platform. It is > an IOT platform manufactured by Thundercomm, using the Snapdragon QRB4210 SoC. > > Following the questions from the ath10k wiki page: > > * description for what hardware

Re: ath10k-firmware: WCN3990: Add board file for Oneplus 6/6T

2023-12-07 Thread Kalle Valo
Dylan Van Assche writes: > I would like to include the board file for the Oneplus 6/6T smartphone. > This smartphone is manufactured by Oneplus and uses the Snapdragon > SDM845 SoC. > At postmarketOS, we run the mainline kernel on this phone so shipping > this board file > from upstream would be

Re: ath10k-firmware: WCN3990: Add board file for the Qualcomm Robotics RB1 platform

2023-12-07 Thread Kalle Valo
Dmitry Baryshkov writes: > Hello Kalle, > > We'd like to ask for inclusion of the board file for the Qualcomm > Robotics RB1 platform. It is > an IOT platform manufactured by Thundercomm, using the Snapdragon QRB2210 SoC. > > Following the questions from the ath10k wiki page: > > * description

Re: ath10k-firmware: QCA4019 hw1.0: Add Eero Cento specific BDFs

2023-12-07 Thread Kalle Valo
"Connor Northway" writes: > Hello, > > I am preparing a commit to port OpenWrt to the Eero Cento, and would > like to provide its board files for inclusion in the official file. > > Following the wiki's form: > > description for what hardware this is: > >- the Eero Cento (model no. J010001)

Re: [PATCH] ath10k: Don't touch the CE interrupt registers after power up

2023-12-07 Thread Kalle Valo
Yongqin Liu writes: > On Sat, 1 Jul 2023 at 06:19, Douglas Anderson wrote: >> >> As talked about in commit d66d24ac300c ("ath10k: Keep track of which >> interrupts fired, don't poll them"), if we access the copy engine >> register at a bad time then ath10k can go boom. However, it's not >>

Re: [PATCH] ath10k: Don't touch the CE interrupt registers after power up

2023-12-07 Thread Yongqin Liu
Hi, Douglas On Sat, 1 Jul 2023 at 06:19, Douglas Anderson wrote: > > As talked about in commit d66d24ac300c ("ath10k: Keep track of which > interrupts fired, don't poll them"), if we access the copy engine > register at a bad time then ath10k can go boom. However, it's not > necessarily easy to

Re: [PATCH] wifi: ath10k: fix NULL pointer dereference in ath10k_wmi_tlv_op_pull_mgmt_tx_compl_ev()

2023-12-07 Thread Kalle Valo
Xingyuan Mo writes: > We should check whether the WMI_TLV_TAG_STRUCT_MGMT_TX_COMPL_EVENT tlv is > present before accessing it, otherwise a null pointer deference error will > occur. I cannot take patches without s-o-b, please read:

[PATCH] wifi: ath10k: fix NULL pointer dereference in ath10k_wmi_tlv_op_pull_mgmt_tx_compl_ev()

2023-12-07 Thread Xingyuan Mo
We should check whether the WMI_TLV_TAG_STRUCT_MGMT_TX_COMPL_EVENT tlv is present before accessing it, otherwise a null pointer deference error will occur. --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH v2 00/35] bitops: add atomic find_bit() operations

2023-12-07 Thread Jan Kara
On Tue 05-12-23 21:22:59, Yury Norov wrote: > On Mon, Dec 04, 2023 at 07:51:01PM +0100, Jan Kara wrote: > > > This series is a result of discussion [1]. All find_bit() functions imply > > > exclusive access to the bitmaps. However, KCSAN reports quite a number > > > of warnings related to