Re: [PATCH v2] ath10k: fix pointer arithmetic error in trace call

at the C standard hasn't caught up? What does -Wpointer-arith buy us? regards, dan carpenter ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

[bug report] ath10k: abstract htt_rx_desc structure

sc_size - sizeof(u32)); 434 435 if (last_msdu) 436 break; 437 } regards, dan carpenter ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

[kvalo-ath:pending 8/17] drivers/net/wireless/ath/ath11k/dp_tx.c:511 ath11k_dp_tx_update_txcompl() error: uninitialized symbol 'rate_idx'.

.01.org/0day-ci/archive/20211223/202112230637.basxpv7i-...@intel.com/config) compiler: microblaze-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: drivers/net/wireless/ath/ath11k/dp_tx.c

[kvalo-ath:pending 52/56] drivers/net/wireless/ath/ath11k/wmi.c:5651 ath11k_wmi_tlv_fw_stats_data_parse() error: uninitialized symbol 'len'.

://download.01.org/0day-ci/archive/20211211/202112110427.o6xdakfe-...@intel.com/config) compiler: riscv64-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter New smatch warnings: drivers/net/wireless/ath

Re: [ath6kl:pending 10/12] drivers/net/wireless/ath/ath10k/mac.c:3010 ath10k_mac_set_sar_specs() warn: this array is probably non-NULL. 'sar->sub_specs'

On Wed, Jan 27, 2021 at 12:52:09PM +0200, Kalle Valo wrote: > Dan Carpenter writes: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git > > pending > > head: 13112a10a90ece17774a25bc363a7561c26aa19f > > commit: c995c0bdf2d68ce279507a201

[ath6kl:pending 10/12] drivers/net/wireless/ath/ath10k/mac.c:3010 ath10k_mac_set_sar_specs() warn: this array is probably non-NULL. 'sar->sub_specs'

as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter New smatch warnings: drivers/net/wireless/ath/ath10k/mac.c:3010 ath10k_mac_set_sar_specs() warn: this array is probably non-NULL

[ath6kl:pending 32/34] drivers/net/wireless/ath/ath11k/mac.c:2431 ath11k_mac_op_set_key() error: we previously assumed 'peer' could be null (see line 2406)

robot Reported-by: Dan Carpenter smatch warnings: drivers/net/wireless/ath/ath11k/mac.c:2431 ath11k_mac_op_set_key() error: we previously assumed 'peer' could be null (see line 2406) # https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?id

Re: [bug report] mmc: core: Re-work HW reset for SDIO cards

On Tue, Dec 17, 2019 at 08:54:47AM +0100, Ulf Hansson wrote: > + Kalle > > On Fri, 13 Dec 2019 at 19:51, Dan Carpenter wrote: > > > > Hello Ulf Hansson, > > > > The patch 2ac55d5e5ec9: "mmc: core: Re-work HW reset for SDIO cards" > > from Oc

[bug report] mmc: core: Re-work HW reset for SDIO cards

It used to be that mmc_hw_reset() return negative error codes or zero but now it returns 1 on certain success paths. 1517 ath10k_warn(ar, "unable to reset sdio: %d\n", ret); 1518 1519 sdio_release_host(ar_sdio->func); 1520 1521

[ath6kl:pending-ath11k 316/345] drivers/net/wireless/ath/ath11k/debug.c:575 ath11k_write_simulate_fw_crash() error: we previously assumed 'ar' could be null (see line 549)

tag Reported-by: kbuild test robot Reported-by: Dan Carpenter New smatch warnings: drivers/net/wireless/ath/ath11k/debug.c:575 ath11k_write_simulate_fw_crash() error: we previously assumed 'ar' could be null (see line 549) Old smatch warnings: drivers/net/wireless/ath/ath11k/debug.c:566

[PATCH] ath10k: Fix an && vs || typo

The kernel will Oops later in the function if either of these pointers is NULL so clearly || was intended instead of &&. Fixes: 3f14b73c3843 ("ath10k: Enable MSA region dump support for WCN3990") Signed-off-by: Dan Carpenter --- drivers/net/wireless/ath/ath10k/snoc.c | 2 +-

Re: [ath6kl:pending-ath11k 198/205] drivers/net/wireless/ath/ath11k/mac.c:1274 ath11k_peer_assoc_h_he() error: memcpy() 'he_cap->he_cap_elem.mac_cap_info' too small (6 vs 8)

a146f113e4197 > > commit: cbdb3159fdf450b7b3999a06600aa0e1fb78383f [198/205] ath11k: set > > additional values inside wmi_peer_assoc_complete_cmd > > > > If you fix the issue, kindly add following tag > > Reported-by: kbuild test robot > > Reported-by: Dan Carpenter > > >

[ath6kl:ath11k-bringup 93/93] drivers/net/wireless/ath/ath11k/debug.c:1143 ath11k_write_pktlog_filter() warn: inconsistent returns 'mutex:>conf_mutex'.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath11k-bringup head: 9bcbbf4cedb7a1f30cb547cf87dc480d7f8a5e87 commit: 9bcbbf4cedb7a1f30cb547cf87dc480d7f8a5e87 [93/93] ath11k: enable pktlog filter per peer New smatch warnings: drivers/net/wireless/ath/ath11k/debug.c:1143

[ath6kl:ath11k-bringup 92/93] drivers/net/wireless/ath/ath11k/dp_rx.c:991 ath11k_htt_pull_ppdu_stats() warn: add some parenthesis here?

tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath11k-bringup head: 9bcbbf4cedb7a1f30cb547cf87dc480d7f8a5e87 commit: b186001339ca6058afd49d7611647bd766dd555e [92/93] ath11k: add pktlog rxbuf support New smatch warnings: drivers/net/wireless/ath/ath11k/dp_rx.c:991

[ath6kl:ath11k-bringup 89/93] drivers/net/wireless/ath/ath11k/core.c:621 ath11k_qmi_firmware_indication() warn: inconsistent returns 'mutex:>core_lock'.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath11k-bringup head: 9bcbbf4cedb7a1f30cb547cf87dc480d7f8a5e87 commit: 426598fdbef82ace7b4a728445f61ecf034f233c [89/93] ath11k: add qmi API support and rproc_boot for Q6 New smatch warnings:

[ath6kl:ath11k-bringup 66/93] drivers/net/wireless/ath/ath11k/core.c:755 ath11k_core_restart() warn: inconsistent returns 'mutex:>core_lock'.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath11k-bringup head: 9bcbbf4cedb7a1f30cb547cf87dc480d7f8a5e87 commit: 3a7b4838b6f6f234239f263ef3dc02e612a083ad [66/93] ath11k: Add support for subsystem recovery :: branch date: 4 days ago :: commit date: 12 days ago

[ath6kl:ath11k-bringup 58/93] drivers/net/wireless/ath/ath11k/debug.c:697 ath11k_write_simulate_fw_crash() error: uninitialized symbol 'radioup'.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath11k-bringup head: 9bcbbf4cedb7a1f30cb547cf87dc480d7f8a5e87 commit: 5cf3588467b76d48542fd0ff70fc666a723df3bb [58/93] ath11k: make simulate_fw_crash to work if any radio is up smatch warnings:

[ath6kl:ath11k-bringup 47/93] drivers/net/wireless/ath/ath11k/hal_rx.c:939 ath11k_hal_rx_parse_mon_status_tlv() warn: masked condition '(info1 & (1 << (6))) == 1' is always false.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath11k-bringup head: 9bcbbf4cedb7a1f30cb547cf87dc480d7f8a5e87 commit: 627a418bbae46c034b1fd8739c0e94fa62190620 [47/93] ath11k: process monitor status ring for RX stats New smatch warnings:

Re: [PATCH 3/4] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

int groupsize, > if (j) > lx--; > } > - if (!ascii) > + if (!flags & HEXDUMP_ASCII) ^^ This is a precedence bug. It should be if (!(flags & HEXDUMP_ASCII)). > goto nil; > regards, dan carpenter

Re: [PATCHv3 1/9] nl80211: New netlink command for TID specific configuration

Hi Tamizh, Thank you for the patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Tamizh-chelvam/cfg80211-mac80211-Add-support-for-TID-specific-configuration/20190308-195433 base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master

[ath6kl:ath11k-bringup 3/44] drivers/net/wireless/ath/ath11k/mac.c:2186 ath11k_set_key() warn: impossible condition '(arvif->def_wep_key_index == -1) => (0-255 == (-1))'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath11k-bringup head: e495d474d12aaf6e6288bf7cb3ba0eab4888f27f commit: 258bbf525e652e244aa8b2331f55fda573fbe926 [3/44] ath11k: add driver New smatch warnings: drivers/net/wireless/ath/ath11k/mac.c:2186 ath11k_set_key() warn:

Re: [PATCHv3 8/9] ath10k: Add new api to support TID specific configuration

Hi Tamizh, url: https://github.com/0day-ci/linux/commits/Tamizh-chelvam/cfg80211-mac80211-Add-support-for-TID-specific-configuration/20190308-195433 base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master smatch warnings:

[ath6kl:pending 14/43] drivers/net/wireless/ath/wil6210/txrx.c:341 wil_rx_add_radiotap_header() error: potentially dereferencing uninitialized 'rtap'.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending head: 6600762d087f745bb0ee1cdf12a6611c2f852e79 commit: 88f31c736d0ac41bc93fadf853e71b16e8ffbc2f [14/43] wil6210: remove rtap_include_phy_info module param smatch warnings: drivers/net/wireless/ath/wil6210/txrx.c:341

[PATCH] ath10k: remove an unnecessary NULL check

The "survey" pointer is the address of an array element. We know that it can't be NULL so this check can be removed. Signed-off-by: Dan Carpenter --- Resending with linux-wireless Cc for patchwork. drivers/net/wireless/ath/ath10k/wmi.c | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH] ath10k: remove an unnecessary NULL check

On Thu, Nov 29, 2018 at 03:51:24PM +0200, Kalle Valo wrote: > Dan Carpenter writes: > > > The "survey" pointer is the address of an array element. We know that > > it can't be NULL so this check can be removed. > > > > Signed-off-by: Dan Carpenter >

[PATCH] ath10k: remove an unnecessary NULL check

The "survey" pointer is the address of an array element. We know that it can't be NULL so this check can be removed. Signed-off-by: Dan Carpenter --- drivers/net/wireless/ath/ath10k/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/at

Re: [PATCH] ath10k: fix a NULL vs IS_ERR() check

On Mon, Nov 26, 2018 at 10:24:38AM +0200, Kalle Valo wrote: > Dan Carpenter writes: > > > The devm_memremap() function doesn't return NULLs, it returns error > > pointers. > > > > Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client

[PATCH] ath10k: fix a NULL vs IS_ERR() check

The devm_memremap() function doesn't return NULLs, it returns error pointers. Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client") Signed-off-by: Dan Carpenter --- drivers/net/wireless/ath/ath10k/qmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[ath6kl:pending 46/46] drivers/net/wireless/ath/ath10k/pci.c:3687 ath10k_pci_remove() warn: variable dereferenced before check 'ar' (see line 3685)

tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending head: 9fb5f44c1dff6c461f0ceaf3e6665cedc99cc1b4 commit: 9fb5f44c1dff6c461f0ceaf3e6665cedc99cc1b4 [46/46] ath10k: Add wrapper function to ath10k debug smatch warnings: drivers/net/wireless/ath/ath10k/pci.c:3687

[PATCH] ath10k: Fixup extended per sta tx statistics

hat, but it's harmless to set it to NULL so I did. Fixes: a904417fc876 ("ath10k: add extended per sta tx statistics support") Signed-off-by: Dan Carpenter --- drivers/net/wireless/ath/ath10k/mac.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/wirel

[PATCH] ath10k: htt: remove some dead code

We added an unnecessary condition here in commit a904417fc876 ("ath10k: add extended per sta tx statistics support"). "legacy_rate_idx" is a u8 so it can't be negative. The caller doesn't pass negatives either. I have deleted this code. Signed-off-by: Dan Carpenter --- I

[bug report] ath10k: get the legacy rate index to update the txrate table

arsta->txrate.flags = RATE_INFO_FLAGS_MCS; 2793 arsta->txrate.mcs = txrate.mcs + 8 * (txrate.nss - 1); regards, dan carpenter ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

[bug report] ath10k: add support for configuring management packet rate

\n", ret); 5701 } ^ End. Looks like a bug. 5702 5703 mutex_unlock(>conf_mutex); 5704 } regards, dan carpenter ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

[bug report] ath10k: add support for configuring management packet rate

return hw_value_prefix | ath10k_rates[i].hw_value; 170 } 171 172 return -EINVAL; 173 } 174 regards, dan carpenter ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

[ath6kl:pending 39/55] drivers/net/wireless/ath/ath10k/mac.c:169 ath10k_mac_get_rate_hw_value() error: buffer overflow 'ath10k_rates' 12 <= 143

tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending head: 2305dc3c6b1d66a7bef752439919d61478e02893 commit: 0c737c78082055ff589f6683e93b45f079c5d64e [39/55] ath10k: Add support for configuring management packet rate New smatch warnings:

Re: [PATCH net-next] ath10k: make some functions static

Ah... Thanks for the explanation. I was really confused how it got the name wrong. regards, dan carpenter ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH net-next] ath10k: make some functions static

anually this > time. > > [1] "weiyongjun (A)" in https://patchwork.kernel.org/patch/10440159/ > > [2] https://patchwork.kernel.org/register/ That's a weird patchwork issue... It sounds like this is a known bug? regards, dan carpenter _

[ath6kl:pending 88/88] drivers/net/wireless/ath/wcn36xx/main.c:554 wcn36xx_set_key() error: we previously assumed 'sta' could be null (see line 496)

tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending head: cc31b4934693c223de25dc0cec69c1a2bd9e1650 commit: cc31b4934693c223de25dc0cec69c1a2bd9e1650 [88/88] wcn36xx: Fix WEP encryption smatch warnings: drivers/net/wireless/ath/wcn36xx/main.c:554 wcn36xx_set_key()

[ath6kl:pending 12/14] drivers/net/wireless/ath/ath9k/calib.c:270 ath9k_hw_loadnf() error: buffer overflow 'ath9k_hw_get_nf_limits(ah, chan)->cal' 3 <= 5

tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending head: e5ff4344eab68c86e00036e937847ce89dfaeef6 commit: 15511de6d14c8b947499c3546a40181221b272fe [12/14] ath9k: Use calibrated noise floor value when available smatch warnings:

[bug report] ath10k: add memory dump support for QCA6174/QCA9377

cur_section->start) { 1487 ath10k_warn(ar, "incorrect memdump region 0x%x with section start addrress 0x%x.\n", 1488 mem_region->start, cur_section->start); 1489 retu

[patch v2] ath10k: add some sanity checks

Smatch complains that since "ev->peer_id" comes from skb->data that means we can't trust it and have to do a bounds check on it to prevent an array overflow. Fixes: 6942726f7f7b ('ath10k: add fast peer_map lookup') Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>

[patch] ath10k: add some sanity checks

Smatch complains that since "ev->peer_id" comes from skb->data that means we can't trust it and have to do a bounds check on it to prevent an array overflow. Fixes: 6942726f7f7b ('ath10k: add fast peer_map lookup') Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> di

Re: ath10k: implement updating shared htt txq state

211_sta, drv_priv)`. Ah, yeah. You're right. The other warning should be fixed though. regards, dan carpenter ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: ath10k: implement updating shared htt txq state

On Mon, Apr 11, 2016 at 10:44:01AM +0300, Dan Carpenter wrote: > On Mon, Apr 11, 2016 at 09:33:43AM +0200, Michal Kazior wrote: > > > There are several new warnings. See also: > > > > This is a false positive. > > > > The `txq->sta->drv_priv` i

re: ath10k: implement updating shared htt txq state

efore check 'txq' (see line 84) drivers/net/wireless/ath/ath10k/mac.c:3629 ath10k_mac_txq_init() warn: variable dereferenced before check 'txq' (see line 3627) drivers/net/wireless/ath/ath10k/mac.c:3642 ath10k_mac_txq_unref() warn: variable dereferenced before check 't

re: ath10k: replace vdev_id and tid in skb cb

dev_id; 452 else if (ar->monitor_started) See also: drivers/net/wireless/ath/ath10k/wmi.c:1830 ath10k_wmi_op_gen_mgmt_tx() warn: variable dereferenced before check 'cb->vif' (see line 1818) regards, dan carpenter ___ ath10k mai

re: ath10k: fix peer limit enforcement

(ar-free_vdev_map); regards, dan carpenter ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k