Re: CVE-2020-3702: Firmware updates for ath9k and ath10k chips

2020-08-12 Thread Michał Kazior
On Wed, 12 Aug 2020 at 11:26, Jouni Malinen wrote: > > On Wed, Aug 12, 2020 at 11:17:47AM +0200, Toke Høiland-Jørgensen wrote: > > Pali Rohár writes: > > > Could somebody react and provide some details when fixes would be > > > available for ath9k and ath10k Linux drivers? And what is current

Re: [PATCHv2] ath10k: Add wrapper function to ath10k debug

2019-04-26 Thread Michał Kazior
On Fri, 26 Apr 2019 at 14:58, Venkateswara Naralasetty wrote: > > ath10k_dbg() is called in ath10k_process_rx() with huge set of arguments > which is causing CPU overhead even when debug_mask is not set. > Good improvement was observed in the receive side performance when call > to ath10k_dbg()

Re: [PATCH] ath10k: Remove ATH10K_STATE_RESTARTED in simulate fw crash

2019-04-08 Thread Michał Kazior
On Mon, 8 Apr 2019 at 12:20, Wen Gong wrote: > > -Original Message- > > From: Wen Gong > > Sent: Monday, April 1, 2019 2:11 PM > > To: 'Michał Kazior' > > Cc: Wen Gong ; linux-wireless > wirel...@vger.kernel.org>; ath10k@lists.infradead.org >

Re: [PATCH] ath10k: pci: use mutex for diagnostic window CE polling

2019-03-25 Thread Michał Kazior
Hi Brian, On Mon, 25 Mar 2019 at 21:27, Brian Norris wrote: > Hi Kalle, > > On Wed, Feb 06, 2019 at 05:41:43PM -0800, Brian Norris wrote: > > The DIAG copy engine is only used via polling, but it holds a spinlock > > with softirqs disabled. Each iteration of our read/write loops can > >

Re: [PATCH] ath10k: Remove ATH10K_STATE_RESTARTED in simulate fw crash

2019-01-07 Thread Michał Kazior
On Mon, 7 Jan 2019 at 08:16, Wen Gong wrote: > > > > It is because the state has not changed to ATH10K_STATE_ON > > > immediately, then it will have more than two simulate crash process > > > running meanwhile, and complete/wakeup some field twice, it destroy > > > the normal recovery process. >

Re: [PATCH] ath10k: support PCIe enter L1 state

2018-11-15 Thread Michał Kazior
On Fri, 16 Nov 2018 at 08:00, Kalle Valo wrote: > > Brian Norris writes: > > On Thu, Nov 15, 2018 at 06:38:25AM +, Wen Gong wrote: > >> > > >> > Is there some reason L1 was disabled in the first place? Was it known to > >> > be > >> > unreliable? > >> > >> Hi Brian, > >> It is a BUG for

Re: [PATCH] ath10k: Remove ATH10K_STATE_RESTARTED in simulate fw crash

2018-11-13 Thread Michał Kazior
On Wed, 14 Nov 2018 at 03:51, Wen Gong wrote: > > When test simulate firmware crash, it is easy to trigger error. > command: > echo soft > /sys/kernel/debug/ieee80211/phyxx/ath10k/simulate_fw_crash. > > If input more than two times continuously, then it will have error. > Error message: >

Re: ath10k kernel requirements (coherent_pool etc)

2018-08-09 Thread Michał Kazior
On 8 August 2018 at 18:56, Arthur Watt wrote: > Good afternoon. > > We have been testing 3 x ath10k devices on a 4.14 based Linux kernel with a > Cavium processor. > Up to this point we have been seeing some unexplained crashes from the ath10k > devices (firmware crashes due to corrupt HTC

Re: [PATCH 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips

2018-07-27 Thread Michał Kazior
On 27 July 2018 at 11:39, Wen Gong wrote: > On 2018-07-26 21:02, Michał Kazior wrote: >> >> On 26 July 2018 at 13:45, Toke Høiland-Jørgensen wrote: >>> >>> Wen Gong writes: >>> >>>> Upstream kernel has an interface to help adjust

Re: [PATCH 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips

2018-07-26 Thread Michał Kazior
On 26 July 2018 at 13:45, Toke Høiland-Jørgensen wrote: > Wen Gong writes: > >> Upstream kernel has an interface to help adjust sk_pacing_shift to help >> improve TCP UL throughput. >> The sk_pacing_shift is 8 in mac80211, this is based on test with 11N >> WiFi chips with ath9k. For

Re: [PATCH] ath10k: fix vdev-start timeout on error

2018-07-13 Thread Michał Kazior
On 13 July 2018 at 19:08, wrote: > From: Ben Greear > > The vdev-start-response message should cause the > completion to fire, even in the error case. Otherwise, > the user still gets no useful information and everything > is blocked until the timeout period. > > Add some warning text to print

Re: [RFC] ath10k: Attempt to work around napi_synchronize hang.

2018-02-28 Thread Michał Kazior
On 28 February 2018 at 02:22, wrote: [...] > @@ -2086,8 +2087,28 @@ static void ath10k_pci_hif_stop(struct ath10k *ar) > ath10k_pci_irq_disable(ar); > ath10k_pci_irq_sync(ar); > ath10k_pci_flush(ar); > - napi_synchronize(>napi); > -