Re: [PATCH v3 1/3] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-05-07 Thread Rob Herring (Arm)
n firmware-5.bin to trigger > work-around in the driver. However, firmware-5.bin is parsed too late. > So we are stuck with a DT property. > > Signed-off-by: Pierre-Hugues Husson > Signed-off-by: Marc Gonzalez > --- > Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml | 5 + > 1 file changed, 5 insertions(+) > Acked-by: Rob Herring (Arm)

[PATCH v2] net: wireless: Explicitly include correct DT includes

2023-07-24 Thread Rob Herring
s a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes. Signed-off-by: Rob Herring --- v2: - Split out can, dsa, wir

Re: [PATCH v1] dt-bindings: net: wireless: ath10k: add ieee80211-freq-limit property

2023-06-09 Thread Rob Herring
On Fri, 09 Jun 2023 19:27:23 +0200, Christian Lamparter wrote: > This is an existing optional property that ieee80211.yaml/cfg80211 > provides. It's useful to further restrict supported frequencies > for a specified device through device-tree. > > The driver supported this since ~2018 by >

Re: [PATCH v3 1/2] dt-bindings: net: Convert ATH10K to YAML

2023-04-06 Thread Rob Herring
On Thu, 06 Apr 2023 14:55:44 +0200, Konrad Dybcio wrote: > Convert the ATH10K bindings to YAML. > > Dropped properties that are absent at the current state of mainline: > - qcom,msi_addr > - qcom,msi_base > > qcom,coexist-support and qcom,coexist-gpio-pin do very little and should > be

Re: [PATCH v2 1/2] dt-bindings: net: Convert ATH10K to YAML

2023-04-06 Thread Rob Herring
On Thu, 06 Apr 2023 13:54:04 +0200, Konrad Dybcio wrote: > Convert the ATH10K bindings to YAML. > > Dropped properties that are absent at the current state of mainline: > - qcom,msi_addr > - qcom,msi_base > > qcom,coexist-support and qcom,coexist-gpio-pin do very little and should > be

Re: [PATCH v6 3/3] wifi: ath10k: only load compatible DT cal data

2023-02-09 Thread Rob Herring
On Wed, Feb 8, 2023 at 10:51 PM wrote: > > From: Edward Chow > > ath10k might also be sensitive to the issue reported on > https://github.com/openwrt/openwrt/pull/11345 , loading calibration > data from a device tree node declared incompatible. > > ath10k will first check whether the device tree

Re: [PATCH v5 3/3] wifi: ath10k: only load compatible DT cal data

2023-02-03 Thread Rob Herring
On Fri, Feb 3, 2023 at 11:15 AM wrote: > > > I think this can be done a bit cleaner and like other drivers. I see 2 > > options. > > The first way is use VID/PID compatible strings and don't set the > > of_node pointer if there is a mismatch. > Where should I do this? In pci_set_of_node() from

Re: [PATCH v5 3/3] wifi: ath10k: only load compatible DT cal data

2023-02-03 Thread Rob Herring
On Fri, Feb 3, 2023 at 4:48 AM wrote: > > From: Edward Chow > > ath10k might also be sensitive to the issue reported on > https://github.com/openwrt/openwrt/pull/11345 , loading calibration > data from a device tree node declared incompatible. > > ath10k will first check whether the device tree

Re: [PATCH v2 2/2] dt: bindings: add dt entry for ath10k default BDF name

2022-01-11 Thread Rob Herring
Changes in v2: > - Changes in v2: none > > .../devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 > 1 file changed, 4 insertions(+) > Acked-by: Rob Herring ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH v1 01/15] dt-bindings: add pwrseq device tree bindings

2021-10-27 Thread Rob Herring
On Tue, Oct 26, 2021 at 9:42 AM Dmitry Baryshkov wrote: > > On 26/10/2021 15:53, Rob Herring wrote: > > On Wed, Oct 06, 2021 at 06:53:53AM +0300, Dmitry Baryshkov wrote: > >> Add device tree bindings for the new power sequencer subsystem. > >> Consumers would ref

Re: [PATCH v1 01/15] dt-bindings: add pwrseq device tree bindings

2021-10-26 Thread Rob Herring
On Wed, Oct 06, 2021 at 06:53:53AM +0300, Dmitry Baryshkov wrote: > Add device tree bindings for the new power sequencer subsystem. > Consumers would reference pwrseq nodes using "foo-pwrseq" properties. > Providers would use '#pwrseq-cells' property to declare the amount of > cells in the pwrseq

Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests

2020-09-29 Thread Rob Herring
On Fri, Sep 25, 2020 at 11:59:41PM +0530, Amit Pundir wrote: > There are firmware versions which do not support host capability > QMI request. We suspect either the host cap is not implemented or > there may be firmware specific issues, but apparently there seem > to be a generation of firmware

Re: [PATCH v2 2/2] dt: bindings: ath10k: Document qcom,ath10k-pre-calibration-data-mtd

2020-09-23 Thread Rob Herring
On Fri, Sep 18, 2020 at 08:11:03PM +0200, Ansuel Smith wrote: > Document use of qcom,ath10k-pre-calibration-data-mtd bindings used to > define from where the driver will load the pre-cal data in the defined > mtd partition. > > Signed-off-by: Ansuel Smith > --- >

Re: [PATCH 1/2] dt: bindings: Add new regulator as optional property for WCN3990

2020-07-15 Thread Rob Herring
ndings/net/wireless/qcom,ath10k.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Rob Herring ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH v3 1/3] dt-bindings: ath10k: Add wifi-firmware subnode for wifi node

2020-04-28 Thread Rob Herring
eless/qcom,ath10k.txt | 14 > ++ > 1 file changed, 14 insertions(+) > Acked-by: Rob Herring ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH v2 1/3] dt-bindings: ath10k: Add wifi-firmware subnode for wifi node

2020-03-31 Thread Rob Herring
On Wed, Mar 25, 2020 at 04:31:38PM +0530, Rakesh Pillai wrote: > Add a wifi-firmware subnode for the wifi node. > This wifi-firmware subnode is needed for the > targets which do not support TrustZone. > > Signed-off-by: Rakesh Pillai > --- > .../devicetree/bindings/net/wireless/qcom,ath10k.txt

Re: [PATCHv2 1/2] dt-bindings: ath10k: Add new dt entries to identify coex support

2020-02-05 Thread Rob Herring
on is needed for the hardware QCA4019. > > Signed-off-by: Tamizh Chelvam > --- > Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 7 +++ > 1 file changed, 7 insertions(+) > Reviewed-by: Rob Herring

Re: [PATCH 1/2] ath10k: Add optional qdss clk

2020-01-08 Thread Rob Herring
st of clocks in the driver. > > Signed-off-by: Bjorn Andersson > --- > Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 2 +- > drivers/net/wireless/ath/ath10k/snoc.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletion

Re: [PATCH 1/2] dt-bindings: ath10k: Add new dt entries to identify coex support

2019-12-30 Thread Rob Herring
On Sun, Dec 29, 2019 at 10:07 PM wrote: > > Hi Rob, > > Thanks for your review comments. > > >> This adds new dt entries qcom,coexist-support and > >> qcom,coexist-gpio-pin > >> which will be used by ath10k driver to identify coex support > >> of a hardware and notify wifi firmware the gpio pin

Re: [PATCH 1/2] dt-bindings: ath10k: Add new dt entries to identify coex support

2019-12-26 Thread Rob Herring
On Mon, Dec 16, 2019 at 05:10:14PM +0530, Tamizh Chelvam wrote: > This adds new dt entries qcom,coexist-support and qcom,coexist-gpio-pin > which will be used by ath10k driver to identify coex support > of a hardware and notify wifi firmware the gpio pin number. > This pin number information is

Re: [PATCH v2 1/2] dt: bindings: add dt entry flag to skip SCM call for msa region

2019-11-14 Thread Rob Herring
On Mon, Nov 11, 2019 at 09:55:07AM +0530, Govind Singh wrote: > Add boolean context flag to disable SCM call for statically > mapped msa region. Can't this be implied by the compatible string? > > Signed-off-by: Govind Singh > --- > .../devicetree/bindings/net/wireless/qcom,ath10k.txt

Re: [PATCH] ath10k: Fix HOST capability QMI incompatibility

2019-08-16 Thread Rob Herring
68ec4c012ac ("ath10k: update HOST capability qmi message") > Signed-off-by: Bjorn Andersson > --- > .../bindings/net/wireless/qcom,ath10k.txt | 6 + Acked-by: Rob Herring > drivers/net/wireless/ath/ath10k/qmi.c | 13 --- > .../net/wireless/ath/ath10k/

Re: [PATCH v3 1/2] dt: bindings: add dt entry for XO calibration support

2019-04-06 Thread Rob Herring
On Mon, 1 Apr 2019 14:49:25 +0530, Govind Singh wrote: > Add dt binding to get xo calibration data support for wifi rf clock. > > Signed-off-by: Govind Singh > --- > Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 1 + > 1 file changed, 1 insertion(+) &g

Re: [PATCH 1/2] dt: bindings: add dt entry for XO calibration support

2019-03-27 Thread Rob Herring
On Sat, Mar 02, 2019 at 10:36:34AM +0530, Govind Singh wrote: > Add dt binding to get xo calibration data support for wifi rf clock. > > Signed-off-by: Govind Singh > --- > Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH v4 1/3] dt-bindings: net: ath10k: fix node name and device type in qcom ath10k example

2018-12-17 Thread Rob Herring
remove the property device_type > pci since only pci bridges should have this property. > > Signed-off-by: Bhagavathi Perumal S > --- > Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 3 +-- > 1 file changed, 1 insertion(+), 2 dele

Re: [PATCH v4 2/3] dt-bindings: net: ath10k: add new dt entry to identify external FEM

2018-12-17 Thread Rob Herring
On Tue, Dec 11, 2018 at 09:43:23PM +0530, Bhagavathi Perumal S wrote: > This adds new dt entry ext-fem-name, it is used by ath10k driver > to select correct timing parameters and configure it in target wifi hardware. > The Front End Module(FEM) normally includes tx power amplifier(PA) and > rx low

Re: [PATCH v3 2/3] dt-bindings: net: ath10k: add new dt entry to identify external FEM

2018-12-10 Thread Rob Herring
oose correct > timing values in driver if different external FEM hardware used. > > Signed-off-by: Bhagavathi Perumal S > --- > Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 9 - > 1 file changed, 8 insertions(+), 1 d

Re: [PATCH v3 1/3] dt-bindings: net: ath10k: fix node name and device type in qcom ath10k example

2018-12-10 Thread Rob Herring
On Tue, Dec 11, 2018 at 12:01:29AM +0530, Bhagavathi Perumal S wrote: > In qcom,ath10k documentation, ath10k is used as node name in the example of > pci based device. Normally, node name shoud be class of device and not the > model s/shoud/should/ > name, so fix it to node name "wifi". And

Re: [PATCH 1/2] dt: bindings: add new dt entry to indentify external FEM

2018-10-30 Thread Rob Herring
On Tue, Oct 30, 2018 at 3:41 AM wrote: > > On 2018-10-16 00:54, Rob Herring wrote: > > On Thu, Oct 04, 2018 at 05:12:43PM +0530, Bhagavathi Perumal S wrote: > >> This adds new dt entry ext-fem-name, it is used by ath10k driver > >> to select correct timing paramet

Re: [PATCH 1/2] dt: bindings: add new dt entry to indentify external FEM

2018-10-15 Thread Rob Herring
On Thu, Oct 04, 2018 at 05:12:43PM +0530, Bhagavathi Perumal S wrote: > This adds new dt entry ext-fem-name, it is used by ath10k driver > to select correct timing parameters and configure it in target wifi hardware. > The Front End Module(FEM) normally includes tx power amplifier(PA) and > rx low

Re: [PATCH v3 1/3] dt: bindings: add missing dt properties for WCN3990 wifi node

2018-10-12 Thread Rob Herring
tions(+), 7 deletions(-) > Reviewed-by: Rob Herring ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH 3/4] dt: bindings: add bindings for wifi iommu node

2018-09-25 Thread Rob Herring
On Fri, Sep 21, 2018 at 02:39:06PM +0530, Govind Singh wrote: > WCN3990 wifi module can optionally make use of the IOMMU. Can the other compatibles use IOMMU too? > Add binding documentation for phandle to the IOMMU and > the stream id of wifi iommu block. > > Signed-off-by: Govind Singh > ---

Re: [PATCH 1/4] dt: bindings: add missing dt properties for WCN3990 wifi node

2018-09-25 Thread Rob Herring
On Fri, Sep 21, 2018 at 02:39:04PM +0530, Govind Singh wrote: > Add missing optional properties in WCN3990 wifi node. > > Signed-off-by: Govind Singh > --- > .../bindings/net/wireless/qcom,ath10k.txt | 22 +-- > 1 file changed, 15 insertions(+), 7 deletions(-) > > diff

Re: [PATCH v5 3/6] dt: bindings: add bindings for msa memory region

2018-08-15 Thread Rob Herring
On Wed, Aug 15, 2018 at 02:56:34PM +0530, Govind Singh wrote: > Add device tree binding documentation details of msa > memory region for ath10k qmi client for SDM845/APQ8098 > SoC into "qcom,ath10k.txt". > > Signed-off-by: Govind Singh > --- >

Re: [PATCH v4 3/6] dt: bindings: add bindings for msa memory region

2018-07-24 Thread Rob Herring
tree/bindings/net/wireless/qcom,ath10k.txt| 6 ++ > 1 file changed, 6 insertions(+) Reviewed-by: Rob Herring ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH v3 3/6] dt: bindings: add bindings for msa memory region

2018-07-11 Thread Rob Herring
On Fri, Jul 06, 2018 at 02:30:43PM +0530, Govind Singh wrote: > Add device tree binding documentation details of msa > memory region for ath10k qmi client for SDM845/APQ8098 > SoC into "qcom,ath10k.txt". > > Signed-off-by: Govind Singh > --- > .../bindings/net/wireless/qcom,ath10k.txt

Re: [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block

2018-04-13 Thread Rob Herring
> .../bindings/net/wireless/qcom,ath10k.txt | 31 > ++ > 1 file changed, 31 insertions(+) One nit, otherwise: Reviewed-by: Rob Herring <r...@kernel.org> > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt

Re: [PATCH v2] dt: bindings: add bindings for wcn3990 wifi block

2018-02-19 Thread Rob Herring
On Fri, Feb 16, 2018 at 10:13:48AM +0530, Govind Singh wrote: > Add device tree binding documentation details for wcn3990 > wifi block present in Qualcomm SDM845/APQ8098 SoC into > "qcom,ath10k.txt". > > Signed-off-by: Govind Singh > --- >

Re: [PATCH v2 1/2] dt: bindings: add new dt entry for ath10k calibration variant

2017-12-12 Thread Rob Herring
correct board data for a design which was modified by an ODM. > > Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> > --- > Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 3 +++ > 1 file changed,

Re: [PATCH 1/2] dt: bindings: add new dt entry for ath10k calibration variant

2017-03-21 Thread Rob Herring
On Tue, Mar 21, 2017 at 9:33 AM, Sven Eckelmann <sven.eckelm...@openmesh.com> wrote: > On Dienstag, 21. März 2017 08:00:34 CET Rob Herring wrote: > [...] >> > It would then up with something like this as compatibility string: >> > >> > * qcom,ipq4019-wifi-

Re: [PATCH 1/2] dt: bindings: add new dt entry for ath10k calibration variant

2017-03-21 Thread Rob Herring
On Mon, Mar 20, 2017 at 11:28 AM, Sven Eckelmann <sven.eckelm...@openmesh.com> wrote: > On Montag, 20. März 2017 10:07:33 CET Rob Herring wrote: >> On Fri, Mar 10, 2017 at 09:06:14AM +0100, Sven Eckelmann wrote: >> > The bus + bmi-chip-id + bmi-board-id is not enough

Re: [PATCH 1/2] dt: bindings: add new dt entry for ath10k calibration variant

2017-03-20 Thread Rob Herring
On Fri, Mar 10, 2017 at 09:06:14AM +0100, Sven Eckelmann wrote: > The bus + bmi-chip-id + bmi-board-id is not enough to identify the correct > board data file on QCA4019 based devices. Multiple different boards share > the same values. Only the original reference designs can currently be >

Re: [PATCHv2 3/4] dt: bindings: add new dt entry for BTCOEX feature in qcom,ath10k.txt

2016-11-18 Thread Rob Herring
On Thu, Nov 17, 2016 at 05:14:23PM +0530, c_tr...@qti.qualcomm.com wrote: > From: Tamizh chelvam > > There two things done in this patch. > > 1) 'btcoex_support' flag for BTCOEX feature support by the hardware. > 2) 'wlan_btcoex_gpio' is used to fill wlan priority

Re: [PATCH] dt: bindings: add new dt entry for pre calibration in qcom,ath10k.txt

2016-03-19 Thread Rob Herring
l data download sequence > > .../bindings/net/wireless/qcom,ath10k.txt | 23 > +++++++--- > 1 file changed, 16 insertions(+), 7 deletions(-) Acked-by: Rob Herring <r...@kernel.org> ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH v3] dt: bindings: add bindings for ipq4019 wifi block

2016-01-14 Thread Rob Herring
i_addr" and >"qca,msi_base" to "qcom,msi_base" to follow uniformity. > > .../bindings/net/wireless/qcom,ath10k.txt | 89 > -- > 1 file changed, 84 insertions(+), 5 deletions(-) A few typos, otherwise: Acked-by: Rob Herr

Re: [PATCH] dt: bindings: add bindings for ipq4019 wifi block

2016-01-12 Thread Rob Herring
On Wed, Dec 30, 2015 at 11:41 PM, Raja Mani <rm...@qti.qualcomm.com> wrote: > > On Wednesday 30 December 2015 10:05 PM, Rob Herring wrote: >> >> On Wed, Dec 23, 2015 at 11:05:15AM +0530, Raja Mani wrote: >>> >>> Add device tree binding documentation deta