Re: [PATCH] ath10k: fix the status check and wrong return

On Mon, Aug 17, 2020 at 6:43 PM Tang Bin wrote: > > Hi Kalle： > > 在 2020/8/17 22:26, Kalle Valo 写道: > >> In the function ath10k_ahb_clock_init(), devm_clk_get() doesn't > >> return NULL. Thus use IS_ERR() and PTR_ERR() to validate > >> the returned value instead of IS_ERR_OR_NULL(). > > Why?

Re: [RFC 1/2] devlink: add simple fw crash helpers

On Fri, May 22, 2020 at 2:51 PM Luis Chamberlain wrote: > > On Fri, May 22, 2020 at 10:46:07PM +0200, Johannes Berg wrote: > > FWIW, I still completely disagree on that taint. You (Luis) obviously > > have been running into a bug in that driver, I doubt the firmware > > actually managed to wedge

Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed()

On Mon, May 18, 2020 at 10:19 AM Luis Chamberlain wrote: > > On Mon, May 18, 2020 at 10:15:45AM -0700, Ben Greear wrote: > > > > > > On 05/18/2020 10:09 AM, Luis Chamberlain wrote: > > > On Mon, May 18, 2020 at 09:58:53AM -0700, Ben Greear wrote: > > > > > > > > > > > > On 05/18/2020 09:51 AM,

Re: [PATCH] wireless: remove unneeded semicolon

> > len -= ie_len; > data += ie_len; > - }; > + } > > ret = 0; > out: For ath6kl Acked-by: Steve deRosier ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [RFC] ethtool: Support ETHTOOL_GSTATS2 command.

On Tue, Mar 20, 2018 at 8:39 AM, Ben Greear wrote: > On 03/20/2018 03:37 AM, Michal Kubecek wrote: >> >> On Wed, Mar 07, 2018 at 11:51:29AM -0800, gree...@candelatech.com wrote: >>> >>> From: Ben Greear >>> >>> This is similar to ETHTOOL_GSTATS,

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

/net/wireless/ath/ath10k/gpio.c Assuming that kbuild robot doesn't kick back another build-time warning, it looks OK to me. Reviewed-by: Steve deRosier <deros...@cal-sierra.com> -- Steve deRosier Cal-Sierra Consulting LLC https://www.cal-sierra.com/ ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH v9] ath10k: add LED and GPIO controlling support for various chipsets

Hi Sebastian, On Thu, Feb 22, 2018 at 6:09 PM, Sebastian Gottschall <s.gottsch...@dd-wrt.com> wrote: > Am 22.02.2018 um 23:17 schrieb Steve deRosier: >> >> On Thu, Feb 22, 2018 at 3:15 AM, <s.gottsch...@dd-wrt.com> wrote: >>> >>> From: Sebas

Re: [PATCH v9] ath10k: add LED and GPIO controlling support for various chipsets

like `ath10k_core-$(CONFIG_GPIO) += gpoi.o`. Maybe I'm mistaken. (Note, I didn't look up the actual config option name, I'm guessing. Assume I wrote something reasonable for my example.) I only ask the above two questions, not because I think it's wrong, but beca

Re: [PATCH v7] ath10k: add LED and GPIO controlling support for various chipsets

On Tue, Feb 20, 2018 at 10:06 AM, Sebastian Gottschall <s.gottsch...@dd-wrt.com> wrote: > Am 20.02.2018 um 17:52 schrieb Steve deRosier: >> >> >>> +static int ath10k_register_gpio_chip(struct ath10k *ar) >>> +{ >>> + struct ath10k_gpiocontrol

Re: [PATCH v7] ath10k: add LED and GPIO controlling support for various chipsets

-8364,6 +8406,8 @@ static const struct wmi_ops wmi_10_2_4_ops = { > .gen_pdev_enable_adaptive_cca = > ath10k_wmi_op_gen_pdev_enable_adaptive_cca, > .get_vdev_subtype = ath10k_wmi_10_2_4_op_get_vdev_subtype, > + .gen_gpio_config = ath10k_wmi_op_gen_gpio_c

Re: [PATCH] v2 ath10k: add LED and GPIO controlling support for various chipsets

On Fri, Feb 16, 2018 at 2:30 AM, wrote: > From: Sebastian Gottschall > > Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 and > ipq4019 based chipsets with on chipset connected led's > using WMI Firmware API. > The LED

Re: [RFC v4 00/18] ath10k high latency

Hi Erik, On Sun, Dec 31, 2017 at 9:29 AM, Erik Stromdahl wrote: > Uplink test results (WUSB6100M -> other computer): > > # iperf-client.sh 192.168.1.244 > /usr/bin/iperf > > Client connecting to 192.168.1.244,

Re: [PATCH 02/11] ath10k_sdio: wb396 reference card fix

Hi Alagu, On Sat, Sep 30, 2017 at 10:37 AM, wrote: > > From: Alagu Sankar > > The QCA9377-3 WB396 sdio reference card does not get initialized > due to the conflict in uart gpio pins. This fix is not required > for other QCA9377 sdio cards. >

Re: [v2,1/3] ath9k: Support channels in licensed bands

Hi Ben, On Fri, May 12, 2017 at 7:12 AM, Ben Greear wrote: > > > On 05/11/2017 04:38 AM, Kalle Valo wrote: >> >> Simon Wunderlich writes: >> >>> it seems like there was some discussion here and I wouldn't expect too >>> many >>> more opinions

Re: [PATCH] ath10k: add configurable debugging.

Hi Adrian, On Wed, May 10, 2017 at 9:25 AM, Adrian Chadd wrote: > diff --git a/drivers/net/wireless/ath/ath10k/debug.h > b/drivers/net/wireless/ath/ath10k/debug.h > index 257d10985c6e..7bd461927029 100644 > --- a/drivers/net/wireless/ath/ath10k/debug.h > +++

Re: [v2,1/3] ath9k: Support channels in licensed bands

Hi, (sorry, resending due to my not noticing that gmail had changed my default compose mode to HTML. Why does it randomly do that sometimes?!?!) On Tue, Apr 18, 2017 at 7:50 AM, Simon Wunderlich wrote: > > Hi, > > On Tuesday, April 18, 2017 2:36:54 PM CEST Kalle Valo