Re: [PATCH wireless v2] wifi: ath10k: Fix an error code problem in ath10k_dbg_sta_write_peer_debug_trigger()

2024-04-22 Thread Su Hui
On 2024/4/22 14:53, Kalle Valo wrote: Su Hui writes: Clang Static Checker (scan-build) Warning: drivers/net/wireless/ath/ath10k/debugfs_sta.c:line 429, column 3 Value stored to 'ret' is never read. Return 'ret' rather than 'count' when 'ret' stores an error code. By the way, remove some

[PATCH wireless v2] wifi: ath10k: Fix an error code problem in ath10k_dbg_sta_write_peer_debug_trigger()

2024-04-21 Thread Su Hui
bugfs support to get per peer tids log via tracing") Signed-off-by: Su Hui --- v2: - remove the initializer change. drivers/net/wireless/ath/ath10k/debugfs_sta.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/debugfs_sta.c b/drivers/ne

Re: [PATCH wireless] wifi: ath10k: Fix an error code problem in ath10k_dbg_sta_write_peer_debug_trigger()

2024-04-21 Thread Su Hui
On 2024/4/19 23:09, Jeff Johnson wrote: On 4/17/2024 1:17 AM, Su Hui wrote: u8 peer_debug_trigger; - int ret; + int ret = 0; this is unnecessary since this will be written in all paths that lead to the return that reads it Yes, this is my fault. I will remove this in v2

[PATCH wireless] wifi: ath10k: Fix an error code problem in ath10k_dbg_sta_write_peer_debug_trigger()

2024-04-17 Thread Su Hui
bugfs support to get per peer tids log via tracing") Signed-off-by: Su Hui --- drivers/net/wireless/ath/ath10k/debugfs_sta.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/debugfs_sta.c b/drivers/net/wireless/ath/ath10k/debugfs_s