Re: [PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size

2021-03-07 Thread Wen Gong
On 2021-02-11 00:53, Steven Rostedt wrote: On Wed, 10 Feb 2021 11:48:23 -0500 Steven Rostedt wrote: On Wed, 10 Feb 2021 11:30:26 -0500 Steven Rostedt wrote: > Can you test this patch? v2: Bah! v3: diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index b79bcacdd6f9..90d7ade03499

Re: [PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size

2021-02-10 Thread Steven Rostedt
On Wed, 10 Feb 2021 11:48:23 -0500 Steven Rostedt wrote: > On Wed, 10 Feb 2021 11:30:26 -0500 > Steven Rostedt wrote: > > > Can you test this patch? > > v2: Bah! v3: diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index b79bcacdd6f9..90d7ade03499 100644 ---

Re: [PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size

2021-02-10 Thread Steven Rostedt
On Wed, 10 Feb 2021 11:30:26 -0500 Steven Rostedt wrote: > Can you test this patch? v2: diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index b79bcacdd6f9..c5c3d826d420 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -2739,7 +2739,7 @@

Re: [PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size

2021-02-10 Thread Steven Rostedt
On Wed, 10 Feb 2021 10:01:57 +0800 Wen Gong wrote: > Not tested with latest kernel. > The reason is below which I said in > https://lore.kernel.org/lkml/b504b3d7e989cae108669a0cd3072...@codeaurora.org/ > > the per cpu buffer seems it is initilized in > trace_buffered_event_enable, > it is

Re: [PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size

2021-02-09 Thread Wen Gong
On 2021-02-10 10:14, Brian Norris wrote: On Tue, Feb 9, 2021 at 6:12 PM Wen Gong wrote: On 2021-02-10 03:35, Brian Norris wrote: so this patch is to dump the top 1024 bytes only, its 1st goal is make log smaller. Agreed. I wasn't objecting to this patch. I just wanted to highlight the second

Re: [PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size

2021-02-09 Thread Brian Norris
On Tue, Feb 9, 2021 at 6:12 PM Wen Gong wrote: > On 2021-02-10 03:35, Brian Norris wrote: > so this patch is to dump the top 1024 bytes only, > its 1st goal is make log smaller. Agreed. I wasn't objecting to this patch. I just wanted to highlight the second part should probably also be

Re: [PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size

2021-02-09 Thread Wen Gong
On 2021-02-10 03:35, Brian Norris wrote: + Steven Rostedt Hi Wen, (Trimming down the description a bit:) On Mon, Feb 8, 2021 at 6:59 PM Wen Gong wrote: Kernel panic every time in kernel when running below case: steps: 1. connect to an AP with good signal strength 2. echo 0x7f >

Re: [PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size

2021-02-09 Thread Wen Gong
On 2021-02-10 05:34, Steven Rostedt wrote: On Tue, 9 Feb 2021 14:55:31 -0500 Steven Rostedt wrote: > [for-next][PATCH 2/2] tracing: Use temp buffer when filtering events > https://lore.kernel.org/lkml/f16b14066317f6a926b6636df6974...@codeaurora.org/ Note, that is only used when filtering

Re: [PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size

2021-02-09 Thread Steven Rostedt
On Tue, 9 Feb 2021 14:55:31 -0500 Steven Rostedt wrote: > > [for-next][PATCH 2/2] tracing: Use temp buffer when filtering events > > https://lore.kernel.org/lkml/f16b14066317f6a926b6636df6974...@codeaurora.org/ > > > > Note, that is only used when filtering happens, which doesn't appear to

Re: [PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size

2021-02-09 Thread Steven Rostedt
On Tue, 9 Feb 2021 11:35:07 -0800 Brian Norris wrote: > + Steven Rostedt Thanks. > > Hi Wen, > > (Trimming down the description a bit:) > > On Mon, Feb 8, 2021 at 6:59 PM Wen Gong wrote: > > > > Kernel panic every time in kernel when running below case: > > steps: > > 1. connect to an AP

Re: [PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size

2021-02-09 Thread Brian Norris
+ Steven Rostedt Hi Wen, (Trimming down the description a bit:) On Mon, Feb 8, 2021 at 6:59 PM Wen Gong wrote: > > Kernel panic every time in kernel when running below case: > steps: > 1. connect to an AP with good signal strength > 2. echo 0x7f >

Re: [PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size

2021-02-08 Thread Kalle Valo
Wen Gong wrote: > Kernel panic every time in kernel when running below case: > steps: > 1. connect to an AP with good signal strength > 2. echo 0x7f > /sys/kernel/debug/ieee80211/phy0/ath10k/pktlog_filter > 3. echo 0x 0 > /sys/kernel/debug/ieee80211/phy0/ath10k/fw_dbglog > 4. echo 0 >

[PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size

2021-02-08 Thread Wen Gong
Kernel panic every time in kernel when running below case: steps: 1. connect to an AP with good signal strength 2. echo 0x7f > /sys/kernel/debug/ieee80211/phy0/ath10k/pktlog_filter 3. echo 0x 0 > /sys/kernel/debug/ieee80211/phy0/ath10k/fw_dbglog 4. echo 0 >