Re: [PATCH] ath10k: skip ath10k_halt during suspend for driver state RESTARTING

Addressed all the above comments and pushed out a v2 patch. Fixes in V2: - Fixed typo, replaced ath11k by ath10k in comments. - Adjusted the position of the S-O-B tag. - Added tested on tag. Thanks Abhishek On Tue, Apr 26, 2022 at 9:23 AM Jeff Johnson wrote: > > (sorry for the 2nd message with

Re: [PATCH] ath10k: skip ath10k_halt during suspend for driver state RESTARTING

(sorry for the 2nd message with no content -- operator error) ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH] ath10k: skip ath10k_halt during suspend for driver state RESTARTING

On 4/24/2022 7:15 PM, Abhishek Kumar wrote: [...snip...] Signed-off-by: Abhishek Kumar Your S-O-B should be last? Co-developed-by: Wen Gong Signed-off-by: Wen Gong ___ ath10k mailing list ath10k@lists.infradead.org

Re: [PATCH] ath10k: skip ath10k_halt during suspend for driver state RESTARTING

On 4/24/2022 7:15 PM, Abhishek Kumar wrote: Double free crash is observed when FW recovery(caused by wmi timeout/crash) is followed by immediate suspend event. The FW recovery is triggered by ath10k_core_restart() which calls driver clean up via ath10k_halt(). When the suspend event occurs

Re: [PATCH] ath10k: skip ath10k_halt during suspend for driver state RESTARTING

On Mon, Apr 25, 2022 at 4:13 PM Brian Norris wrote: > > On Mon, Apr 25, 2022 at 04:11:44PM -0700, Brian Norris wrote: > > On Mon, Apr 25, 2022 at 02:15:20AM +, Abhishek Kumar wrote: > > > --- a/drivers/net/wireless/ath/ath10k/mac.c > > > +++ b/drivers/net/wireless/ath/ath10k/mac.c > > > @@

Re: [PATCH] ath10k: skip ath10k_halt during suspend for driver state RESTARTING

On Mon, Apr 25, 2022 at 02:15:20AM +, Abhishek Kumar wrote: > --- a/drivers/net/wireless/ath/ath10k/mac.c > +++ b/drivers/net/wireless/ath/ath10k/mac.c > @@ -5345,8 +5345,22 @@ static void ath10k_stop(struct ieee80211_hw *hw) > > mutex_lock(>conf_mutex); > if (ar->state !=

Re: [PATCH] ath10k: skip ath10k_halt during suspend for driver state RESTARTING

On Mon, Apr 25, 2022 at 04:11:44PM -0700, Brian Norris wrote: > On Mon, Apr 25, 2022 at 02:15:20AM +, Abhishek Kumar wrote: > > --- a/drivers/net/wireless/ath/ath10k/mac.c > > +++ b/drivers/net/wireless/ath/ath10k/mac.c > > @@ -5345,8 +5345,22 @@ static void ath10k_stop(struct ieee80211_hw

Re: [PATCH] ath10k: skip ath10k_halt during suspend for driver state RESTARTING

Thanks Kalle for having a look and adding this on behalf of me. Here is the Tested-on tag, Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00288-QCARMSWPZ-1 Thanks Abhishek On Sun, Apr 24, 2022 at 11:14 PM Kalle Valo wrote: > > Abhishek Kumar writes: > > > Double free crash is observed when FW

Re: [PATCH] ath10k: skip ath10k_halt during suspend for driver state RESTARTING

Abhishek Kumar writes: > Double free crash is observed when FW recovery(caused by wmi > timeout/crash) is followed by immediate suspend event. The FW recovery > is triggered by ath10k_core_restart() which calls driver clean up via > ath10k_halt(). When the suspend event occurs between the FW

[PATCH] ath10k: skip ath10k_halt during suspend for driver state RESTARTING

Double free crash is observed when FW recovery(caused by wmi timeout/crash) is followed by immediate suspend event. The FW recovery is triggered by ath10k_core_restart() which calls driver clean up via ath10k_halt(). When the suspend event occurs between the FW recovery, the restart worker thread