Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-04 Thread akolli
On 2017-12-04 19:53, Maxime Bizon wrote: On Mon, 2017-12-04 at 18:54 +0530, ako...@codeaurora.org wrote: Hope 10.2.4-1.0-00029 Firmware binary works for you. it does I will check this warning. fixed by applying patch: "[PATCH] ath10k: fix recent bandwidth conversion bug" as suggested

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-04 Thread Maxime Bizon
On Mon, 2017-12-04 at 18:54 +0530, ako...@codeaurora.org wrote: > Hope 10.2.4-1.0-00029 Firmware binary works for you. it does > I will check this warning. fixed by applying patch: "[PATCH] ath10k: fix recent bandwidth conversion bug" as suggested by Christian Lamparter only remaining

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-04 Thread akolli
On 2017-12-01 20:35, Maxime Bizon wrote: On Fri, 2017-12-01 at 19:18 +0530, ako...@codeaurora.org wrote: Hope CONFIG_MAC80211_DEBUGFS is enabled in your build. it wasn't and IMHO it's confusing because tx rate is filled by the other drivers without it. I now have the following warning: [

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-04 Thread akolli
Parse peer stats from pktlog packets and update the tx rate information per STA. This way user space can query about transmit rate with iw: everything works ok, ath10k_update_per_peer_tx_stats() is called and ath10k_sta fields are updated correctly but tx bitrate is still 6 MBit/s in

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-02 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > On Fri, 2017-12-01 at 16:54 +0100, Toke Høiland-Jørgensen wrote: > >> But since we'll have to do that for ath9k anyway it >> becomes more a question of whether it's something that should be >> supported in mac80211 or if it should be implemented

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread Maxime Bizon
On Fri, 2017-12-01 at 16:53 +0100, Christian Lamparter wrote: > "[PATCH] ath10k: fix recent bandwidth conversion bug" indeed, much better thanks -- Maxime ___ ath10k mailing list ath10k@lists.infradead.org

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread Johannes Berg
On Fri, 2017-12-01 at 16:54 +0100, Toke Høiland-Jørgensen wrote: > I guess that once we have an asynchronous scheduler task of some kind, > supporting the callback is easy, but pulling the data out of each packet > needs more work. Right. > But since we'll have to do that for ath9k anyway it >

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > On Fri, 2017-12-01 at 16:29 +0100, Toke Høiland-Jørgensen wrote: >> >> Yeah, figures. Well, maybe we'll just have to support an asynchronous >> callback into mac80211 to register airtime usage. Will probably have to >> add some asynchronicity

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread Christian Lamparter
On Friday, December 1, 2017 4:05:10 PM CET Maxime Bizon wrote: > > On Fri, 2017-12-01 at 19:18 +0530, ako...@codeaurora.org wrote: > > > Hope CONFIG_MAC80211_DEBUGFS is enabled in your build. > > it wasn't and IMHO it's confusing because tx rate is filled by the other > drivers without it. > >

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread Johannes Berg
On Fri, 2017-12-01 at 16:29 +0100, Toke Høiland-Jørgensen wrote: > > Yeah, figures. Well, maybe we'll just have to support an asynchronous > callback into mac80211 to register airtime usage. Will probably have to > add some asynchronicity anyway to avoid doing too much work in the fast > path. I

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread Kalle Valo
ako...@codeaurora.org writes: >>> Parse peer stats from pktlog packets and update the tx rate >>> information >>> per STA. This way user space can query about transmit rate with iw: >> >> everything works ok, ath10k_update_per_peer_tx_stats() is called and >> ath10k_sta fields are updated

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread Toke Høiland-Jørgensen
Kalle Valo writes: >>> tx_duration is aggregate time duration of 4 PPDU sent to STA. >>> FW sends these values for retry packets also. >> >> Great, that sounds like just what we need. > > Except mapping to the iee80211_tx_status() might be difficult. I'm not > sure how

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread Maxime Bizon
On Fri, 2017-12-01 at 19:18 +0530, ako...@codeaurora.org wrote: > Hope CONFIG_MAC80211_DEBUGFS is enabled in your build. it wasn't and IMHO it's confusing because tx rate is filled by the other drivers without it. I now have the following warning: [ 96.174967] [ cut here

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread Kalle Valo
Toke Høiland-Jørgensen writes: > ako...@codeaurora.org writes: > >> On 2017-11-30 22:08, Kalle Valo wrote: >>> Toke Høiland-Jørgensen writes: >>> >> +struct ath10k_10_2_peer_tx_stats { >> +u8 ratecode[PEER_STATS_FOR_NO_OF_PPDUS]; >> +u8

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread akolli
Hello, Thanks for verifying the patch. On 2017-12-01 16:15, Maxime Bizon wrote: On Thu, 2017-11-30 at 18:28 +0530, ako...@qti.qualcomm.com wrote: Hello, Tested on QCA9880 with firmware version 10.2.4.70.48. This should also work with firmware branch 10.2.4-1.0-00029 I tried using your

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread Toke Høiland-Jørgensen
ako...@codeaurora.org writes: > On 2017-11-30 22:08, Kalle Valo wrote: >> Toke Høiland-Jørgensen writes: >> > +struct ath10k_10_2_peer_tx_stats { > + u8 ratecode[PEER_STATS_FOR_NO_OF_PPDUS]; > + u8 success_pkts[PEER_STATS_FOR_NO_OF_PPDUS]; > + __le16

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread Maxime Bizon
On Thu, 2017-11-30 at 18:28 +0530, ako...@qti.qualcomm.com wrote: Hello, > Tested on QCA9880 with firmware version 10.2.4.70.48. This should also > work with firmware branch 10.2.4-1.0-00029 I tried using your patch on 4.14 with firmware 10.2.4-1.0-00029 > Parse peer stats from pktlog packets

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-11-30 Thread akolli
On 2017-11-30 22:08, Kalle Valo wrote: Toke Høiland-Jørgensen writes: +struct ath10k_10_2_peer_tx_stats { + u8 ratecode[PEER_STATS_FOR_NO_OF_PPDUS]; + u8 success_pkts[PEER_STATS_FOR_NO_OF_PPDUS]; + __le16 success_bytes[PEER_STATS_FOR_NO_OF_PPDUS]; + u8

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-11-30 Thread Kalle Valo
Toke Høiland-Jørgensen writes: >>> +struct ath10k_10_2_peer_tx_stats { >>> + u8 ratecode[PEER_STATS_FOR_NO_OF_PPDUS]; >>> + u8 success_pkts[PEER_STATS_FOR_NO_OF_PPDUS]; >>> + __le16 success_bytes[PEER_STATS_FOR_NO_OF_PPDUS]; >>> + u8 retry_pkts[PEER_STATS_FOR_NO_OF_PPDUS];

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-11-30 Thread Toke Høiland-Jørgensen
>> +struct ath10k_10_2_peer_tx_stats { >> +u8 ratecode[PEER_STATS_FOR_NO_OF_PPDUS]; >> +u8 success_pkts[PEER_STATS_FOR_NO_OF_PPDUS]; >> +__le16 success_bytes[PEER_STATS_FOR_NO_OF_PPDUS]; >> +u8 retry_pkts[PEER_STATS_FOR_NO_OF_PPDUS]; >> +__le16

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-11-30 Thread Kalle Valo
writes: > From: Anilkumar Kolli > > 10.2.4 firmware branch (used in QCA988X) does not support > HTT_10_4_T2H_MSG_TYPE_PEER_STATS and that's why ath10k does not provide > tranmission rate statistics to user space, instead it just shows >