Re: [PATCH V3 4/4] mac80211: Sync airtime weight sum with per AC synced sta airtime weight together

2019-09-24 Thread Toke Høiland-Jørgensen
Yibo Zhao writes: > On 2019-09-23 19:00, Toke Høiland-Jørgensen wrote: > >>> - if (params->airtime_weight) >>> - sta->airtime_weight = params->airtime_weight; >>> + if (params->airtime_weight && >>> + params->airtime_weight != sta->airtime_weight) { >> >> This check doesn't

Re: [PATCH V3 4/4] mac80211: Sync airtime weight sum with per AC synced sta airtime weight together

2019-09-23 Thread Yibo Zhao
On 2019-09-23 19:00, Toke Høiland-Jørgensen wrote: - if (params->airtime_weight) - sta->airtime_weight = params->airtime_weight; + if (params->airtime_weight && + params->airtime_weight != sta->airtime_weight) { This check doesn't work I think? You're not

Re: [PATCH V3 4/4] mac80211: Sync airtime weight sum with per AC synced sta airtime weight together

2019-09-23 Thread Toke Høiland-Jørgensen
Yibo Zhao writes: > Global airtime weight sum is updated only when txq is added/removed > from rbtree. If upper layer configures sta weight during high load, > airtime weight sum will not be updated since txq is most likely on the > tree. It could a little late for upper layer to reconfigure sta

[PATCH V3 4/4] mac80211: Sync airtime weight sum with per AC synced sta airtime weight together

2019-09-23 Thread Yibo Zhao
Global airtime weight sum is updated only when txq is added/removed from rbtree. If upper layer configures sta weight during high load, airtime weight sum will not be updated since txq is most likely on the tree. It could a little late for upper layer to reconfigure sta weight when txq is already