Re: [PATCH net-next] ath10k: fix RX of frames with broken FCS in monitor mode

2019-11-07 Thread Ben Greear
On 11/07/2019 06:03 AM, Linus Lüssing wrote: On Tue, Nov 05, 2019 at 09:19:20AM -0800, Ben Greear wrote: Thanks for adding the counter. Since it us u32, I doubt you need the spin lock below? Ok, I can remove the spin-lock. Just for clarification though, if I recall correctly then an

Re: [PATCH net-next] ath10k: fix RX of frames with broken FCS in monitor mode

2019-11-07 Thread Linus Lüssing
On Tue, Nov 05, 2019 at 09:19:20AM -0800, Ben Greear wrote: > Thanks for adding the counter. Since it us u32, I doubt you need the spin > lock > below? Ok, I can remove the spin-lock. Just for clarification though, if I recall correctly then an increment operator is not guaranteed to work

Re: [PATCH net-next] ath10k: fix RX of frames with broken FCS in monitor mode

2019-11-05 Thread Ben Greear
On 11/5/19 8:49 AM, Linus Lüssing wrote: From: Linus Lüssing So far, frames were forwarded regardless of the FCS correctness leading to userspace applications listening on the monitor mode interface to receive potentially broken frames, even with the "fcsfail" flag unset. By default, with the

[PATCH net-next] ath10k: fix RX of frames with broken FCS in monitor mode

2019-11-05 Thread Linus Lüssing
From: Linus Lüssing So far, frames were forwarded regardless of the FCS correctness leading to userspace applications listening on the monitor mode interface to receive potentially broken frames, even with the "fcsfail" flag unset. By default, with the "fcsfail" flag of a monitor mode interface