Re: [PATCH v2] ath10k: Correct error handling of dma_map_single()

2019-10-14 Thread Kalle Valo
Bjorn Andersson wrote: > The return value of dma_map_single() should be checked for errors using > dma_mapping_error() and the skb has been dequeued so it needs to be > freed. > > This was found when enabling CONFIG_DMA_API_DEBUG and it warned about the > missing dma_mapping_error() call. > >

Re: [PATCH v2] ath10k: Correct error handling of dma_map_single()

2019-10-14 Thread Kalle Valo
Bjorn Andersson wrote: > The return value of dma_map_single() should be checked for errors using > dma_mapping_error() and the skb has been dequeued so it needs to be > freed. > > This was found when enabling CONFIG_DMA_API_DEBUG and it warned about the > missing dma_mapping_error() call. > >

[PATCH v2] ath10k: Correct error handling of dma_map_single()

2019-10-11 Thread Bjorn Andersson
The return value of dma_map_single() should be checked for errors using dma_mapping_error() and the skb has been dequeued so it needs to be freed. Fixes: 1807da49733e ("ath10k: wmi: add management tx by reference support over wmi") Reported-by: Niklas Cassel Signed-off-by: Bjorn Andersson ---