Re: [PATCH v2] ath10k: skip ath10k_halt during suspend for driver state RESTARTING

2022-04-29 Thread Kalle Valo
Abhishek Kumar wrote: > Double free crash is observed when FW recovery(caused by wmi > timeout/crash) is followed by immediate suspend event. The FW recovery > is triggered by ath10k_core_restart() which calls driver clean up via > ath10k_halt(). When the suspend event occurs between the FW

Re: [PATCH v2] ath10k: skip ath10k_halt during suspend for driver state RESTARTING

2022-04-27 Thread Brian Norris
On Tue, Apr 26, 2022 at 10:20 PM Abhishek Kumar wrote: > On Tue, Apr 26, 2022 at 3:34 PM Brian Norris wrote: > > You could have retained my: > > > > Reviewed-by: Brian Norris > > > > but no worries; it's just a few characters ;) > Oh! sorry about that, I was under the impression that if the

Re: [PATCH v2] ath10k: skip ath10k_halt during suspend for driver state RESTARTING

2022-04-27 Thread Kalle Valo
Abhishek Kumar writes: > Double free crash is observed when FW recovery(caused by wmi > timeout/crash) is followed by immediate suspend event. The FW recovery > is triggered by ath10k_core_restart() which calls driver clean up via > ath10k_halt(). When the suspend event occurs between the FW

Re: [PATCH v2] ath10k: skip ath10k_halt during suspend for driver state RESTARTING

2022-04-26 Thread Abhishek Kumar
On Tue, Apr 26, 2022 at 3:34 PM Brian Norris wrote: > > On Tue, Apr 26, 2022 at 3:20 PM Abhishek Kumar wrote: > > > > Double free crash is observed when FW recovery(caused by wmi > > timeout/crash) is followed by immediate suspend event. The FW recovery > > is triggered by ath10k_core_restart()

Re: [PATCH v2] ath10k: skip ath10k_halt during suspend for driver state RESTARTING

2022-04-26 Thread Brian Norris
On Tue, Apr 26, 2022 at 3:20 PM Abhishek Kumar wrote: > > Double free crash is observed when FW recovery(caused by wmi > timeout/crash) is followed by immediate suspend event. The FW recovery > is triggered by ath10k_core_restart() which calls driver clean up via > ath10k_halt(). When the suspend

[PATCH v2] ath10k: skip ath10k_halt during suspend for driver state RESTARTING

2022-04-26 Thread Abhishek Kumar
Double free crash is observed when FW recovery(caused by wmi timeout/crash) is followed by immediate suspend event. The FW recovery is triggered by ath10k_core_restart() which calls driver clean up via ath10k_halt(). When the suspend event occurs between the FW recovery, the restart worker thread