Re: [RFC - is this a bug?] wifi: ath10k: Asking for some light on this, please :)

2023-12-12 Thread Jeff Johnson
On 10/25/2023 8:52 AM, Jeff Johnson wrote: > On 10/24/2023 7:37 PM, Gustavo A. R. Silva wrote: >> >> >> On 10/24/23 14:49, Johannes Berg wrote: >>> On Tue, 2023-10-24 at 14:41 -0600, Gustavo A. R. Silva wrote: It seems we run into the same issue in the function below, even in the

Re: [RFC - is this a bug?] wifi: ath10k: Asking for some light on this, please :)

2023-10-25 Thread Jeff Johnson
On 10/24/2023 7:37 PM, Gustavo A. R. Silva wrote: On 10/24/23 14:49, Johannes Berg wrote: On Tue, 2023-10-24 at 14:41 -0600, Gustavo A. R. Silva wrote: It seems we run into the same issue in the function below, even in the case this `memset()` is unnecessary (which it seems it's not):

Re: [RFC - is this a bug?] wifi: ath10k: Asking for some light on this, please :)

2023-10-24 Thread Gustavo A. R. Silva
On 10/24/23 14:49, Johannes Berg wrote: On Tue, 2023-10-24 at 14:41 -0600, Gustavo A. R. Silva wrote: It seems we run into the same issue in the function below, even in the case this `memset()` is unnecessary (which it seems it's not): 8920 memset(skb->data, 0,

Re: [RFC - is this a bug?] wifi: ath10k: Asking for some light on this, please :)

2023-10-24 Thread Gustavo A. R. Silva
[+CC Manikanta Pubbisetty ] As Johannes[1] pointed out, this `memset()` is probably unnecessary: ./drivers/net/wireless/ath/ath10k/wmi.c: 8920 memset(skb->data, 0, sizeof(*cmd)); However, the same exact issue[2] is present at the line below inside function `ath10k_wmi_alloc_skb()`:

Re: [RFC - is this a bug?] wifi: ath10k: Asking for some light on this, please :)

2023-10-24 Thread Johannes Berg
On Tue, 2023-10-24 at 14:41 -0600, Gustavo A. R. Silva wrote: > > It seems we run into the same issue in the function below, even in the > case this `memset()` is unnecessary (which it seems it's not): > > 8920 memset(skb->data, 0, sizeof(*cmd)); > > Notice that if

Re: [RFC - is this a bug?] wifi: ath10k: Asking for some light on this, please :)

2023-10-24 Thread Gustavo A. R. Silva
On 10/24/23 14:11, Johannes Berg wrote: On Tue, 2023-10-24 at 13:50 -0600, Gustavo A. R. Silva wrote: Hi all, While working on tranforming one-element array `peer_chan_list` in `struct wmi_tdls_peer_capabilities` into a flex-array member 7187 struct wmi_tdls_peer_capabilities { ... 7199

Re: [RFC - is this a bug?] wifi: ath10k: Asking for some light on this, please :)

2023-10-24 Thread Johannes Berg
On Tue, 2023-10-24 at 13:50 -0600, Gustavo A. R. Silva wrote: > Hi all, > > While working on tranforming one-element array `peer_chan_list` in > `struct wmi_tdls_peer_capabilities` into a flex-array member > > 7187 struct wmi_tdls_peer_capabilities { > ... > 7199 struct wmi_channel

[RFC - is this a bug?] wifi: ath10k: Asking for some light on this, please :)

2023-10-24 Thread Gustavo A. R. Silva
Hi all, While working on tranforming one-element array `peer_chan_list` in `struct wmi_tdls_peer_capabilities` into a flex-array member 7187 struct wmi_tdls_peer_capabilities { ... 7199 struct wmi_channel peer_chan_list[1]; 7200 } __packed; the following line caught my attention: