Re: [v3] ath10k: rebuild crypto header in rx data frames

2017-12-02 Thread Sebastian Gottschall
you need a recent ath10k version. use the backports project to compile a recent ath10k/mac80211 for 3.17 or take a look into lede, it has a complete recent backports tree which can be used on 3.17 with small modifications Am 02.12.2017 um 22:41 schrieb Ben Greear: On 12/02/2017 06:34 AM,

Re: [v3] ath10k: rebuild crypto header in rx data frames

2017-12-02 Thread Ben Greear
On 12/02/2017 06:34 AM, Kalle Valo wrote: Ben Greear writes: Is this patch destined for stable? I was expecting to see it show up in the older stable releases, but it has not so far as far as I can tell. We are working on it, but not sure yet to which releases,

Re: [v3] ath10k: rebuild crypto header in rx data frames

2017-12-02 Thread Kalle Valo
Ben Greear writes: > Is this patch destined for stable? > > I was expecting to see it show up in the older stable releases, > but it has not so far as far as I can tell. We are working on it, but not sure yet to which releases, it doesn't directly apply to all active

Re: [v3] ath10k: rebuild crypto header in rx data frames

2017-11-21 Thread Ben Greear
Is this patch destined for stable? I was expecting to see it show up in the older stable releases, but it has not so far as far as I can tell. Thanks, Ben On 10/30/2017 02:32 AM, Sebastian Gottschall wrote: will check it tomorrow including gcmp-256, ccmp-256. was out for weekend :-) Am

Re: [v3] ath10k: rebuild crypto header in rx data frames

2017-10-31 Thread Sebastian Gottschall
Am 31.10.2017 um 16:00 schrieb Kalle Valo: Sebastian Gottschall writes: the following patchlines in the v3 patch look wrong +   /* ICV */ +   if (status->flag & RX_FLAG_ICV_STRIPPED && +   enctype !=

Re: [v3] ath10k: rebuild crypto header in rx data frames

2017-10-31 Thread Kalle Valo
Sebastian Gottschall writes: > the following patchlines in the v3 patch look wrong > > +   /* ICV */ > +   if (status->flag & RX_FLAG_ICV_STRIPPED && > +   enctype != HTT_RX_MPDU_ENCRYPT_AES_CCM_WPA2) > +  

Re: [v3] ath10k: rebuild crypto header in rx data frames

2017-10-31 Thread Vasanthakumar Thiagarajan
akumar Thiagarajan Subject: Re: [v3] ath10k: rebuild crypto header in rx data frames the same is for the MIC + /* MIC */ + if ((status->flag & RX_FLAG_MIC_STRIPPED) && + enctype == HTT_RX_MPDU_ENCRYPT_AES_CCM_WPA2) + skb

Re: [v3] ath10k: rebuild crypto header in rx data frames

2017-10-31 Thread Sebastian Gottschall
the same is for the MIC +   /* MIC */ +   if ((status->flag & RX_FLAG_MIC_STRIPPED) && +   enctype == HTT_RX_MPDU_ENCRYPT_AES_CCM_WPA2) +   skb_trim(msdu, msdu->len - 8); this code looks wrong too Am 30.10.2017 um 10:32 schrieb

Re: [v3] ath10k: rebuild crypto header in rx data frames

2017-10-31 Thread Sebastian Gottschall
the following patchlines in the v3 patch look wrong +   /* ICV */ +   if (status->flag & RX_FLAG_ICV_STRIPPED && +   enctype != HTT_RX_MPDU_ENCRYPT_AES_CCM_WPA2) +   skb_trim(msdu, msdu->len - +   

Re: [v3] ath10k: rebuild crypto header in rx data frames

2017-10-30 Thread Sebastian Gottschall
will check it tomorrow including gcmp-256, ccmp-256. was out for weekend :-) Am 30.10.2017 um 09:39 schrieb Kalle Valo: Kalle Valo wrote: Rx data frames notified through HTT_T2H_MSG_TYPE_RX_IND and HTT_T2H_MSG_TYPE_RX_FRAG_IND expect PN/TSC check to be done on host

Re: [v3] ath10k: rebuild crypto header in rx data frames

2017-10-30 Thread Kalle Valo
Kalle Valo wrote: > Rx data frames notified through HTT_T2H_MSG_TYPE_RX_IND and > HTT_T2H_MSG_TYPE_RX_FRAG_IND expect PN/TSC check to be done > on host (mac80211) rather than firmware. Rebuild cipher header > in every received data frames (that are notified through those

Re: [v3] ath10k: rebuild crypto header in rx data frames

2017-10-27 Thread Kalle Valo
Kalle Valo wrote: > Rx data frames notified through HTT_T2H_MSG_TYPE_RX_IND and > HTT_T2H_MSG_TYPE_RX_FRAG_IND expect PN/TSC check to be done > on host (mac80211) rather than firmware. Rebuild cipher header > in every received data frames (that are notified through those

[PATCH v3] ath10k: rebuild crypto header in rx data frames

2017-10-26 Thread Kalle Valo
From: Vasanthakumar Thiagarajan Rx data frames notified through HTT_T2H_MSG_TYPE_RX_IND and HTT_T2H_MSG_TYPE_RX_FRAG_IND expect PN/TSC check to be done on host (mac80211) rather than firmware. Rebuild cipher header in every received data frames (that are notified