Re: [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot

2020-09-07 Thread Kalle Valo
Govind Singh writes: > On 2020-08-28 18:22, Kalle Valo wrote: >> Amit Pundir writes: >> >>> On Mon, 8 Jun 2020 at 17:07, Kalle Valo wrote: > I don't agree with this. If you read through the replies to the bug > report, > it is clear that NS migration uncovered a corner case or

Re: [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot

2020-08-28 Thread Govind Singh
Hi Kalle, On 2020-08-28 18:22, Kalle Valo wrote: Amit Pundir writes: On Mon, 8 Jun 2020 at 17:07, Kalle Valo wrote: > I don't agree with this. If you read through the replies to the bug report, > it is clear that NS migration uncovered a corner case or even a bug. So we > should try to fix

Re: [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot

2020-08-28 Thread Kalle Valo
Amit Pundir writes: > On Mon, 8 Jun 2020 at 17:07, Kalle Valo wrote: >> > I don't agree with this. If you read through the replies to the bug report, >> > it is clear that NS migration uncovered a corner case or even a bug. So we >> > should try to fix that indeed. >> >> I'm with Mani, we

Re: [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot

2020-08-17 Thread Amit Pundir
On Mon, 8 Jun 2020 at 17:07, Kalle Valo wrote: > > I don't agree with this. If you read through the replies to the bug report, > > it is clear that NS migration uncovered a corner case or even a bug. So we > > should try to fix that indeed. > > I'm with Mani, we should try to fix ath10k instead.

Re: [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot

2020-06-08 Thread Kalle Valo
Manivannan Sadhasivam writes: > On Tue, Jun 02, 2020 at 01:04:26PM -0700, Brian Norris wrote: >> On Tue, Jun 2, 2020 at 12:40 PM John Stultz wrote: >> > On Tue, Jun 2, 2020 at 12:16 PM Brian Norris >> > wrote: >> > > On Mon, Jun 1, 2020 at 10:25 PM John Stultz >> > > wrote: >> > > > >> > >

Re: [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot

2020-06-08 Thread Kalle Valo
John Stultz writes: > Ever since 5.7-rc1, if we call > ath10k_qmi_remove_msa_permission(), the db845c hard crashes on > reboot, resulting in the device getting stuck in the usb crash > debug mode and not coming back up wihthout a hard power off. > > This hack avoids the issue by returning early

Re: [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot

2020-06-04 Thread Sibi Sankar
On 2020-06-03 15:37, govi...@codeaurora.org wrote: Hi Mani, On 2020-06-03 05:57, Manivannan Sadhasivam wrote: On Tue, Jun 02, 2020 at 01:04:26PM -0700, Brian Norris wrote: On Tue, Jun 2, 2020 at 12:40 PM John Stultz wrote: > On Tue, Jun 2, 2020 at 12:16 PM Brian Norris wrote: > > On Mon,

Re: [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot

2020-06-03 Thread govinds
Hi Mani, On 2020-06-03 05:57, Manivannan Sadhasivam wrote: On Tue, Jun 02, 2020 at 01:04:26PM -0700, Brian Norris wrote: On Tue, Jun 2, 2020 at 12:40 PM John Stultz wrote: > On Tue, Jun 2, 2020 at 12:16 PM Brian Norris wrote: > > On Mon, Jun 1, 2020 at 10:25 PM John Stultz wrote: > > > > >

Re: [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot

2020-06-02 Thread Manivannan Sadhasivam
On Tue, Jun 02, 2020 at 01:04:26PM -0700, Brian Norris wrote: > On Tue, Jun 2, 2020 at 12:40 PM John Stultz wrote: > > On Tue, Jun 2, 2020 at 12:16 PM Brian Norris > > wrote: > > > On Mon, Jun 1, 2020 at 10:25 PM John Stultz > > > wrote: > > > > > > > > Ever since 5.7-rc1, if we call > > > >

Re: [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot

2020-06-02 Thread Brian Norris
On Tue, Jun 2, 2020 at 12:40 PM John Stultz wrote: > On Tue, Jun 2, 2020 at 12:16 PM Brian Norris wrote: > > On Mon, Jun 1, 2020 at 10:25 PM John Stultz wrote: > > > > > > Ever since 5.7-rc1, if we call > > > ath10k_qmi_remove_msa_permission(), the db845c hard crashes on > > > reboot, resulting

Re: [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot

2020-06-02 Thread John Stultz
On Tue, Jun 2, 2020 at 12:16 PM Brian Norris wrote: > > + Sibi > > On Mon, Jun 1, 2020 at 10:25 PM John Stultz wrote: > > > > Ever since 5.7-rc1, if we call > > ath10k_qmi_remove_msa_permission(), the db845c hard crashes on > > reboot, resulting in the device getting stuck in the usb crash > >

Re: [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot

2020-06-02 Thread Brian Norris
+ Sibi On Mon, Jun 1, 2020 at 10:25 PM John Stultz wrote: > > Ever since 5.7-rc1, if we call > ath10k_qmi_remove_msa_permission(), the db845c hard crashes on > reboot, resulting in the device getting stuck in the usb crash > debug mode and not coming back up wihthout a hard power off. > > This