Re: [PATCH v13] ath10k: add LED and GPIO controlling support for various chipsets

2018-04-10 Thread Sebastian Gottschall
Am 09.04.2018 um 17:49 schrieb Kalle Valo: Sebastian Gottschall writes: you removed the call to leds_start from certain locations but you seem to have ignored the comment i wrote above the function call. IIRC I moved the comment to ath10k_leds_start(). there is a

[PATCH 3/4] ath10k: Enable SRRI/DRRI support on ddr for WCN3990

2018-04-10 Thread pillair
From: Govind Singh SRRI/DRRI are not mapped in the HW Shadow block and can lead to un-clocked access if common subsystem in the target is powered down due to idle mode. To mitigate this problem SRRI/DRRI can be read from DDR instead of doing an actual hardware read. Host

Re: ath10k: sdio: fix memory leak for probe allocations

2018-04-10 Thread Kalle Valo
Marcus Folkesson wrote: > These allocations are not freed upon release. > When on it; go for managed resources instead. > > Signed-off-by: Marcus Folkesson > [kvalo: fix two checkpatch warnings] > Signed-off-by: Kalle Valo

[PATCH 0/4] Support for STA idle mode power save(IMPS)

2018-04-10 Thread pillair
From: Rakesh Pillai Enable STA idle mode power save(IMPS) for WCN3990 TLV target. In-order to support STA idle mode ps direct access to CE registers are protected via 2 mechanism. As target can power collapse based on idle inactivity and any target register access during

Re: ath10k: fix spelling mistake: "tiggers" -> "triggers"

2018-04-10 Thread Kalle Valo
Colin Ian King wrote: > Trivial fix to spelling mistake in message text > > Signed-off-by: Colin Ian King > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 6ce36faeac35 ath10k: fix

Re: ath10k: avoid possible string overflow

2018-04-10 Thread Kalle Valo
Arnd Bergmann wrote: > The way that 'strncat' is used here raised a warning in gcc-8: > > drivers/net/wireless/ath/ath10k/wmi.c: In function > 'ath10k_wmi_tpc_stats_final_disp_tables': > drivers/net/wireless/ath/ath10k/wmi.c:4649:4: error: 'strncat' output > truncated before

[PATCH 1/4] ath10k: Add hw params for shadow register support

2018-04-10 Thread pillair
From: Rakesh Pillai wcn3990 supports shadow register for ce write. Add a hw param for shadow register support. Signed-off-by: Rakesh Pillai --- drivers/net/wireless/ath/ath10k/core.c | 13 + drivers/net/wireless/ath/ath10k/hw.h |

[PATCH 2/4] ath10k: Add support for shadow register for WNC3990

2018-04-10 Thread pillair
From: Rakesh Pillai WCN3990 needs shadow register write operation support for copy engine for regular operation in powersave mode. Add support for copy engine shadow register write in datapath tx for WCN3990 Signed-off-by: Rakesh Pillai ---

[PATCH 4/4] ath10k: Enable sta idle power save

2018-04-10 Thread pillair
From: Govind Singh Enable sta power save in fw for the targets that supports idle power save. The idle ps enable command will be ignored by the firmware which does not support this feature. Signed-off-by: Govind Singh Signed-off-by: Rakesh Pillai

Re: [v2,13/13] dt: bindings: add bindings for wcn3990 wifi block

2018-04-10 Thread Kalle Valo
Govind Singh wrote: > Add device tree binding documentation details for wcn3990 > wifi block present in Qualcomm SDM845/APQ8098 SoC into > "qcom,ath10k.txt". > > Signed-off-by: Govind Singh > Signed-off-by: Kalle Valo

[PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block

2018-04-10 Thread Govind Singh
Add device tree binding documentation details for wcn3990 wifi block present in Qualcomm SDM845/APQ8098 SoC into "qcom,ath10k.txt". Signed-off-by: Govind Singh --- .../bindings/net/wireless/qcom,ath10k.txt | 31 ++ 1 file changed, 31

Re: [PATCH v2] dt: bindings: add bindings for wcn3990 wifi block

2018-04-10 Thread govinds
Thanks Rob for the review comments. I have addressed the review comments in [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block. diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt

[PATCH] ath10k: fixed scan crash

2018-04-10 Thread zhichen
From: Zhi Chen Length of WMI scan message was not calculated correctly. The allocated buffer was smaller than what we expected. So WMI message corrupted skb_info, which is at the end of skb->data. This fix takes TLV header into account even if the element is zero-length.

[PATCH] ath10k: fix tlv 5ghz channel missing issue

2018-04-10 Thread zhichen
From: Zhi Chen The 5ghz channel parameters of TLV target wasn't passed to host, it caused host can only use lower channels from 36 to 64. Signed-off-by: Zhi Chen --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 ++ 1 file changed, 2