ath10k qca9377 802.11s fail ("awmode = 1 requires support from firmware")

2018-11-02 Thread Stuart Trusty
Greetings all, I am seeing conflicting reports about what works and doesn't for mesh in ath10k. I just installed the latest firmware from kvalo and am still getting this error on driver load: [ 6582.327719] ath10k_pci :03:00.0: rawmode = 1 requires support from firmware [ 6582.327722]

Re: [PATCH 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-11-02 Thread Toke Høiland-Jørgensen
Rajkumar Manoharan writes: > On 2018-10-28 15:01, Rajkumar Manoharan wrote: >> On 2018-10-28 08:48, Toke Høiland-Jørgensen wrote: >>> Rajkumar Manoharan writes: >>> 4ms 223 (40%) 214 (40%)109 (10%) 94 (10%) 4ms 337 (90%) 182 (8%)

[PATCH] ath10k: ath10k_snoc_{read,write}32() should be static

2018-11-02 Thread Brian Norris
They're provided as callbacks in ath10k_hif_ops and should be accessed that way, if needed outside of snoc.c, and anyway, they're currently unused outside snoc.c. Signed-off-by: Brian Norris --- drivers/net/wireless/ath/ath10k/snoc.c | 4 ++-- drivers/net/wireless/ath/ath10k/snoc.h | 2 -- 2

[PATCH 2/3] ath10k: don't assume this is a PCI dev in generic code

2018-11-02 Thread Brian Norris
Not all devices using this driver are backed by a PCI device, so it's not fair to assume 'to_pci_dev()' is valid. Fortunately, we only were using this to convert straight back to a bare 'device', which means we were only doing no-op pointer arithmetic, and not actually accessing potentially

[PATCH 3/3] ath10k: fix struct init whitespace in SNOC driver

2018-11-02 Thread Brian Norris
Signed-off-by: Brian Norris --- drivers/net/wireless/ath/ath10k/snoc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c index 8d3d9bca410f..ffdebf9a5ac6 100644 ---

[PATCH 1/3] ath10k: assign 'n_cipher_suites' for WCN3990

2018-11-02 Thread Brian Norris
Commit 2ea9f12cefe4 ("ath10k: add new cipher suite support") added a new n_cipher_suites HW param with a fallback value and a warning log. Commit 03a72288c546 ("ath10k: wmi: add hw params entry for wcn3990") later added WCN3990 HW entries, but it missed the n_cipher_suites. Rather than seeing

Re: [PATCH] ath10k: avoid -Wmaybe-uninitialized warning

2018-11-02 Thread Brian Norris
Hi, On Fri, Nov 2, 2018 at 9:19 AM Arnd Bergmann wrote: > > In some configurations the inlining in gcc is suboptimal, causing > a false-positive warning: > > drivers/net/wireless/ath/ath10k/mac.c: In function 'ath10k_mac_init_rd': > drivers/net/wireless/ath/ath10k/mac.c:8374:39: error: 'rd' may

[PATCH] ath10k: avoid -Wmaybe-uninitialized warning

2018-11-02 Thread Arnd Bergmann
In some configurations the inlining in gcc is suboptimal, causing a false-positive warning: drivers/net/wireless/ath/ath10k/mac.c: In function 'ath10k_mac_init_rd': drivers/net/wireless/ath/ath10k/mac.c:8374:39: error: 'rd' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Re: [PATCH v3 1/3] dt: bindings: add missing dt properties for WCN3990 wifi node

2018-11-02 Thread Brian Norris
Hi Stephen and Govind, I was chatting with Govind, and he seemed to be a bit stalled on this. I'd encourage him to reply with whatever knowledge he has, because it's a bit hard to give definitive answers when I don't know all the inner workings here. (In fact, you, Stephen, probably know more