Re: [PATCH v2 1/3] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-04-03 Thread Krzysztof Kozlowski
On 30/03/2024 23:04, Marc Gonzalez wrote: > On 30/03/2024 19:23, Krzysztof Kozlowski wrote: > >> On 30/03/2024 19:20, Krzysztof Kozlowski wrote: >> >>> On 28/03/2024 18:36, Marc Gonzalez wrote: >>> The ath10k driver waits for an "MSA_READY" indicator to complete initialization. If the

[PATCH v2 4/7] wifi: ath10k: sdio: drop driver owner initialization

2024-04-03 Thread Krzysztof Kozlowski
Core in sdio_register_driver() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski Acked-by: Jeff Johnson --- Depends on the patch in mmc tree. --- drivers/net/wireless/ath/ath10k/sdio.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v2 6/7] wifi: mwifiex: drop driver owner initialization

2024-04-03 Thread Krzysztof Kozlowski
Core in sdio_register_driver() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski Acked-by: Kalle Valo Reviewed-by: Francesco Dolcini --- Depends on the patch in mmc tree. --- drivers/net/wireless/marvell/mwifiex/sdio.c | 1 - 1 file changed, 1

[PATCH v2 0/7] mmc/wifi/bluetooth: store owner from modules with sdio_register_driver()

2024-04-03 Thread Krzysztof Kozlowski
Changes in v2: 1. Add "wifi: ath10k: sdio: simplify module initialization" patch, from my other patchset to avoid conflicts. 2. Add Acks/Rb tags. 3. Drop applied SDIO patch, which was the dependency for the rest cleanups. 4. Update subjects according to feedback. - Link to v1:

[PATCH v2 3/7] wifi: ath10k: sdio: simplify module initialization

2024-04-03 Thread Krzysztof Kozlowski
This driver's initialization functions do not perform any custom code, except printing messages. Printing messages on modules loading/unloading is discouraged because it pollutes the dmesg regardless whether user actually has this device. Core kernel code already gives tools to investigate

[PATCH v2 1/7] Bluetooth: btmrvl_sdio: drop driver owner initialization

2024-04-03 Thread Krzysztof Kozlowski
Core in sdio_register_driver() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski --- Depends on the patch in mmc tree. --- drivers/bluetooth/btmrvl_sdio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/bluetooth/btmrvl_sdio.c

[PATCH v2 2/7] Bluetooth: btmtksdio: drop driver owner initialization

2024-04-03 Thread Krzysztof Kozlowski
Core in sdio_register_driver() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski --- Depends on the patch in mmc tree. --- drivers/bluetooth/btmtksdio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/bluetooth/btmtksdio.c

Re: [PATCH v2 3/3] arm64: dts: qcom: msm8998: set qcom,no-msa-ready-indicator for wifi

2024-04-03 Thread Dmitry Baryshkov
On Wed, 3 Apr 2024 at 16:05, Marc Gonzalez wrote: > > On 02/04/2024 17:55, Dmitry Baryshkov wrote: > > > On Tue, 2 Apr 2024 at 18:31, Marc Gonzalez wrote: > > > >> So, if I understand correctly, I take this to mean that I should: > >> > >> 1) DELETE the qcom,no-msa-ready-indicator boolean

Re: [PATCH v2 3/3] arm64: dts: qcom: msm8998: set qcom,no-msa-ready-indicator for wifi

2024-04-03 Thread Marc Gonzalez
On 02/04/2024 17:55, Dmitry Baryshkov wrote: > On Tue, 2 Apr 2024 at 18:31, Marc Gonzalez wrote: > >> So, if I understand correctly, I take this to mean that I should: >> >> 1) DELETE the qcom,no-msa-ready-indicator boolean property, >> 2) ADD a "qcom,msm8998-wifi" (name OK?) compatible, > > I'd

Re: [PATCH 7/7] wifi: silabs: wfx: drop driver owner initialization

2024-04-03 Thread Kalle Valo
Krzysztof Kozlowski writes: > Core in sdio_register_driver() already sets the .owner, so driver does > not need to. > > Signed-off-by: Krzysztof Kozlowski Also here the preferred title format is: wifi: wfx: drop driver owner initialization Feel free to take this via sdio tree: Acked-by:

Re: [PATCH 6/7] wifi: marvell: mwifiex: drop driver owner initialization

2024-04-03 Thread Kalle Valo
Krzysztof Kozlowski writes: > Core in sdio_register_driver() already sets the .owner, so driver does > not need to. > > Signed-off-by: Krzysztof Kozlowski The preferred title format is: wifi: mwifiex: drop driver owner initialization But that's just cosmetics. Feel free to take this via sdio

Re: [PATCH 1/6] wifi: ath10k: sdio: simplify module initialization

2024-04-03 Thread Krzysztof Kozlowski
On 03/04/2024 15:50, Kalle Valo wrote: > Jeff Johnson writes: > >> On 3/29/2024 10:10 AM, Krzysztof Kozlowski wrote: >>> This driver's initialization functions do not perform any custom code, >>> except printing messages. Printing messages on modules >>> loading/unloading is discouraged because

[PATCH v2 5/7] wifi: brcm80211: drop driver owner initialization

2024-04-03 Thread Krzysztof Kozlowski
Core in sdio_register_driver() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski Acked-by: Arend van Spriel --- Depends on the patch in mmc tree. --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 1 - 1 file changed, 1 deletion(-) diff

Re: [PATCH 1/6] wifi: ath10k: sdio: simplify module initialization

2024-04-03 Thread Kalle Valo
Jeff Johnson writes: > On 3/29/2024 10:10 AM, Krzysztof Kozlowski wrote: >> This driver's initialization functions do not perform any custom code, >> except printing messages. Printing messages on modules >> loading/unloading is discouraged because it pollutes the dmesg >> regardless whether

Re: [PATCH 1/6] wifi: ath10k: sdio: simplify module initialization

2024-04-03 Thread Krzysztof Kozlowski
On 03/04/2024 15:50, Kalle Valo wrote: > Jeff Johnson writes: > >> On 3/29/2024 10:10 AM, Krzysztof Kozlowski wrote: >>> This driver's initialization functions do not perform any custom code, >>> except printing messages. Printing messages on modules >>> loading/unloading is discouraged because

Re: [PATCH v2 3/3] arm64: dts: qcom: msm8998: set qcom,no-msa-ready-indicator for wifi

2024-04-03 Thread Krzysztof Kozlowski
On 03/04/2024 15:05, Marc Gonzalez wrote: > On 02/04/2024 17:55, Dmitry Baryshkov wrote: > >> On Tue, 2 Apr 2024 at 18:31, Marc Gonzalez wrote: >> >>> So, if I understand correctly, I take this to mean that I should: >>> >>> 1) DELETE the qcom,no-msa-ready-indicator boolean property, >>> 2) ADD a

[PATCH v2 7/7] wifi: wfx: drop driver owner initialization

2024-04-03 Thread Krzysztof Kozlowski
Core in sdio_register_driver() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski Acked-by: Kalle Valo --- Depends on the patch in mmc tree. --- drivers/net/wireless/silabs/wfx/bus_sdio.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH 1/6] wifi: ath10k: sdio: simplify module initialization

2024-04-03 Thread Kalle Valo
Krzysztof Kozlowski writes: > On 03/04/2024 15:50, Kalle Valo wrote: > >> Jeff Johnson writes: >> >>> On 3/29/2024 10:10 AM, Krzysztof Kozlowski wrote: This driver's initialization functions do not perform any custom code, except printing messages. Printing messages on modules

[PATCH] arm64: dts: qcom: sm8150-hdk: enable WiFI support

2024-04-03 Thread Dmitry Baryshkov
_0p75>; + vdd-1.8-xo-supply = <_l7a_1p8>; + vdd-1.3-rfa-supply = <_l2c_1p3>; + vdd-3.3-ch0-supply = <_l11c_3p3>; + + qcom,ath10k-calibration-variant = "Qualcomm_sm8150hdk"; +}; --- base-commit: abfb54bc2d2b925336c6ea9ae2b335e3867ceb89 change-id: 20240403-sm8150-hdk-wifi-74deaecaaecb Best regards, -- Dmitry Baryshkov

Re: [PATCH v2 3/3] arm64: dts: qcom: msm8998: set qcom,no-msa-ready-indicator for wifi

2024-04-03 Thread Marc Gonzalez
On 03/04/2024 16:12, Dmitry Baryshkov wrote: > From [Jeff's] message it looks like we are expected to get MSA READY even on > msm8998. This is the code we're using: