[PATCH 2/2] ath10k: fix potential memory leak in ath10k_wmi_tlv_op_pull_fw_stats()

2016-12-05 Thread Christian Lamparter
ath10k_wmi_tlv_op_pull_fw_stats() uses tb = ath10k_wmi_tlv_parse_alloc(...) function, which allocates memory. If any of the three error-paths are taken, this tb needs to be freed. Signed-off-by: Christian Lamparter --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 12

[PATCH 1/2] ath10k: add accounting for the extended peer statistics

2016-12-05 Thread Christian Lamparter
The 10.4 firmware adds extended peer information to the firmware's statistics payload. This additional info is stored as a separate data field and the elements are stored in their own "peers_extd" list. These elements can pile up in the same way as the peer information elements. This is because

RE: ath10k firmware crashes in mesh mode on QCA9880

2016-12-05 Thread Nagarajan, Ashok Raj
>> Applied the patch and tried with 10.2.4.70.54 firmware and it still crashes: >> [ 142.438377] ath10k_pci :01:00.0: firmware crashed! (uuid >> a5499582-e220-46d2-9359-0b44219f69ea) >> [ 142.447512] ath10k_pci :01:00.0: qca988x hw2.0 target 0x4100016c >> chip_id 0x043202ff sub

Re: [PATCH 1/3] ath10k: Ensure there are no stale ar->txqs entries.

2016-12-05 Thread Ben Greear
On 12/05/2016 12:50 AM, Michal Kazior wrote: On 2 December 2016 at 01:24, Ben Greear wrote: On 12/01/2016 02:52 PM, Ben Greear wrote: On 08/19/2016 06:34 AM, Ben Greear wrote: On 08/18/2016 11:59 PM, Michal Kazior wrote: On 19 August 2016 at 03:26,

Re: ath10k firmware crashes in mesh mode on QCA9880

2016-12-05 Thread Benjamin Morgan
Applied the patch and tried with 10.2.4.70.54 firmware and it still crashes: [ 142.438377] ath10k_pci :01:00.0: firmware crashed! (uuid a5499582-e220-46d2-9359-0b44219f69ea) [ 142.447512] ath10k_pci :01:00.0: qca988x hw2.0 target 0x4100016c chip_id 0x043202ff sub : [

[PATCH] ath10k: free host-mem with DMA_BIRECTIONAL flag.

2016-12-05 Thread greearb
From: Ben Greear Hopefully this fixes the problem reported by Kalle: Noticed this in my log, but I don't have time to investigate this in detail right now: [ 413.795346] IPv6: ADDRCONF(NETDEV_UP): wlan0: link is not ready [ 414.158755] IPv6: ADDRCONF(NETDEV_CHANGE):

Re: [PATCH 1/2] mac80211: do not iterate active interfaces when in re-configure

2016-12-05 Thread Adrian Chadd
fwiw, I'm facing the same kinds of cleanup problems with my port of (oct 2015) ath10k to freebsd. The oct 2015 ath10k tree doesn't have the firmware per-txq/tid/peer feedback stuff in it, so this hasn't yet bitten me, but there rest of the races have - mostly surrounding handling pending TX

Re: [PATCH 1/2] mac80211: do not iterate active interfaces when in re-configure

2016-12-05 Thread Ben Greear
On 12/05/2016 05:52 AM, Johannes Berg wrote: On Mon, 2016-12-05 at 09:13 +0100, Michal Kazior wrote: On 2 December 2016 at 03:29, wrote: From: Ben Greear This appears to fix a problem where ath10k firmware would crash, mac80211 would

Re: [PATCH 1/2] mac80211: do not iterate active interfaces when in re-configure

2016-12-05 Thread Ben Greear
On 12/05/2016 07:00 AM, Johannes Berg wrote: On Mon, 2016-12-05 at 06:57 -0800, Ben Greear wrote: I think clearing sdata-in-driver would fix the ath10k problem, at least, but I was afraid it would break something else in mac80211 or maybe in other thick firmware drivers. It's pretty much

Re: [PATCH 1/2] mac80211: do not iterate active interfaces when in re-configure

2016-12-05 Thread Johannes Berg
On Mon, 2016-12-05 at 06:57 -0800, Ben Greear wrote: > I think clearing sdata-in-driver would fix the ath10k problem, at > least, but I was afraid it would break something else in mac80211 or > maybe in other thick firmware drivers. It's pretty much an internal thing - not sure what it'd break.

Re: [PATCH 2/4] cfg80211: Add new NL80211_CMD_SET_BTCOEX_PRIORITY to support BTCOEX

2016-12-05 Thread Johannes Berg
On Tue, 2016-11-08 at 18:45 +0530, c_tr...@qti.qualcomm.com wrote: >  > + * struct cfg80211_btcoex_priority - BTCOEX support frame type > + * > + * This structure defines the driver supporting frame types for > BTCOEX > + * > + * @wlan_be_preferred: best effort frames preferred over bt traffic > +

Re: [PATCH 1/4] cfg80211: Add support to enable or disable btcoex

2016-12-05 Thread Johannes Berg
On Tue, 2016-11-08 at 18:45 +0530, c_tr...@qti.qualcomm.com wrote: > From: Tamizh chelvam > > This patch adds support to enable or disable btcoex by > adding NL80211_ATTR_WIPHY_BTCOEX_ENABLE attribute in > NL80211_CMD_SET_WIPHY command. By default BTCOEX disabled in

Re: [PATCH 1/2] mac80211: do not iterate active interfaces when in re-configure

2016-12-05 Thread Johannes Berg
On Mon, 2016-12-05 at 09:13 +0100, Michal Kazior wrote: > On 2 December 2016 at 03:29,   wrote: > > > > From: Ben Greear > > > > This appears to fix a problem where ath10k firmware would crash, > > mac80211 would start re-adding interfaces to

TR: Client station sends probes on DFS channels

2016-12-05 Thread Jean-Pierre Tosoni
Just keeping the list informed... At some point the discussion turned private. Jean-Pierre Tosoni -Message d'origine- De : Adrian Chadd [mailto:adrian.ch...@gmail.com] Envoyé : jeudi 1 décembre 2016 19:20 À : Jean-Pierre Tosoni Objet : Re: Client station sends probes on DFS channels

Re: ath10k: wmi-alloc-chunk should use DMA_BIDIRECTIONAL.

2016-12-05 Thread Valo, Kalle
gree...@candelatech.com writes: > From: Ben Greear > > These memory chunks are often used as 'swap' by the NIC, > so it will be both reading and writing to these areas. > > This seems to fix errors like this on my x86-64 machine: > > kernel: DMAR: DMAR:[DMA Write]

Re: [PATCH 1/3] ath10k: Ensure there are no stale ar->txqs entries.

2016-12-05 Thread Michal Kazior
On 2 December 2016 at 01:24, Ben Greear wrote: > On 12/01/2016 02:52 PM, Ben Greear wrote: >> >> On 08/19/2016 06:34 AM, Ben Greear wrote: >>> >>> >>> >>> On 08/18/2016 11:59 PM, Michal Kazior wrote: On 19 August 2016 at 03:26, wrote:

Re: [PATCH 1/2] mac80211: do not iterate active interfaces when in re-configure

2016-12-05 Thread Michal Kazior
On 2 December 2016 at 03:29, wrote: > From: Ben Greear > > This appears to fix a problem where ath10k firmware would crash, > mac80211 would start re-adding interfaces to the driver, but the > iterate-active-interfaces logic would then try to