Re: Setting single rate in ath10k broken by "reject/clear user rate mask if not usable"

2017-10-27 Thread Ben Greear
On 10/27/2017 01:15 PM, Johannes Berg wrote: On Wed, 2017-10-25 at 09:13 -0700, Ben Greear wrote: Well it resulted in a WARN_ON because if the AP didn't have those rates, we'd not find any usable rates while trying to transmit a frame, and then ended up warning and falling down to the lowest

Re: Setting single rate in ath10k broken by "reject/clear user rate mask if not usable"

2017-10-27 Thread Johannes Berg
On Wed, 2017-10-25 at 09:13 -0700, Ben Greear wrote: > > Well it resulted in a WARN_ON because if the AP didn't have those > > rates, we'd not find any usable rates while trying to transmit a frame, > > and then ended up warning and falling down to the lowest possible rate. > > > > I don't think

[ath6kl:pending 41/41] drivers/net/wireless/ath/ath10k/core.c:877:2: warning: ignoring return value of 'strscpy', declared with attribute warn_unused_result

2017-10-27 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending head: 5d01bd0fd2c14409ae67a04c46b8519137c4a877 commit: 5d01bd0fd2c14409ae67a04c46b8519137c4a877 [41/41] ath10k: search DT for qcom,ath10k-calibration-variant config: i386-randconfig-x076-201743 (attached as .config)

Re: ath10k-regression due to "ath10k: fix napi_poll budget overflow" c9353bf483d3

2017-10-27 Thread Ryan Hsu
On 10/27/2017 02:40 AM, Kalle Valo wrote: > + linux-wireless > > Sorry, I have not been able to follow this discussion very closely but > was the conclusion? Should we should revert c9353bf483d3 for 4.14 or > what? I should still have time to do that, but not much. Kalle, I don't think I have

Re: Throughput drop with ath10k latest driver and firmware-5.bin_10.2.4.70.66

2017-10-27 Thread Ben Greear
On 10/27/2017 01:25 AM, KAVITA MATHUR wrote: On Thu, 26 Oct 2017 07:48:18 -0700, Ben Greear wrote On 10/26/2017 04:20 AM, KAVITA MATHUR wrote: Hi, In my AP , there are two radios, one ath9k based module WLE200NX and second ath10k based WLE600VX. I configured both the radios as AP in IEEE

Re: [v3] ath10k: rebuild crypto header in rx data frames

2017-10-27 Thread Kalle Valo
Kalle Valo wrote: > Rx data frames notified through HTT_T2H_MSG_TYPE_RX_IND and > HTT_T2H_MSG_TYPE_RX_FRAG_IND expect PN/TSC check to be done > on host (mac80211) rather than firmware. Rebuild cipher header > in every received data frames (that are notified through those

Re: ath10k: spectral: Remove redundant check

2017-10-27 Thread Kalle Valo
Christos Gkekas wrote: > Variable val is unsigned, so checking whether it is less than zero is > redundant. > > Signed-off-by: Christos Gkekas > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git,

Re: ath10k: fix sending wmi cmd during the tdls teardown

2017-10-27 Thread Kalle Valo
ako...@qti.qualcomm.com wrote: > The current firmware 10.4-3.5.1-00035 on QCA9888 supports > TDLS explicit mode, it expects WMI_TDLS_ENABLE_PASSIVE > for tdls setup and WMI_TDLS_DISABLE for tdls teardown. > > Signed-off-by: Anilkumar Kolli > Signed-off-by: Kalle Valo

Re: [1/2] ath10k: move ath10k_mac_tdls_vif*() functions

2017-10-27 Thread Kalle Valo
ako...@qti.qualcomm.com wrote: > To be able to use ath10k_mac_tdls_vif_stations_count() in > ath10k_hw_scan() in the following patch, move the functions > earlier in the file. > > This commit is pure code move, no functional changes. > > Signed-off-by: Anilkumar Kolli

Re: ath10k: fix build errors with !CONFIG_PM

2017-10-27 Thread Kalle Valo
Brian Norris wrote: > Build errors have been reported with CONFIG_PM=n: > > drivers/net/wireless/ath/ath10k/pci.c:3416:8: error: implicit > declaration of function 'ath10k_pci_suspend' > [-Werror=implicit-function-declaration] > >

[ath6kl:pending 29/41] drivers/net//wireless/ath/wil6210/pcie_bus.c:511:2: error: implicit declaration of function 'wil6210_resume'

2017-10-27 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending head: dd08329d31a4c150f8aab8274033901baaf3e923 commit: 7d111dd1ffbf5268e2c17e0e193951cc1795bf5c [29/41] wil6210: run-time PM when interface down config: xtensa-allyesconfig (attached as .config) compiler:

Re: ath10k-regression due to "ath10k: fix napi_poll budget overflow" c9353bf483d3

2017-10-27 Thread Kalle Valo
+ linux-wireless Thorsten Leemhuis writes: > Lo! On 03.10.2017 01:40, Ryan Hsu wrote: >> On 10/01/2017 01:59 AM, Thorsten Leemhuis wrote: >>> Lo! The wifi connection of my Dell XPS13 (9360) with its QCA6174 >>> sometimes suddenly stops working since I switched to 4.14-rc2+.

Re: [PATCH 2/2] ath10k: search DT for qcom, ath10k-calibration-variant

2017-10-27 Thread Kalle Valo
Sven Eckelmann writes: > On Freitag, 10. März 2017 19:20:54 CEST Christian Lamparter wrote: > [...] >> @Aeolus Yang / Kalle / QCA: Would it be possible to assign a variant string >> to >> the Asus RT-AC58U? >> >> I've attached the necessary bmi-board-id=16 and

Re: [v7,2/5] ath10k: Enable TDLS peer buffer STA feature

2017-10-27 Thread Kalle Valo
yint...@qti.qualcomm.com wrote: > From: Yingying Tang > > Enable TDLS peer buffer STA feature. > QCA6174 firmware(version: WLAN.RM.4.4) support TDLS peer buffer STA, > it reports this capability through wmi service map in wmi service ready > event. Set related

Re: Throughput drop with ath10k latest driver and firmware-5.bin_10.2.4.70.66

2017-10-27 Thread KAVITA MATHUR
On Thu, 26 Oct 2017 07:48:18 -0700, Ben Greear wrote > On 10/26/2017 04:20 AM, KAVITA MATHUR wrote: > > Hi, > > > > In my AP , there are two radios, one ath9k based module WLE200NX and second > > ath10k based > > WLE600VX. > > > > I configured both the radios as AP in IEEE 802.11a 40 MHz HT mode