[PATCH v5] ath10k: add atomic protection for device recovery

2020-08-20 Thread Wen Gong
When it has more than one restart_work queued meanwhile, the 2nd restart_work is very easy to break the 1st restart work and lead recovery fail. Add a flag to allow only one restart work running untill device successfully recovered. Tested-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00049

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-08-20 Thread Wen Gong
On 2020-08-21 04:59, Ben Greear wrote: On 8/20/20 1:15 PM, Krishna Chaitanya wrote: On Thu, Aug 20, 2020 at 11:23 PM Ben Greear wrote: On 8/20/20 10:42 AM, Krishna Chaitanya wrote: On Thu, Aug 20, 2020 at 11:11 PM Krishna Chaitanya wrote: On Thu, Aug 20, 2020 at 10:38 PM Ben Greear

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-08-20 Thread Ben Greear
On 8/20/20 1:15 PM, Krishna Chaitanya wrote: On Thu, Aug 20, 2020 at 11:23 PM Ben Greear wrote: On 8/20/20 10:42 AM, Krishna Chaitanya wrote: On Thu, Aug 20, 2020 at 11:11 PM Krishna Chaitanya wrote: On Thu, Aug 20, 2020 at 10:38 PM Ben Greear wrote: On 8/20/20 10:00 AM, Krishna

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-08-20 Thread Krishna Chaitanya
On Thu, Aug 20, 2020 at 11:23 PM Ben Greear wrote: > > On 8/20/20 10:42 AM, Krishna Chaitanya wrote: > > On Thu, Aug 20, 2020 at 11:11 PM Krishna Chaitanya > > wrote: > >> > >> On Thu, Aug 20, 2020 at 10:38 PM Ben Greear > >> wrote: > >>> > >>> On 8/20/20 10:00 AM, Krishna Chaitanya wrote: >

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-08-20 Thread Ben Greear
On 8/20/20 10:42 AM, Krishna Chaitanya wrote: On Thu, Aug 20, 2020 at 11:11 PM Krishna Chaitanya wrote: On Thu, Aug 20, 2020 at 10:38 PM Ben Greear wrote: On 8/20/20 10:00 AM, Krishna Chaitanya wrote: On Thu, Aug 20, 2020 at 10:02 PM Ben Greear wrote: On 8/20/20 9:08 AM, Krishna

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-08-20 Thread Krishna Chaitanya
On Thu, Aug 20, 2020 at 11:11 PM Krishna Chaitanya wrote: > > On Thu, Aug 20, 2020 at 10:38 PM Ben Greear wrote: > > > > On 8/20/20 10:00 AM, Krishna Chaitanya wrote: > > > On Thu, Aug 20, 2020 at 10:02 PM Ben Greear > > > wrote: > > >> > > >> On 8/20/20 9:08 AM, Krishna Chaitanya wrote: > >

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-08-20 Thread Krishna Chaitanya
On Thu, Aug 20, 2020 at 10:38 PM Ben Greear wrote: > > On 8/20/20 10:00 AM, Krishna Chaitanya wrote: > > On Thu, Aug 20, 2020 at 10:02 PM Ben Greear wrote: > >> > >> On 8/20/20 9:08 AM, Krishna Chaitanya wrote: > >>> On Thu, Aug 20, 2020 at 8:07 PM Wen Gong wrote: > > On 2020-08-20

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-08-20 Thread Ben Greear
On 8/20/20 10:00 AM, Krishna Chaitanya wrote: On Thu, Aug 20, 2020 at 10:02 PM Ben Greear wrote: On 8/20/20 9:08 AM, Krishna Chaitanya wrote: On Thu, Aug 20, 2020 at 8:07 PM Wen Gong wrote: On 2020-08-20 18:52, Krishna Chaitanya wrote: On Thu, Aug 20, 2020 at 3:45 PM Wen Gong wrote:

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-08-20 Thread Krishna Chaitanya
On Thu, Aug 20, 2020 at 10:02 PM Ben Greear wrote: > > On 8/20/20 9:08 AM, Krishna Chaitanya wrote: > > On Thu, Aug 20, 2020 at 8:07 PM Wen Gong wrote: > >> > >> On 2020-08-20 18:52, Krishna Chaitanya wrote: > >>> On Thu, Aug 20, 2020 at 3:45 PM Wen Gong wrote: > > On 2020-08-20

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-08-20 Thread Ben Greear
On 8/20/20 9:08 AM, Krishna Chaitanya wrote: On Thu, Aug 20, 2020 at 8:07 PM Wen Gong wrote: On 2020-08-20 18:52, Krishna Chaitanya wrote: On Thu, Aug 20, 2020 at 3:45 PM Wen Gong wrote: On 2020-08-20 17:19, Krishna Chaitanya wrote: ... I'm not really convinced that this is the right

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-08-20 Thread Krishna Chaitanya
On Thu, Aug 20, 2020 at 8:07 PM Wen Gong wrote: > > On 2020-08-20 18:52, Krishna Chaitanya wrote: > > On Thu, Aug 20, 2020 at 3:45 PM Wen Gong wrote: > >> > >> On 2020-08-20 17:19, Krishna Chaitanya wrote: > ... > >> >> I'm not really convinced that this is the right fix, but I'm no NAPI > >> >>

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-08-20 Thread Wen Gong
On 2020-08-20 18:52, Krishna Chaitanya wrote: On Thu, Aug 20, 2020 at 3:45 PM Wen Gong wrote: On 2020-08-20 17:19, Krishna Chaitanya wrote: ... >> I'm not really convinced that this is the right fix, but I'm no NAPI >> expert. Can anyone else help? > Calling napi_disable() twice can lead to

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-08-20 Thread Krishna Chaitanya
On Thu, Aug 20, 2020 at 3:45 PM Wen Gong wrote: > > On 2020-08-20 17:19, Krishna Chaitanya wrote: > ... > >> > diff --git a/drivers/net/wireless/ath/ath10k/sdio.c > >> > b/drivers/net/wireless/ath/ath10k/sdio.c > >> > index 7b894dcaad2e..b71499b171c6 100644 > >> > ---

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-08-20 Thread Wen Gong
On 2020-08-20 17:26, Krishna Chaitanya wrote: On Thu, Aug 20, 2020 at 2:49 PM Krishna Chaitanya wrote: On Thu, Aug 20, 2020 at 2:03 PM Kalle Valo wrote: > > Wen Gong writes: > ... > I'm not really convinced that this is the right fix, but I'm no NAPI > expert. Can anyone else help?

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-08-20 Thread Wen Gong
On 2020-08-20 17:19, Krishna Chaitanya wrote: ... > diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c > index 7b894dcaad2e..b71499b171c6 100644 > --- a/drivers/net/wireless/ath/ath10k/sdio.c > +++ b/drivers/net/wireless/ath/ath10k/sdio.c > @@ -1756,8

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-08-20 Thread Krishna Chaitanya
On Thu, Aug 20, 2020 at 2:49 PM Krishna Chaitanya wrote: > > On Thu, Aug 20, 2020 at 2:03 PM Kalle Valo wrote: > > > > Wen Gong writes: > > > > > It happened "Kernel panic - not syncing: hung_task: blocked tasks" when > > > test simulate crash and ifconfig down/rmmod meanwhile. > > > > > > Test

Re: [PATCH v4 1/2] ath10k: add refcount for ath10k_core_restart

2020-08-20 Thread Wen Gong
On 2020-08-15 01:19, Kalle Valo wrote: ... I have been thinking a different approach for this. I think another option is to have a function like this: ath10k_core_firmware_crashed() { queue_work(ar->workqueue, >restart_work); } In patch 1 we would convert all existing callers to call

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-08-20 Thread Krishna Chaitanya
On Thu, Aug 20, 2020 at 2:03 PM Kalle Valo wrote: > > Wen Gong writes: > > > It happened "Kernel panic - not syncing: hung_task: blocked tasks" when > > test simulate crash and ifconfig down/rmmod meanwhile. > > > > Test steps: > > > > 1.Test commands > > echo soft >

Re: [RFC] ath10k: change to do napi_enable and napi_disable when insmod and rmmod for sdio

2020-08-20 Thread Kalle Valo
Wen Gong writes: > It happened "Kernel panic - not syncing: hung_task: blocked tasks" when > test simulate crash and ifconfig down/rmmod meanwhile. > > Test steps: > > 1.Test commands > echo soft > /sys/kernel/debug/ieee80211/phy0/ath10k/simulate_fw_crash;sleep > 0.05;ifconfig wlan0 down > echo

[ath6kl:ath-next] BUILD SUCCESS 3c45f21af84eb05a355919abc80cf70a3a681cee

2020-08-20 Thread kernel test robot
randconfig-a012-20200818 x86_64 randconfig-a011-20200818 x86_64 randconfig-a014-20200818 x86_64 randconfig-a015-20200818 x86_64 randconfig-a015-20200820 x86_64 randconfig-a012-20200820 x86_64 randconfig-a016-20200820 x86_64

[ath6kl:ath-qca] BUILD SUCCESS 929043343db1e22814c156692f0b89da9008be6b

2020-08-20 Thread kernel test robot
-20200818 x86_64 randconfig-a011-20200818 x86_64 randconfig-a014-20200818 x86_64 randconfig-a015-20200818 x86_64 randconfig-a015-20200820 x86_64 randconfig-a012-20200820 x86_64 randconfig-a016-20200820 x86_64

[ath6kl:master] BUILD SUCCESS 248337586a5095dce4515a8d24acd207d9054bbb

2020-08-20 Thread kernel test robot
-20200818 x86_64 randconfig-a011-20200818 x86_64 randconfig-a014-20200818 x86_64 randconfig-a015-20200818 x86_64 randconfig-a015-20200820 x86_64 randconfig-a012-20200820 x86_64 randconfig-a016-20200820 x86_64

[ath6kl:master-pending] BUILD SUCCESS 7cdcc832632673f6f91995863604af95ed4bc353

2020-08-20 Thread kernel test robot
randconfig-a012-20200818 x86_64 randconfig-a011-20200818 x86_64 randconfig-a014-20200818 x86_64 randconfig-a015-20200818 x86_64 randconfig-a015-20200820 x86_64 randconfig-a012-20200820 x86_64 randconfig-a016-20200820

[ath6kl:pending] BUILD SUCCESS 75f2996f481bea32ae6ae1e503157c04ea7ab955

2020-08-20 Thread kernel test robot
-20200818 x86_64 randconfig-a011-20200818 x86_64 randconfig-a014-20200818 x86_64 randconfig-a015-20200818 x86_64 randconfig-a015-20200820 x86_64 randconfig-a012-20200820 x86_64 randconfig-a016-20200820 x86_64