On 2020-11-20 04:25, Abhishek Kumar wrote:
Hi,
Johannes has some good comments, apart for that I have some nits.
> And wait, I thought we agreed to remove the index? Now I'm confused.
>
Using index in SET operation doesn't add burden to userspace and
kernel,
but it provides some flexibility
Hi,
Johannes has some good comments, apart for that I have some nits.
> > And wait, I thought we agreed to remove the index? Now I'm confused.
> >
> Using index in SET operation doesn't add burden to userspace and kernel,
> but it provides some flexibility so userspace can skip some certain
>
On 2020-11-06 18:25, Johannes Berg wrote:
Hi,
Looks pretty good. Some comments, mostly nits, below.
Thank you for the comments, Johannes.
I don't understand below well, please help explain:
And even if we do need the index, then perhaps we should use the
(otherwise anyway ignored)
Hi,
Looks pretty good. Some comments, mostly nits, below.
> +/**
> + * nl80211_sar_attrs - Attributes for SAR spec
missing enum
> + *
> + * @NL80211_SAR_ATTR_TYPE: the SAR type and it's defined in
> %nl80211_sar_type.
better use nl80211_sar_type for a link in docs
> + *
> + *
NL80211_CMD_SET_SAR_SPECS is added to configure SAR from
user space. NL80211_ATTR_SAR_SPEC is used to pass the SAR
power specification when used with NL80211_CMD_SET_SAR_SPECS.
Wireless driver needs to register SAR type, supported frequency
ranges to wiphy, so user space can query it. The index
