[PATCH 2/2] ath10k: fix potential memory leak in ath10k_wmi_tlv_op_pull_fw_stats()

[Christian Lamparter]

ath10k_wmi_tlv_op_pull_fw_stats() uses tb = ath10k_wmi_tlv_parse_alloc(...)
function, which allocates memory. If any of the three error-paths are
taken, this tb needs to be freed.

Signed-off-by: Christian Lamparter <chunk...@googlemail.com>
---
 drivers/net/wireless/ath/ath10k/wmi-tlv.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c 
b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
index f304f6632c4f..1f6bb9e8bb01 100644
--- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c
+++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
@@ -1105,8 +1105,10 @@ static int ath10k_wmi_tlv_op_pull_fw_stats(struct ath10k 
*ar,
                struct ath10k_fw_stats_pdev *dst;
 
                src = data;
-               if (data_len < sizeof(*src))
+               if (data_len < sizeof(*src)) {
+                       kfree(tb);
                        return -EPROTO;
+               }
 
                data += sizeof(*src);
                data_len -= sizeof(*src);
@@ -1126,8 +1128,10 @@ static int ath10k_wmi_tlv_op_pull_fw_stats(struct ath10k 
*ar,
                struct ath10k_fw_stats_vdev *dst;
 
                src = data;
-               if (data_len < sizeof(*src))
+               if (data_len < sizeof(*src)) {
+                       kfree(tb);
                        return -EPROTO;
+               }
 
                data += sizeof(*src);
                data_len -= sizeof(*src);
@@ -1145,8 +1149,10 @@ static int ath10k_wmi_tlv_op_pull_fw_stats(struct ath10k 
*ar,
                struct ath10k_fw_stats_peer *dst;
 
                src = data;
-               if (data_len < sizeof(*src))
+               if (data_len < sizeof(*src)) {
+                       kfree(tb);
                        return -EPROTO;
+               }
 
                data += sizeof(*src);
                data_len -= sizeof(*src);
-- 
2.11.0


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k