Re: [PATCH 6/6] ath10k: sdio: replace skb_trim with explicit set of skb->len

2019-10-01 Thread Johannes Berg
On Tue, 2019-10-01 at 15:21 +0300, Kalle Valo wrote: > > > > padded_len = ath10k_sdio_calc_txrx_padded_len(ar_sdio, > > > > skb->len); > > > > - skb_trim(skb, padded_len); > > > > + /* FIXME:

Re: [PATCH 6/6] ath10k: sdio: replace skb_trim with explicit set of skb->len

2019-10-01 Thread Kalle Valo
+ johannes Erik Stromdahl writes: > On 4/12/19 3:17 PM, Kalle Valo wrote: >> Erik Stromdahl writes: >> >>> This patch fixes a bug with padding of the skb data buffer. >>> Since skb_trim can only be used to reduce the skb len, it is useless when >>> we pad (increase the length of) the skb.

Re: [PATCH 6/6] ath10k: sdio: replace skb_trim with explicit set of skb->len

2019-04-15 Thread Erik Stromdahl
On 4/12/19 3:17 PM, Kalle Valo wrote: Erik Stromdahl writes: This patch fixes a bug with padding of the skb data buffer. Since skb_trim can only be used to reduce the skb len, it is useless when we pad (increase the length of) the skb. Instead we must set skb->len directly. Signed-off-by:

Re: [PATCH 6/6] ath10k: sdio: replace skb_trim with explicit set of skb->len

2019-04-12 Thread Kalle Valo
Erik Stromdahl writes: > This patch fixes a bug with padding of the skb data buffer. > Since skb_trim can only be used to reduce the skb len, it is useless when > we pad (increase the length of) the skb. Instead we must set skb->len > directly. > > Signed-off-by: Erik Stromdahl > --- >

[PATCH 6/6] ath10k: sdio: replace skb_trim with explicit set of skb->len

2019-04-09 Thread Erik Stromdahl
This patch fixes a bug with padding of the skb data buffer. Since skb_trim can only be used to reduce the skb len, it is useless when we pad (increase the length of) the skb. Instead we must set skb->len directly. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/sdio.c | 7