Re: [PATCH v3] ath10k: add flag to protect napi operation to avoid dead loop hang

2020-12-16 Thread Kalle Valo
Wen Gong wrote: > It happened "Kernel panic - not syncing: hung_task: blocked tasks" when > test simulate crash and ifconfig down/rmmod meanwhile. > > Test steps: > > 1.Test commands, either can reproduce the hang for PCIe, SDIO and SNOC. > echo soft >

Re: [PATCH v3] ath10k: add flag to protect napi operation to avoid dead loop hang

2020-12-15 Thread Kalle Valo
Wen Gong writes: > On 2020-12-09 23:00, Ben Greear wrote: >> On 12/9/20 1:24 AM, Kalle Valo wrote: >>> Wen Gong writes: >>> On 2020-09-08 00:22, Kalle Valo wrote: > Just like with the recent firmware restart patch, isn't > ar->napi_enabled > racy? Wouldn't

Re: [PATCH v3] ath10k: add flag to protect napi operation to avoid dead loop hang

2020-12-14 Thread Kalle Valo
Ben Greear writes: > On 12/9/20 1:24 AM, Kalle Valo wrote: >> Wen Gong writes: >> >>> On 2020-09-08 00:22, Kalle Valo wrote: >>> Just like with the recent firmware restart patch, isn't ar->napi_enabled racy? Wouldn't test_and_set_bit() and test_and_clear_bit() be safer?

Re: [PATCH v3] ath10k: add flag to protect napi operation to avoid dead loop hang

2020-12-09 Thread Wen Gong
On 2020-12-09 23:00, Ben Greear wrote: On 12/9/20 1:24 AM, Kalle Valo wrote: Wen Gong writes: On 2020-09-08 00:22, Kalle Valo wrote: Just like with the recent firmware restart patch, isn't ar->napi_enabled racy? Wouldn't test_and_set_bit() and test_and_clear_bit() be safer? Or are we

Re: [PATCH v3] ath10k: add flag to protect napi operation to avoid dead loop hang

2020-12-09 Thread Wen Gong
On 2020-12-09 17:24, Kalle Valo wrote: Wen Gong writes: On 2020-09-08 00:22, Kalle Valo wrote: Just like with the recent firmware restart patch, isn't ar->napi_enabled racy? Wouldn't test_and_set_bit() and test_and_clear_bit() be safer? Or are we holding a lock? But then that should be

Re: [PATCH v3] ath10k: add flag to protect napi operation to avoid dead loop hang

2020-12-09 Thread Ben Greear
On 12/9/20 1:24 AM, Kalle Valo wrote: Wen Gong writes: On 2020-09-08 00:22, Kalle Valo wrote: Just like with the recent firmware restart patch, isn't ar->napi_enabled racy? Wouldn't test_and_set_bit() and test_and_clear_bit() be safer? Or are we holding a lock? But then that should be

Re: [PATCH v3] ath10k: add flag to protect napi operation to avoid dead loop hang

2020-12-09 Thread Kalle Valo
Wen Gong writes: > On 2020-09-08 00:22, Kalle Valo wrote: > >> Just like with the recent firmware restart patch, isn't >> ar->napi_enabled >> racy? Wouldn't test_and_set_bit() and test_and_clear_bit() be safer? >> >> Or are we holding a lock? But then that should be documented with >>

Re: [PATCH v3] ath10k: add flag to protect napi operation to avoid dead loop hang

2020-12-09 Thread Kalle Valo
Krishna Chaitanya writes: > On Fri, Aug 28, 2020 at 5:53 PM Wen Gong wrote: >> >> It happened "Kernel panic - not syncing: hung_task: blocked tasks" when >> test simulate crash and ifconfig down/rmmod meanwhile. (editing out hundreds of lines of unnecessary text, please edit your quotes) >

Re: [PATCH v3] ath10k: add flag to protect napi operation to avoid dead loop hang

2020-09-07 Thread Wen Gong
On 2020-09-08 00:22, Kalle Valo wrote: Wen Gong writes: [...] Just like with the recent firmware restart patch, isn't ar->napi_enabled racy? Wouldn't test_and_set_bit() and test_and_clear_bit() be safer? Or are we holding a lock? But then that should be documented with

Re: [PATCH v3] ath10k: add flag to protect napi operation to avoid dead loop hang

2020-09-07 Thread Kalle Valo
Wen Gong writes: > It happened "Kernel panic - not syncing: hung_task: blocked tasks" when > test simulate crash and ifconfig down/rmmod meanwhile. > > Test steps: > > 1.Test commands, either can reproduce the hang for PCIe, SDIO and SNOC. > echo soft >

Re: [PATCH v3] ath10k: add flag to protect napi operation to avoid dead loop hang

2020-08-28 Thread Krishna Chaitanya
On Fri, Aug 28, 2020 at 5:53 PM Wen Gong wrote: > > It happened "Kernel panic - not syncing: hung_task: blocked tasks" when > test simulate crash and ifconfig down/rmmod meanwhile. > > Test steps: > > 1.Test commands, either can reproduce the hang for PCIe, SDIO and SNOC. > echo soft >

[PATCH v3] ath10k: add flag to protect napi operation to avoid dead loop hang

2020-08-28 Thread Wen Gong
It happened "Kernel panic - not syncing: hung_task: blocked tasks" when test simulate crash and ifconfig down/rmmod meanwhile. Test steps: 1.Test commands, either can reproduce the hang for PCIe, SDIO and SNOC. echo soft > /sys/kernel/debug/ieee80211/phy0/ath10k/simulate_fw_crash;sleep