Kernel tainted after resume (QCA9377/hw1.0/TF2.1-firmware-v6)

Hello everyone, this happens on 4.20.7 (Arch Linux) with ath10k/QCA9377/hw1.0/TF2.1/firmware-6.bin (WLAN.TF.2.1-00021-QCARMSWP-1) while suspending to RAM and resuming. It doesn't break functionality (reconnection works), but it doesn't look good in the logs. Regards, Tobias Predel [

[PATCH] ath10k: Fix descriptor size in ce tx completion for WCN3990

When the driver receives the tx completion of the descriptor over ce, it clears the nbytes configured for that particular descriptor. WCN3990 uses ce descriptors with 64-bit address. Currently during handling the tx completion of the descriptors, the nbytes are accessed from the descriptors using

Re: [PATCH v2] ath10k: add dynamic vlan support

Manikanta Pubbisetty wrote: > Multicast/broadcast traffic destined for a particular vlan group will > always be encrypted in software. To enable dynamic VLANs, it requires > driver support for sending software encrypted packets. > > In ath10k, sending software encrypted frames is allowed only

Re: [PATCH] ath10k: Add support to configure ftm responder role

Pradeep Kumar Chitrapu wrote: > Configure fine timing measurement (FTM) responder role from the > ftm_responder bss param sent by mac80211. With FTM functionality offloaded > to firmware, adding the interface allows userspace to enable or disable > FTM responder functionality. ath10k disables it

Re: [PATCH] ath10k: report tx airtime provided by fw

Manikanta Pubbisetty wrote: > If supported, update transmit airtime in mac80211 with the airtime > values reported by the firmware. TX airtime of the PPDU is reported > via HTT data TX completion indication message. > > A new service flag 'WMI_SERVICE_REPORT_AIRTIME' is added to advertise > the

Re: [PATCH v6 4/4] ath10k: reporting estimated tx airtime for fairness

Toke Høiland-Jørgensen wrote: > The airtime of a transmitted frame will be estimated from last used tx rate > which the firmware reports with the peer stats feature > (WMI_SERVICE_PEER_STATS). The airtime is computed on the tx path and it > will be reported to mac80211 upon tx completion. > >

[PATCH 1/6] ath10k: add missing values to wmi_service_name()

After implementing the next patch GCC reported: drivers/net/wireless/ath/ath10k/wmi.h:385:2: warning: enumeration value 'WMI_SERVICE_BTCOEX' not handled in switch [-Wswitch] drivers/net/wireless/ath/ath10k/wmi.h:385:2: warning: enumeration value 'WMI_SERVICE_MGMT_TX_WMI' not handled in switch

[PATCH 4/6] ath10k: align ath10k_htt_txbuf structures

With W=1 GCC warns: drivers/net/wireless/ath/ath10k/htt.h:1746:1: warning: alignment 1 of 'struct ath10k_htt_txbuf_32' is less than 4 [-Wpacked-not-aligned] drivers/net/wireless/ath/ath10k/htt.h:1753:1: warning: alignment 1 of 'struct ath10k_htt_txbuf_64' is less than 4 [-Wpacked-not-aligned]

[PATCH 2/6] ath10k: make wmi_service_name() warn about missing service ids

When adding a new value to enum wmi_service it's very easy to miss that the new value should be also added to wmi_service_name() mapping function. Modify the function so that GCC can now warn about this: drivers/net/wireless/ath/ath10k/wmi.h:385:2: warning: enumeration value 'WMI_SERVICE_FOO'

[PATCH 6/6] ath10k: copy the whole struct ath10k_bus_params in ath10k_core_register()

Instead of copying fields one by one copy the whole structure. This way there's no need to modify the function every time we add a new field to the struct. Compile tested only. Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH 5/6] ath10k: fix documentation in ath10k_wow_convert_8023_to_80211()

With W=1 there's a warning: drivers/net/wireless/ath/ath10k/wow.c:93: warning: Function parameter or member 'new' not described in 'ath10k_wow_convert_8023_to_80211' drivers/net/wireless/ath/ath10k/wow.c:93: warning: Function parameter or member 'old' not described in

Re: [PATCH 1/2] ath10k: Assign 'n_cipher_suites = 11' for WCN3990 to enable WPA3

Abhishek Ambure wrote: > Hostapd uses CCMP, GCMP & GCMP-256 as 'wpa_pairwise' option to run WPA3. > In WCN3990 firmware cipher suite numbers 9 to 11 are for CCMP, > GCMP & GCMP-256. > > To enable CCMP, GCMP & GCMP-256 cipher suites in WCN3990 firmware, > host sets 'n_cipher_suites = 11' while

Re: [PATCH v2] ath10k: implement set_base_macaddr to fix rx-bssid mask in multiple APs conf

Christian Lamparter wrote: > Many integrated QCA9984 WiFis in various IPQ806x platform routers > from various vendors (Netgear R7800, ZyXEL NBG6817, TP-LINK C2600, > etc.) have either blank, bogus or non-unique MAC-addresses in > their calibration data. > > As a result, OpenWrt utilizes a

Re: [PATCH v3 1/3] ath10k: Enable bus layer suspend/resume for WCN3990

Govind Singh wrote: > Register snoc bus layer suspend/resume PM ops and configure > the wakeup source(CE2) for the device. > > Testing: > Tested on WCN3990 HW. > Tested FW: WLAN.HL.2.0-01192-QCAHLSWMTPLZ-1. > > Signed-off-by: Govind Singh > Signed-off-by: Kalle Valo 3 patches

Re: [PATCH] ath10k: pci: use mutex for diagnostic window CE polling

Brian Norris wrote: > The DIAG copy engine is only used via polling, but it holds a spinlock > with softirqs disabled. Each iteration of our read/write loops can > theoretically take 20ms (two 10ms timeout loops), and this loop can be > run an unbounded number of times while holding the spinlock

Re: [PATCH] ath10k: Enable Factory Test Mode for WCN3990

Rakesh Pillai wrote: > The support to put WCN3990 firmware into Factory > test mode is not present currently. The WCN3990 > firmware can operate in Factory test mode based > on the mode it receives in the wlan enable message > from the host driver. > > When the host driver is started in

Re: [PATCH] ath10k: Fix shadow register implementation for WCN3990

Rakesh Pillai wrote: > WCN3990 supports shadow registers write operation support > for copy engine for regular operation in powersave mode. > > Since WCN3990 is a 64-bit target, the shadow register > implementation needs to be done in the copy engine handlers > for 64-bit target. Currently the