Can't parse chan info event return from firmware 10.2.4-1.0-00043

2019-02-21 Thread Steve Brown
I get "ath10k_pci :03:00.0: failed to parse chan info event: -71" when scanning. After some instrumentation, the return is 7 words and the event structure size is 13 words. This causes the error. As only the first 6 words are recovered, it's not clear if the problem is the size of the event

Re: [PATCH v2 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips

2019-02-21 Thread Ben Greear
On 2/21/19 8:37 AM, Toke Høiland-Jørgensen wrote: Ben Greear writes: On 2/21/19 8:10 AM, Kalle Valo wrote: Toke Høiland-Jørgensen writes: Grant Grundler writes: On Thu, Sep 6, 2018 at 3:18 AM Toke Høiland-Jørgensen wrote: Grant Grundler writes: And, well, Grant's data is from a

Re: [PATCH v2 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips

2019-02-21 Thread Toke Høiland-Jørgensen
Ben Greear writes: > On 2/21/19 8:37 AM, Toke Høiland-Jørgensen wrote: >> Ben Greear writes: >> >>> On 2/21/19 8:10 AM, Kalle Valo wrote: Toke Høiland-Jørgensen writes: > Grant Grundler writes: > >> On Thu, Sep 6, 2018 at 3:18 AM Toke Høiland-Jørgensen >> wrote:

[PATCH 4/4] ath10k: don't report unset rssi values to mac80211

2019-02-21 Thread Kalle Valo
From: Alagu Sankar The SDIO firmware does not provide RSSI value to the host, it's only set to zero. In that case don't report the value to mac80211. One risk here is that value zero might be a valid value with other firmware, currently there's no way to detect that. Without the fix, the rssi

[PATCH 3/4] ath10k: sdio: reset chip on power_down()

2019-02-21 Thread Kalle Valo
From: Wen Gong The target device needs to be reset during power_down(), otherwise only the first power_up() will work. And as ath10k calls power_up() during driver initialisation the driver would be otherwise unusable. Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-5-QCARMSWP-1.

[PATCH 2/4] ath10k: sdio: disable fwlog prints

2019-02-21 Thread Kalle Valo
From: Alagu Sankar The SDIO firmware may turn it on based on scratch registers so disable the firmware log to avoid that. Co-developed-by: Wen Gong Signed-off-by: Alagu Sankar Signed-off-by: Wen Gong Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.c | 7 +++ 1 file

[PATCH 1/4] ath10k: sdio: set hi_acs_flags

2019-02-21 Thread Kalle Valo
From: Alagu Sankar The SDIO firmware does not allow transmitting packets with the reduced tx completion HI_ACS option. SDIO firmware uses 1544 as alternate credit size, which is not big enough for the maximum sized mac80211 frames. Disable both these HI_ACS flags for SDIO. Co-developed-by: Wen

Re: [PATCH v2 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips

2019-02-21 Thread Ben Greear
On 2/21/19 8:10 AM, Kalle Valo wrote: Toke Høiland-Jørgensen writes: Grant Grundler writes: On Thu, Sep 6, 2018 at 3:18 AM Toke Høiland-Jørgensen wrote: Grant Grundler writes: And, well, Grant's data is from a single test in a noisy environment where the time series graph shows that

[PATCH 0/4] ath10k: small fixes for SDIO support

2019-02-21 Thread Kalle Valo
Wen has refactored some of the Alagu's fixes and wrote one of his own. I then cleaned up the commit logs. Alagu Sankar (3): ath10k: sdio: set hi_acs_flags ath10k: sdio: disable fwlog prints ath10k: don't report unset rssi values to mac80211 Wen Gong (1): ath10k: sdio: reset chip on

[PATCH] mac80211: Change default tx_sk_pacing_shift to 7

2019-02-21 Thread Toke Høiland-Jørgensen
When we did the original tests for the optimal value of sk_pacing_shift, we came up with 6 ms of buffering as the default. Sadly, 6 is not a power of two, so when picking the shift value I erred on the size of less buffering and picked 4 ms instead of 8. This was probably wrong; those 2 ms of

RE: [BUG] ath10k firmware crash 100% recreated this way

2019-02-21 Thread Chaoxing Lin
Hello ath10k firmware maintainers, What I describe is just a definite way to crash ath10k firmware. It does NOT mean that the firmware crash only happens in such scenario. I saw firmware crash once a while. Is there a plan to fix the firmware crash issue? If not, is it possible to get ath10k

Re: [PATCH v2 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips

2019-02-21 Thread Toke Høiland-Jørgensen
Ben Greear writes: > On 2/21/19 8:10 AM, Kalle Valo wrote: >> Toke Høiland-Jørgensen writes: >> >>> Grant Grundler writes: >>> On Thu, Sep 6, 2018 at 3:18 AM Toke Høiland-Jørgensen wrote: > > Grant Grundler writes: > >>> And, well, Grant's data is from a single test in

Re: [PATCH v2 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips

2019-02-21 Thread Toke Høiland-Jørgensen
Grant Grundler writes: > On Thu, Sep 6, 2018 at 3:18 AM Toke Høiland-Jørgensen wrote: >> >> Grant Grundler writes: >> >> >> And, well, Grant's data is from a single test in a noisy >> >> environment where the time series graph shows that throughput is all over >> >> the place for the duration

Re: [PATCH v2 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips

2019-02-21 Thread Kalle Valo
Toke Høiland-Jørgensen writes: > Grant Grundler writes: > >> On Thu, Sep 6, 2018 at 3:18 AM Toke Høiland-Jørgensen wrote: >>> >>> Grant Grundler writes: >>> >>> >> And, well, Grant's data is from a single test in a noisy >>> >> environment where the time series graph shows that throughput is

[PATCH 4/4] ath10k: Fix the wrong calculation ht_idx and idx of rate table for tx_stats

2019-02-21 Thread Surabhi Vishnoi
ht_idx (ht rate index) and idx (rate table index) are calculated based on mcs index. This mcs index used in the above calculation should be 0-9 for getting the correct ht_idx and idx. Currently the mcs index used for the above calculations is mcs index which can be 0-31 (in case of HT), leading

[PATCH 3/4] ath10k: Fix the wrong updation of SGI in tx_stats debugfs

2019-02-21 Thread Surabhi Vishnoi
The SGI is updated wrongly in tx stats table in debugfs per sta entry. To know whether the packets/bytes are sent with SHORT GI, test whether the SGI bit(ATH10K_RATE_INFO_FLAGS_SGI_BIT) is set or not in the txrate flags. Tested HW: WCN3990 Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1 Fixes:

[PATCH 2/4] ath10k: Fix the wrong updation of BW in tx_stats debugfs entry

2019-02-21 Thread Surabhi Vishnoi
Currently, the bandwidth is updated wrongly in BW table in tx_stats debugfs per sta as there is difference in number of bandwidth type in mac80211 and driver stats table. This leads to bandwidth getting updated at wrong index in bandwidth table in tx_stats. Fix this index mismatch between

[PATCH 1/4] ath10k: Fix the incorrect updation of NSS data in tx stats

2019-02-21 Thread Surabhi Vishnoi
The NSS data is updated incorrectly in the tx stats as the array indexing starts from zero. Fix the incorrect updation of NSS data in tx_stats by taking into consideration the array index starting from zero. Tested HW: WCN3990 Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1 Fixes: a904417fc876

[PATCH 0/4] Fix inconsistencies observed in population of tx_stats in debugfs

2019-02-21 Thread Surabhi Vishnoi
There are some inconsistencies observed while filling various peer tx stats in tx_stats debugfs entry per sta. This patchset fixes the wrong updation of NSS, SGI, Bandwidth and rate_table in tx_stats debugfs entry per sta. Surabhi Vishnoi (4): ath10k: Fix the incorrect updation of NSS data

[PATCH v3] iw: Add support for controlling tx power for per station

2019-02-21 Thread Balaji Pothunoori
From: Ashok Raj Nagarajan This patch allows userspace to set transmit power, in dBm units, to a station associated to the AP. To set a limit tx power of 20 dBm: iw wlan0 station set txpwr limit 20 To revert the user defined tx power for a station: iw wlan0 station set txpwr auto

[PATCH v3 3/3] ath10k: add support for controlling tx power to a station

2019-02-21 Thread Balaji Pothunoori
From: Ashok Raj Nagarajan This patch will add the support to control the transmit power for traffic to a station associated with the AP. Underlying firmware will enforce that the maximum tx power will be based on the regulatory requirements. If the user given transmit power is greater than the

[PATCH v3 1/3] cfg80211: Add support to set tx power for a station associated

2019-02-21 Thread Balaji Pothunoori
From: Ashok Raj Nagarajan This patch adds support to set transmit power setting type and transmit power level attributes to NL80211_CMD_SET_STATION in order to facilitate adjusting the transmit power level of a station associated to the AP. The added attributes allow selection of automatic and

[PATCH v3 2/3] mac80211: store tx power value from user to station

2019-02-21 Thread Balaji Pothunoori
From: Ashok Raj Nagarajan This patch introduce a new driver callback drv_sta_set_txpwr. This API will copy the transmit power value passed from user space and call the driver callback to set the tx power for the station. Co-developed-by: Balaji Pothunoori Signed-off-by: Ashok Raj Nagarajan

Re: ACS scans not returning noise floor

2019-02-21 Thread Justin Capella
My apologies, I left out the important bit of the debug logs [ 1265.917324] ath10k_warn: 61 callbacks suppressed [ 1265.917330] ath10k_pci :01:00.0: failed to parse chan info event: -71 Possibly also relevant, i'm using country "US" I am aware that the fcc crda/regdom wasn't supported, but

[PATCHv2 6/9] mac80211: Add api to support configuring TID specific configuration

2019-02-21 Thread Tamizh chelvam
Implement drv_set_tid_config api to allow TID specific configuration. This per-TID configuration will be applied for all the connected stations when MAC is NULL. Signed-off-by: Tamizh chelvam --- include/net/mac80211.h| 35 +++ net/mac80211/cfg.c| 28

[PATCHv2 9/9] ath10k: Add extended TID configuration support

2019-02-21 Thread Tamizh chelvam
This patch extend TID configuration support to configure RTS_CTS control and TX rate limit. Tx rate limit is similar to auto rate but it will be limited to the user configured rate mask rather than the station's highest supported rate mask. Here ext_tid_cfg_bitmap added to notify the target which

[PATCHv2 7/9] ath10k: Add wmi command support for station specific TID config

2019-02-21 Thread Tamizh chelvam
This patch adds WMI interface to configure station specific TID configuration . Host needs to send station's MAC address along with TID number and its configuration to target through WMI_10_4_PER_PEER_PER_TID_CONFIG_CMDID. WMI_SERVICE_PEER_TID_CONFIGS_SUPPORT flag is added to advertise this

[PATCHv2 3/9] nl80211: Add netlink attribute for AMPDU aggregation enable/disable

2019-02-21 Thread Tamizh chelvam
Introduce NL80211_ATTR_TID_CONFIG_AMPDU_CTRL in nl80211_attr_tid_config to accept TID specific AMPDU aggregation enable/disable configuration through NL80211_CMD_SET_TID_CONFIG command. TID for which the aggregation control configuration is to be applied is passed in NL80211_ATTR_TID_CONFIG_TID

[PATCHv2 2/9] nl80211: Add new netlink attribute for TID speicific retry count

2019-02-21 Thread Tamizh chelvam
This patch introduced below NL attributes to add support for configuring data TID specific retry count NL80211_ATTR_TID_CONFIG_RETRY NL80211_ATTR_TID_CONFIG_RETRY_LONG NL80211_ATTR_TID_CONFIG_RETRY_SHORT These attributes are added in NL80211_ATTR_TID_CONFIG nested attribute. This will be useful

[PATCHv2 0/9] cfg80211/mac80211: Add support for TID specific configuration

2019-02-21 Thread Tamizh chelvam
Add infrastructure to support per TID configurations like noack policy, retry count, AMPDU control(disable/enable), RTSCTS control(enable/disable) and TX rate mask configurations. This will be useful for the driver which can supports data TID specific configuration rather than phy level

[PATCHv2 8/9] ath10k: Add new api to support TID specific configuration

2019-02-21 Thread Tamizh chelvam
This patch add ops for set_tid_config to support TID specific configuration. STA information along with the TID config change mask to notify driver that which configuration needs to be applied for this current command. If the STA info not available in the command then the configuration will be

[PATCHv2 4/9] nl80211: Add netlink attribute to enable/disable RTS_CTS

2019-02-21 Thread Tamizh chelvam
Introduce NL80211_ATTR_TID_CONFIG_RTSCTS_CTRL in nl80211_attr_tid_config to accept TID specific RTS_CTS enable/disable configuration through NL80211_CMD_SET_TID_CONFIG command. TID for which the RTS_CTS control configuration is to be applied is passed in NL80211_ATTR_TID_CONFIG_TID attribute. When

[PATCHv2 5/9] nl80211: Add netlink attribute to configure TID specific tx rate

2019-02-21 Thread Tamizh chelvam
Introduce NL80211_ATTR_TID_CONFIG_TX_RATES in nl80211_attr_tid_config to accept data TID specific TX bitrate configuration through NL80211_CMD_SET_TID_CONFIG command. TID for which the this configuration is to be applied is passed in NL80211_ATTR_TID_CONFIG_TID attribute. TX bitrate mask values

[PATCHv2 1/9] nl80211: New netlink command for TID specific configuration

2019-02-21 Thread Tamizh chelvam
Add a new NL command, NL80211_CMD_SET_TID_CONFIG to support data TID specific configuration. This per TID configurations are passed in NL80211_ATTR_TID_CONFIG which is a nested attribute. This patch adds support to configure per TID noack policy through NL80211_ATTR_TID_CONFIG_NOACK attribute.

Re: [PATCH v2 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips

2019-02-21 Thread Toke Høiland-Jørgensen
Ben Greear writes: > On 2/21/19 9:15 AM, Toke Høiland-Jørgensen wrote: >> Ben Greear writes: >> >>> On 2/21/19 8:37 AM, Toke Høiland-Jørgensen wrote: Ben Greear writes: > On 2/21/19 8:10 AM, Kalle Valo wrote: >> Toke Høiland-Jørgensen writes: >> >>> Grant Grundler

ACS scans not returning noise floor

2019-02-21 Thread Justin Capella
I'm using the firmware from ~2 days ago, and ath10k_wmi_pull_ch_info seems to be returning -EPROTO. I have no idea what I'm doing, but I notice there is a default noise floor in one of the headers, perhaps this could be used somewhere? I'm encountering this becuase hostapd is complaining that the