Re: [PATCH v5 1/8] ath10k: adjust skb length in ath10k_sdio_mbox_rx_packet

2019-09-12 Thread Kalle Valo
Wen Gong wrote: > When the FW bundles multiple packets, pkt->act_len may be incorrect > as it refers to the first packet only (however, the FW will only > bundle packets that fit into the same pkt->alloc_len). > > Before this patch, the skb length would be set (incorrectly) to > pkt->act_len in

Re: [PATCH v5 1/8] ath10k: adjust skb length in ath10k_sdio_mbox_rx_packet

2019-09-12 Thread Kalle Valo
Wen Gong writes: > From: Nicolas Boichat > > When the FW bundles multiple packets, pkt->act_len may be incorrect > as it refers to the first packet only (however, the FW will only > bundle packets that fit into the same pkt->alloc_len). > > Before this patch, the skb length would be set

Re: [PATCH] ath10k: Fix channel info parsing for non tlv target

2019-09-12 Thread Kalle Valo
Rakesh Pillai writes: > The tlv targets such as WCN3990 send more data in > the chan info event, which is not sent by the non tlv > targets. There is a minimum size check in the wmi event for > non-tlv targets and hence we cannot update the common > channel info structure. > > If the common

Re: [PATCH] ath10k: Fix channel info parsing for non tlv target

2019-09-12 Thread Kalle Valo
Rakesh Pillai wrote: > The tlv targets such as WCN3990 send more data in the chan info event, which > is > not sent by the non tlv targets. There is a minimum size check in the wmi > event > for non-tlv targets and hence we cannot update the common channel info > structure as it was done in

Re: [PATCH] ath10k: Fix channel info parsing for non tlv target

2019-09-12 Thread Kalle Valo
Rakesh Pillai wrote: > The tlv targets such as WCN3990 send more data in the chan info event, which > is > not sent by the non tlv targets. There is a minimum size check in the wmi > event > for non-tlv targets and hence we cannot update the common channel info > structure as it was done in

Re: [PATCH v5 1/8] ath10k: adjust skb length in ath10k_sdio_mbox_rx_packet

2019-09-12 Thread Nicolas Boichat
On Thu, Sep 12, 2019 at 9:46 PM Kalle Valo wrote: > > Wen Gong writes: > > > From: Nicolas Boichat > [...] > > I simplified the error handling in this function to follow the ath10k > style, please check carefully that I didn't create any bugs: > >

Re: [PATCH v5 0/8] ath10k: improve throughout of tcp/udp TX/RX of sdio

2019-09-12 Thread Kalle Valo
Kalle Valo writes: > Wen Gong writes: > >> The bottleneck of throughout on sdio chip is the bus bandwidth, to the >> patches are all to increase the use ratio of sdio bus. >> >> udp-rxudp-txtcp-rxtcp-tx >> without patches(Mbps) 320180 170

Re: [PATCH v5 0/8] ath10k: improve throughout of tcp/udp TX/RX of sdio

2019-09-12 Thread Kalle Valo
Wen Gong writes: > The bottleneck of throughout on sdio chip is the bus bandwidth, to the > patches are all to increase the use ratio of sdio bus. > > udp-rxudp-txtcp-rxtcp-tx > without patches(Mbps) 320180 170 151 > with patches(Mbps)

Re: [PATCH v5 0/8] ath10k: improve throughout of tcp/udp TX/RX of sdio

2019-09-12 Thread Wen Gong
>>> The bottleneck of throughout on sdio chip is the bus bandwidth, to the >>>patches are all to increase the use ratio of sdio bus. >> I tried to apply patches 2-8, patch 2 had a conflict due to my changes >> and patch 8 didn't apply at all. Also I saw few warnings with the >> patches I was