[PATCH v4 0/3] PCI: of: Load extra data only from compatible DT nodes

2023-02-03 Thread equu
From: Edward Chow In order to solve the issue reported in https://github.com/openwrt/openwrt/pull/11345 , this patchset attempt to add mechanisms to ckeck whether an OF DT node is compatible to the PCI device installed on the corresponding location or the driver for it, and make ath9k and ath10k

[PATCH v4 1/3] PCI: of: Match pci devices or drivers against OF DT nodes

2023-02-03 Thread equu
From: Edward Chow Currently, whether a compatibility string within an OF DT node for a PCI device (whose spec is at https://www.devicetree.org/open-firmware/bindings/pci/ ) matches the vendor and device id of either the PCI device installed on the corresponding location or the driver suggested

[PATCH v4 2/3] wifi: ath9k: stop loading incompatible DT cal data

2023-02-03 Thread equu
From: Edward Chow As reported in https://github.com/openwrt/openwrt/pull/11345 , ath9k would load calibration data from a device tree node declared incompatible. Now, ath9k will first check whether the device tree node is compatible with it, using the functionality introduced with the first

[PATCH v4 3/3] wifi: ath10k: only load compatible DT cal data

2023-02-03 Thread equu
From: Edward Chow ath10k might also be sensitive to the issue reported on https://github.com/openwrt/openwrt/pull/11345 , loading calibration data from a device tree node declared incompatible. ath10k will first check whether the device tree node is compatible with it, using the functionality

Re: [PATCH v3 2/3] wifi: ath9k: stop loading incompatible DT cal data

2023-02-03 Thread kernel test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on helgaas-pci/next] [also build test ERROR on helgaas-pci/for-linus wireless-next/main wireless/main linus/master v6.2-rc6 next-20230203] [If your patch is applied to the wrong git tree, kindly drop us a note

Re: [PATCH v3 3/3] wifi: ath10k: only load compatible DT cal data

2023-02-03 Thread kernel test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on helgaas-pci/next] [also build test ERROR on helgaas-pci/for-linus wireless-next/main wireless/main linus/master v6.2-rc6 next-20230203] [If your patch is applied to the wrong git tree, kindly drop us a note

Re: [PATCH v3 1/3] PCI: of: Match pci devices or drivers against OF DT nodes

2023-02-03 Thread kernel test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on helgaas-pci/next] [also build test ERROR on helgaas-pci/for-linus wireless-next/main wireless/main linus/master v6.2-rc6 next-20230203] [If your patch is applied to the wrong git tree, kindly drop us a note

[PATCH v5 2/3] wifi: ath9k: stop loading incompatible DT cal data

2023-02-03 Thread equu
From: Edward Chow As reported in https://github.com/openwrt/openwrt/pull/11345 , ath9k would load calibration data from a device tree node declared incompatible. Now, ath9k will first check whether the device tree node is compatible with it, using the functionality introduced with the first

[PATCH v5 3/3] wifi: ath10k: only load compatible DT cal data

2023-02-03 Thread equu
From: Edward Chow ath10k might also be sensitive to the issue reported on https://github.com/openwrt/openwrt/pull/11345 , loading calibration data from a device tree node declared incompatible. ath10k will first check whether the device tree node is compatible with it, using the functionality

[PATCH v5 1/3] PCI: of: Match pci devices or drivers against OF DT nodes

2023-02-03 Thread equu
From: Edward Chow Currently, whether a compatibility string within an OF DT node for a PCI device (whose spec is at https://www.devicetree.org/open-firmware/bindings/pci/ ) matches the vendor and device id of either the PCI device installed on the corresponding location or the driver suggested

[PATCH v5 0/3] PCI: of: Load extra data only from compatible DT nodes

2023-02-03 Thread equu
From: Edward Chow In order to solve the issue reported in https://github.com/openwrt/openwrt/pull/11345 , this patchset attempt to add mechanisms to ckeck whether an OF DT node is compatible to the PCI device installed on the corresponding location or the driver for it, and make ath9k and ath10k

Re: [PATCH v5 3/3] wifi: ath10k: only load compatible DT cal data

2023-02-03 Thread Rob Herring
On Fri, Feb 3, 2023 at 4:48 AM wrote: > > From: Edward Chow > > ath10k might also be sensitive to the issue reported on > https://github.com/openwrt/openwrt/pull/11345 , loading calibration > data from a device tree node declared incompatible. > > ath10k will first check whether the device tree

Re: [PATCH v5 3/3] wifi: ath10k: only load compatible DT cal data

2023-02-03 Thread equu
> I think this can be done a bit cleaner and like other drivers. I see 2 > options. > The first way is use VID/PID compatible strings and don't set the > of_node pointer if there is a mismatch. Where should I do this? In pci_set_of_node() from drivers/pci/of.c? > Upon further thought, why can't

Re: [PATCH] firmware: qcom_scm: Move qcom_scm.h to include/linux/firmware/qcom/

2023-02-03 Thread Guru Das Srinagesh
On Feb 03 2023 13:09, Elliot Berman wrote: > Move include/linux/qcom_scm.h to include/linux/firmware/qcom/qcom_scm.h. > This removes 1 of a few remaining Qualcomm-specific headers into a more > approciate subdirectory under include/. > > Suggested-by: Bjorn Andersson > Signed-off-by: Elliot

Re: [PATCH v5 3/3] wifi: ath10k: only load compatible DT cal data

2023-02-03 Thread Rob Herring
On Fri, Feb 3, 2023 at 11:15 AM wrote: > > > I think this can be done a bit cleaner and like other drivers. I see 2 > > options. > > The first way is use VID/PID compatible strings and don't set the > > of_node pointer if there is a mismatch. > Where should I do this? In pci_set_of_node() from

[PATCH] firmware: qcom_scm: Move qcom_scm.h to include/linux/firmware/qcom/

2023-02-03 Thread Elliot Berman
Move include/linux/qcom_scm.h to include/linux/firmware/qcom/qcom_scm.h. This removes 1 of a few remaining Qualcomm-specific headers into a more approciate subdirectory under include/. Suggested-by: Bjorn Andersson Signed-off-by: Elliot Berman --- arch/arm/mach-qcom/platsmp.c

Re: [PATCH v5 3/3] wifi: ath10k: only load compatible DT cal data

2023-02-03 Thread equu
> >>> Upon further thought, why can't you decide all this just on PCI >>> VID/PID? The giant switch statement in ath10k_pci_probe() could all >>> just be struct of driver_data from the PCI match table. >> I cannot decide all this just on PCI VID/PID because PCI VID/PID cannot tell >> whether