[PATCH] ath10k: add option for chip-id based BDF selection

d=320' Signed-off-by: Abhishek Kumar --- drivers/net/wireless/ath/ath10k/core.c | 45 +++--- 1 file changed, 34 insertions(+), 11 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c index a3f15cc89a10..767bb9d6a

Re: [PATCH] ath10k: add option for chip-id based BDF selection

Additionally tested on ath10k based non-QMI platform Tested-on: QCA6174 HW3.2 WLAN.RM.4.4.1-00157-QCARMSWPZ-1 Tested-by: Abhishek Kumar -Abhishek ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [RFC 1/2] nl80211: add common API to configure SAR power limitations.

From: kua...@chromium.org These patches do not apply cleanly on kernel 5.4. I fixed the merged conflicts and verified. I verified these APIs using power_manager in chromeos, the APIs works fine. Tested-by: Abhishek Kumar -Abhishek ___ ath10k mailing

Re: [RFC 1/2] nl80211: add common API to configure SAR power limitations.

From: kua...@chromium.org There are few more additional comments here. > + * @NL80211_CMD_SET_SAR_SPECS: SAR power limitation configuration is > + * ?? ?? passed using %NL80211_ATTR_SAR_SPEC. > + * This command requires NL80211_ATTR_IFINDEX, probably should be better to add this in the comment ?

Re: [RFC 1/2] nl80211: add common API to configure SAR power limitations.

On Tue, Nov 3, 2020 at 5:15 AM Johannes Berg wrote: > > On Tue, 2020-11-03 at 10:34 +0800, Carl Huang wrote: > > On 2020-10-31 10:46, Abhishek Kumar wrote: > > > From: kua...@chromium.org > > > > > > There are few more additional comments here. > >

Re: [PATCH] ath10k: add option for chip-id based BDF selection

Apologies for the delay, was busy so could not work on V2 . I have started working on V2 patch. Will upload by today/tomorrow. Abhishek On Thu, Nov 5, 2020 at 11:11 PM Kalle Valo wrote: > > Abhishek Kumar wrote: > > > In some devices difference in chip-id should be enough

[PATCH v2 0/1] This patch address comments on patch v1

This patch extends ath10k_core_create_board_name function to support chip id based BDF selection and not add provision for fallback_boardname2, thus introducing lesser lines of code. (no changes since v1) Abhishek Kumar (1): ath10k: add option for chip-id based BDF selection drivers/net

[PATCH v2 1/1] ath10k: add option for chip-id based BDF selection

d=320' Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2-00696-QCAHLSWMTPL-1 Tested-on: QCA6174 HW3.2 WLAN.RM.4.4.1-00157-QCARMSWPZ-1 Signed-off-by: Abhishek Kumar --- (no changes since v1) drivers/net/wireless/ath/ath10k/core.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-)

Re: [PATCH v2] ath10k: Fix the parsing error in service available event

Hi All, The V2 patch now has good comments and probably spinning off a new V3 might be a good idea. Here are a few comments to the discussion. In response to Doug's comment > case WMI_TLV_TAG_FIRST_ARRAY_ENUM: > arg->service_map_ext_len = 0; > arg->service_map_ext = NULL; > return 0; Since

Re: [PATCH v3] ath10k: Fix the parsing error in service available event

Hi, The patch LGTM there is small nit, though. > +++ b/drivers/net/wireless/ath/ath10k/wmi.c > @@ -5751,8 +5751,13 @@ void ath10k_wmi_event_service_available(struct ath10k > *ar, struct sk_buff *skb) > ret); > } > > - ath10k_wmi_map_svc_ext(ar, arg.servic

Re: [PATCH 3/3] ath10k: allow dynamic SAR power limits via common API

Hi, This patch looks good to me, there is one small nit, If the maintainer can take care of it then probably we don't need a new rev. > @@ -329,6 +336,7 @@ static const struct ath10k_hw_params > ath10k_hw_params_list[] = { > .fw_diag_ce_download = true, > .tx_stats

Re: [PATCH 1/3] nl80211: add common API to configure SAR power limitations.

Hi, Johannes has some good comments, apart for that I have some nits. > > And wait, I thought we agreed to remove the index? Now I'm confused. > > > Using index in SET operation doesn't add burden to userspace and kernel, > but it provides some flexibility so userspace can skip some certain > rang

Re: [PATCH v2 1/3] nl80211: add common API to configure SAR power limitations.

s other comment that it might be made more clear in comment. If at all a V3 is needed, then we should add that, or else it looks fine. Reviewed-by: Abhishek Kumar Thanks Abhishek On Mon, Nov 30, 2020 at 2:10 AM Carl Huang wrote: > > On 2020-11-21 10:42, Brian Norris wrote: > >

Re: [PATCH v2 2/3] mac80211: add ieee80211_set_sar_specs

Changes LGTM, Reviewed-by: Abhishek Kumar Thanks Abhishek On Fri, Nov 20, 2020 at 12:54 AM Carl Huang wrote: > > This change registers ieee80211_set_sar_specs to > mac80211_config_ops, so cfg80211 can call it. > > Signed-off-by: Carl Huang > --- > v2: > - rebased

Re: [PATCH v2 1/1] ath10k: add option for chip-id based BDF selection

Hi, > > (no changes since v1) > > I think you need to work on the method you're using to generate your > patches. There are most definitely changes since v1. You described > them in your cover letter (which you don't really need for a singleton > patch) instead of here. I agree, this was not int

[PATCH v3] ath10k: add option for chip-id based BDF selection

d=320' Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2-00696-QCAHLSWMTPL-1 Tested-on: QCA6174 HW3.2 WLAN.RM.4.4.1-00157-QCARMSWPZ-1 Signed-off-by: Abhishek Kumar --- Changes in v3: - Resurreted Patch V1 because as per discussion we do need two fallback board names and

Re: [PATCH 3/3] ath10k: Set wiphy flag to trigger sta disconnect on hardware restart

On Tue, Dec 15, 2020 at 9:24 AM Youghandhar Chintala wrote: > > From: Rakesh Pillai > > Currently after the hardware restart triggered from the driver, > the station interface connection remains intact, since a disconnect > trigger is not sent to userspace. This can lead to a problem in > hardwar

Re: [PATCH 3/3] ath10k: Set wiphy flag to trigger sta disconnect on hardware restart

ws are, or atleast what are the challenges. As you said the task is much bigger with so many firmware branches. As long as you feel it is scalable for coming years, we should be good. As far as the patch is concerned, it LGTM. Reviewed-by: Abhishek Kumar Thanks Abhishek ___

Re: [PATCH v3] ath10k: skip the wait for completion to recovery in shutdown path

This patch seems to address the comments on v2. Overall this patch LGTM. Reviewed-by: Abhishek Kumar On Tue, Feb 23, 2021 at 6:29 AM Youghandhar Chintala wrote: > > Currently in the shutdown callback we wait for recovery to complete > before freeing up the resources. This results in a

[PATCH] ath10k: remove unused variable in ath10k_htt_rx_h_frag_pn_check

The local variable more_frags in ath10k_htt_rx_h_frag_pn_check is not used. This patch is to remove that. Fixes: a1166b2653db ("ath10k: add CCMP PN replay protection for fragmented frames for PCIe") Signed-off-by: Abhishek Kumar --- drivers/net/wireless/ath/ath10k/htt_rx.c | 2

Re: [PATCH] ath10k: Don't always treat modem stop events as crashes

rated solution only), I can expect if SNOC is enabled, remote proc will be enabled as well, so it should be fine. Reviewed-by: Abhishek Kumar On Tue, Sep 7, 2021 at 12:48 PM Stephen Boyd wrote: > > Quoting Matthias Kaehlcke (2021-09-07 12:32:59) > > On Sun, Sep 05, 2021 at 02:04

[PATCH] ath10k: enable threaded napi on ath10k driver

Signed-off-by: Abhishek Kumar --- drivers/net/wireless/ath/ath10k/pci.c | 1 + drivers/net/wireless/ath/ath10k/sdio.c | 1 + drivers/net/wireless/ath/ath10k/snoc.c | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath

Re: [PATCH] ath10k: enable threaded napi on ath10k driver

. If we come to a consensus with this as the best approach to enable threaded NAPI on ath10k, then we can moved ahead with the implementation and enable across sdio and pci, or if there is any objection then we can discuss it here. Thanks Abhishek On Tue, Dec 14, 2021 at 2:41 PM Abhishek Kumar

[PATCH 1/2] ath10k: search for default BDF name provided in DT

CN3990 hw1.0 SNOC WLAN.HL.3.2.2-00696-QCAHLSWMTPL-1 Signed-off-by: Abhishek Kumar --- drivers/net/wireless/ath/ath10k/core.c | 30 ++ drivers/net/wireless/ath/ath10k/core.h | 5 + drivers/net/wireless/ath/ath10k/qmi.c | 4 3 files changed, 39 insertions(+)

[PATCH v2 1/2] ath10k: search for default BDF name provided in DT

CN3990 hw1.0 SNOC WLAN.HL.3.2.2-00696-QCAHLSWMTPL-1 Signed-off-by: Abhishek Kumar --- Changes in v2: Fix printf formatting issue. drivers/net/wireless/ath/ath10k/core.c | 30 ++ drivers/net/wireless/ath/ath10k/core.h | 5 + drivers/net/wireless/ath/ath10k/qmi.c | 4

[PATCH v2 2/2] dt: bindings: add dt entry for ath10k default BDF name

the combinations (board-id,chip-id,variant) match. To address the above concern provide an optional proptery: qcom,ath10k-default-bdf Signed-off-by: Abhishek Kumar --- Changes in v2: - Changes in v2: none .../devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 1 file changed, 4

Re: [PATCH v2 1/2] ath10k: search for default BDF name provided in DT

drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: > https://github.com/0day-ci/linux/commits/Abhishek-Kumar/ath10k-search-for-default-BDF-name-provided-in-DT/20220111-071636 >

Re: [PATCH v2 1/2] ath10k: search for default BDF name provided in DT

On Mon, Jan 10, 2022 at 4:51 PM Doug Anderson wrote: > > Hi, > > On Mon, Jan 10, 2022 at 3:15 PM Abhishek Kumar wrote: > > > > +int ath10k_core_parse_default_bdf_dt(struct ath10k *ar) > > +{ > > + struct device_node *node; > > + const cha

Re: [PATCH 1/2] ath10k: search for default BDF name provided in DT

id=ff then we would pick any BDF that match 'bus=snoc,qmi-board-id=' where XX can be any arbitrary number. Thoughts ? -Abhishek On Thu, Mar 10, 2022 at 4:28 PM Doug Anderson wrote: > > Hi, > > On Thu, Mar 10, 2022 at 2:06 AM Kalle Valo wrote: > > > > Doug Anderson

Re: [PATCH 1/2] ath10k: search for default BDF name provided in DT

On Tue, Apr 12, 2022 at 3:47 AM Kalle Valo wrote: > > Abhishek Kumar writes: > > > Hi All, > > > > Apologies for the late reply, too many things at the same time. > > Trust me, I know the feeling :) > > > Just a quick note, Qcomm provided a new BDF fil

[PATCH] ath10k: skip ath10k_halt during suspend for driver state RESTARTING

541] worker_thread+0x213/0x372 [ 428.469547] kthread+0x150/0x15f [ 428.469552] ? pr_cont_work+0x58/0x58 [ 428.469558] ? kthread_blkcg+0x31/0x31 Signed-off-by: Abhishek Kumar Co-developed-by: Wen Gong Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath10k/mac.c | 18 -- 1 f

Re: [PATCH] ath10k: skip ath10k_halt during suspend for driver state RESTARTING

Thanks Kalle for having a look and adding this on behalf of me. Here is the Tested-on tag, Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00288-QCARMSWPZ-1 Thanks Abhishek On Sun, Apr 24, 2022 at 11:14 PM Kalle Valo wrote: > > Abhishek Kumar writes: > > > Double free crash is o

Re: [PATCH] ath10k: skip ath10k_halt during suspend for driver state RESTARTING

On Mon, Apr 25, 2022 at 4:13 PM Brian Norris wrote: > > On Mon, Apr 25, 2022 at 04:11:44PM -0700, Brian Norris wrote: > > On Mon, Apr 25, 2022 at 02:15:20AM +0000, Abhishek Kumar wrote: > > > --- a/drivers/net/wireless/ath/ath10k/mac.c > > > +++ b/drivers

[PATCH v2] ath10k: skip ath10k_halt during suspend for driver state RESTARTING

541] worker_thread+0x213/0x372 [ 428.469547] kthread+0x150/0x15f [ 428.469552] ? pr_cont_work+0x58/0x58 [ 428.469558] ? kthread_blkcg+0x31/0x31 Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00288-QCARMSWPZ-1 Co-developed-by: Wen Gong Signed-off-by: Wen Gong Signed-off-by: Abhishek Kumar --- Changes in

Re: [PATCH] ath10k: skip ath10k_halt during suspend for driver state RESTARTING

Addressed all the above comments and pushed out a v2 patch. Fixes in V2: - Fixed typo, replaced ath11k by ath10k in comments. - Adjusted the position of the S-O-B tag. - Added tested on tag. Thanks Abhishek On Tue, Apr 26, 2022 at 9:23 AM Jeff Johnson wrote: > > (sorry for the 2nd message with n

Re: [PATCH v2] ath10k: skip ath10k_halt during suspend for driver state RESTARTING

On Tue, Apr 26, 2022 at 3:34 PM Brian Norris wrote: > > On Tue, Apr 26, 2022 at 3:20 PM Abhishek Kumar wrote: > > > > Double free crash is observed when FW recovery(caused by wmi > > timeout/crash) is followed by immediate suspend event. The FW recovery > > is tr

[PATCH v3] ath10k: improve BDF search fallback strategy

00754-QCAHLSWMTPL-1 Signed-off-by: Abhishek Kumar --- Changes in v3: - As discussed, instead of adding support for default BDF in DT, added a method to drop the last elements from full BDF until a BDF is found. - Previous patch was "ath10k: search for default BDF name provided in DT" drive

Re: [PATCH v3] ath10k: improve BDF search fallback strategy

llowed by reduced BDF > > names as follows: > > bus=snoc,qmi-board-id=67,qmi-chip-id=320,variant=GO_ > > bus=snoc,qmi-board-id=67,qmi-chip-id=320 > > bus=snoc,qmi-board-id=67 > > bus=snoc > > > > > > Tested-on: WCN3990/hw1.0 WLAN.HL.3.2.2.c10-00754

[PATCH] ath10k: snoc: enable threaded napi on WCN3990

: - UDP_RX increase by ~22-25% - TCP_RX increase by ~15% Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2-00696-QCAHLSWMTPL-1 Signed-off-by: Abhishek Kumar --- drivers/net/wireless/ath/ath10k/core.c | 16 drivers/net/wireless/ath/ath10k/hw.h | 2 ++ drivers/net/wireless/ath/ath10k

Re: [PATCH] ath10k: snoc: enable threaded napi on WCN3990

= tcp_tx(Without threaded NAPI) 317.34+-2.37 : Channel 44 317.01+-2.56 : Channel 157 tcp_tx(With threaded NAPI) 371.34+-2.36 : Channel 44 376.95+-9.40 : Channel 157 ======== > > On Tue, Dec 20, 2022 at 12:17 AM Abhishek Kumar wrote: &

Re: [PATCH] ath10k: snoc: enable threaded napi on WCN3990

Apologies for the late reply. Please see my response inline. On Tue, Dec 20, 2022 at 4:14 AM Manikanta Pubbisetty wrote: > > On 12/20/2022 1:25 PM, Abhishek Kumar wrote: > > NAPI poll can be done in threaded context along with soft irq > > context. Threaded context can be sch

Re: [PATCH] ath10k: snoc: enable threaded napi on WCN3990

Thanks for all the comments. I will call dev_set_threaded() directly without HW params and rollout a v2 soon. On Thu, Jan 12, 2023 at 2:15 AM Kalle Valo wrote: > > Abhishek Kumar writes: > > >> > --- a/drivers/net/wireless/ath/ath10k/snoc.c > >> > +++ b/drive

[PATCH v2] ath10k: snoc: enable threaded napi on WCN3990

: Channel 157 tcp_tx(With threaded NAPI) 371.34+-2.36 : Channel 44 376.95+-9.40 : Channel 157 === Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2-00696-QCAHLSWMTPL-1 Signed-off-by: Abhishek Kumar --- Changes in v2: - Removed the hw param checks to add

Re: [PATCH v2] ath10k: snoc: enable threaded napi on WCN3990

Hi Kale, Gentle reminder for your comments. Thanks Abhishek On Thu, Feb 2, 2023 at 4:02 PM Abhishek Kumar wrote: > > NAPI poll can be done in threaded context along with soft irq > context. Threaded context can be scheduled efficiently, thus > creating less of bottleneck during R

Re: [PATCH v2 1/2] wifi: cfg80211: Add beacon hint notifier support

On Thu, Mar 2, 2023 at 1:57 AM Youghandhar Chintala wrote: > > There are connection failures in hidden SSID case when the device is > with default reg domain WW. > For WW reg domain most of the 5 GHz channels are passive. When device > listens to the beacon on that channel, the driver is updating

[PATCH 2/2] ath10k: mac: enable WIPHY_FLAG_CHANNEL_CHANGE_ON_BEACON on ath10k

rightly changed from passive to active,the connection to hidden SSID does not fail. Signed-off-by: Abhishek Kumar --- drivers/net/wireless/ath/ath10k/mac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index

[PATCH 1/2] wifi: cfg80211: call reg_call_notifier on beacon hints

ensures that the channel property changes are visible to the vendor driver. The vendor changes the channels for active scans. This fixes the discovery issue of hidden SSID. Signed-off-by: Abhishek Kumar --- include/net/cfg80211.h | 3 +++ net/wireless/reg.c | 20 2 files