Re: [PATCH v3 1/2] pci: Add vendor id of Ubiquiti Networks

2018-01-29 Thread Bjorn Helgaas
On Thu, Jan 25, 2018 at 12:13:39PM +0100, Tobias Schramm wrote: > Signed-off-by: Tobias Schramm <toblemi...@gmail.com> Acked-by: Bjorn Helgaas <bhelg...@google.com> I see Kalle has already applied this, but if it's updated for any reason, please add my ack and change the subject

Re: [PATCH v3] PCI: Disallow retraining link for Atheros chips on non-Gen1 PCIe bridges

2021-06-16 Thread Bjorn Helgaas
On Wed, Jun 02, 2021 at 09:03:02PM +0200, Pali Rohár wrote: > On Wednesday 02 June 2021 10:55:59 Bjorn Helgaas wrote: > > On Wed, Jun 02, 2021 at 02:08:16PM +0200, Pali Rohár wrote: > > > On Tuesday 01 June 2021 19:00:36 Bjorn Helgaas wrote: > > > > > > I

Re: [PATCH v3] PCI: Disallow retraining link for Atheros chips on non-Gen1 PCIe bridges

2021-06-01 Thread Bjorn Helgaas
On Tue, Jun 01, 2021 at 11:18:39PM +0200, Pali Rohár wrote: > On Tuesday 01 June 2021 15:05:49 Bjorn Helgaas wrote: > > On Wed, May 05, 2021 at 06:33:57PM +0200, Pali Rohár wrote: > > > Atheros AR9xxx and QCA9xxx chips have behaviour issues not only after a > > > bus

Re: [PATCH v3] PCI: Disallow retraining link for Atheros chips on non-Gen1 PCIe bridges

2021-06-02 Thread Bjorn Helgaas
On Wed, Jun 02, 2021 at 02:08:16PM +0200, Pali Rohár wrote: > On Tuesday 01 June 2021 19:00:36 Bjorn Helgaas wrote: > > I wonder if this could be restructured as a generic quirk in quirks.c > > that simply set the bridge's TLS to 2.5 GT/s during enumeration. Or > > would

Re: [PATCH v3] PCI: Disallow retraining link for Atheros chips on non-Gen1 PCIe bridges

2021-06-01 Thread Bjorn Helgaas
On Wed, May 05, 2021 at 06:33:57PM +0200, Pali Rohár wrote: > Atheros AR9xxx and QCA9xxx chips have behaviour issues not only after a > bus reset, but also after doing retrain link, if PCIe bridge is not in > GEN1 mode (at 2.5 GT/s speed): > > - QCA9880 and QCA9890 chips throw a Link Down event

Re: [PATCH v3] PCI: Disallow retraining link for Atheros chips on non-Gen1 PCIe bridges

2021-06-25 Thread Bjorn Helgaas
On Mon, Jun 21, 2021 at 04:28:55PM +0200, Pali Rohár wrote: > On Wednesday 16 June 2021 16:38:19 Bjorn Helgaas wrote: > > On Wed, Jun 02, 2021 at 09:03:02PM +0200, Pali Rohár wrote: > > > On Wednesday 02 June 2021 10:55:59 Bjorn Helgaas wrote: > > > > On Wed, Jun 02,

Re: [PATCH v2 03/13] PCI/ASPM: Disable ASPM when driver requests it

2023-10-11 Thread Bjorn Helgaas
On Mon, Sep 18, 2023 at 04:10:53PM +0300, Ilpo Järvinen wrote: > PCI core/ASPM service driver allows controlling ASPM state through > pci_disable_link_state() and pci_enable_link_state() API. It was > decided earlier (see the Link below), to not allow ASPM changes when OS > does not have control

Re: [PATCH v2 04/13] PCI/ASPM: Move L0S/L1/sub states mask calculation into a helper

2023-10-11 Thread Bjorn Helgaas
On Mon, Sep 18, 2023 at 04:10:54PM +0300, Ilpo Järvinen wrote: > ASPM service driver does the same L0S / L1S / sub states allowed > calculation in __pci_disable_link_state() and > pci_set_default_link_state(). Is there a typo or something here? This patch only adds a call to

Re: [PATCH v2 03/13] PCI/ASPM: Disable ASPM when driver requests it

2023-10-26 Thread Bjorn Helgaas
On Mon, Oct 16, 2023 at 05:27:37PM +0300, Ilpo Järvinen wrote: > On Fri, 13 Oct 2023, Bjorn Helgaas wrote: > > On Thu, Oct 12, 2023 at 01:56:16PM +0300, Ilpo Järvinen wrote: > > > On Wed, 11 Oct 2023, Bjorn Helgaas wrote: > > > > On Mon, Sep 18, 2023 at 04:10:5

Re: [PATCH v2 03/13] PCI/ASPM: Disable ASPM when driver requests it

2023-10-11 Thread Bjorn Helgaas
On Mon, Sep 18, 2023 at 04:10:53PM +0300, Ilpo Järvinen wrote: > PCI core/ASPM service driver allows controlling ASPM state through > pci_disable_link_state() and pci_enable_link_state() API. It was > decided earlier (see the Link below), to not allow ASPM changes when OS > does not have control

Re: [PATCH v2 05/13] PCI/ASPM: Add pci_enable_link_state()

2023-10-11 Thread Bjorn Helgaas
On Mon, Sep 18, 2023 at 04:10:55PM +0300, Ilpo Järvinen wrote: > pci_disable_link_state() lacks a symmetric pair. Some drivers want to > disable ASPM during certain phases of their operation but then > re-enable it later on. If pci_disable_link_state() is made for the > device, there is currently

Re: [PATCH v2 05/13] PCI/ASPM: Add pci_enable_link_state()

2023-10-13 Thread Bjorn Helgaas
On Thu, Oct 12, 2023 at 03:53:39PM +0300, Ilpo Järvinen wrote: > On Wed, 11 Oct 2023, Bjorn Helgaas wrote: > > On Mon, Sep 18, 2023 at 04:10:55PM +0300, Ilpo Järvinen wrote: > > > pci_disable_link_state() lacks a symmetric pair. Some drivers want to > > > disable

Re: [PATCH v2 03/13] PCI/ASPM: Disable ASPM when driver requests it

2023-10-13 Thread Bjorn Helgaas
On Thu, Oct 12, 2023 at 01:56:16PM +0300, Ilpo Järvinen wrote: > On Wed, 11 Oct 2023, Bjorn Helgaas wrote: > > On Mon, Sep 18, 2023 at 04:10:53PM +0300, Ilpo Järvinen wrote: > > > PCI core/ASPM service driver allows controlling ASPM state through > >

Re: [PATCH 2/3] wifi: ath9k: stop loading incompatible DT cal data

2023-01-17 Thread Bjorn Helgaas
On Tue, Jan 17, 2023 at 05:27:46PM +0800, Edward Chow wrote: > Loading calibration data from an OF device tree node not declared > compatible with the device (e.g. a PCI device with calibration data > from corresponding DT node gets replaced, so the newly installed > device become incompatible

Re: [PATCH v2 9/9] wifi: ath10k: Use RMW accessors for changing LNKCTL

2023-05-26 Thread Bjorn Helgaas
On Thu, May 25, 2023 at 01:11:51PM +0300, Ilpo Järvinen wrote: > On Wed, 24 May 2023, Bjorn Helgaas wrote: > > On Wed, May 17, 2023 at 01:52:35PM +0300, Ilpo Järvinen wrote: > > > Don't assume that only the driver would be accessing LNKCTL. ASPM > > > policy changes

Re: [PATCH v2 9/9] wifi: ath10k: Use RMW accessors for changing LNKCTL

2023-05-26 Thread Bjorn Helgaas
On Fri, May 26, 2023 at 02:48:44PM +0300, Ilpo Järvinen wrote: > On Thu, 25 May 2023, Ilpo Järvinen wrote: > > On Wed, 24 May 2023, Bjorn Helgaas wrote: > > > On Wed, May 17, 2023 at 01:52:35PM +0300, Ilpo Järvinen wrote: > > > > Don't assume that only the driver w

Re: [PATCH v2 9/9] wifi: ath10k: Use RMW accessors for changing LNKCTL

2023-05-24 Thread Bjorn Helgaas
On Wed, May 17, 2023 at 01:52:35PM +0300, Ilpo Järvinen wrote: > Don't assume that only the driver would be accessing LNKCTL. ASPM > policy changes can trigger write to LNKCTL outside of driver's control. > > Use RMW capability accessors which does proper locking to avoid losing > concurrent