Re: [PATCH 1/2] mac80211: do not iterate active interfaces when in re-configure

2016-12-05 Thread Adrian Chadd
fwiw, I'm facing the same kinds of cleanup problems with my port of (oct 2015) ath10k to freebsd. The oct 2015 ath10k tree doesn't have the firmware per-txq/tid/peer feedback stuff in it, so this hasn't yet bitten me, but there rest of the races have - mostly surrounding handling pending TX

Re: [PATCH 1/2] mac80211: do not iterate active interfaces when in re-configure

2016-12-05 Thread Ben Greear
On 12/05/2016 05:52 AM, Johannes Berg wrote: On Mon, 2016-12-05 at 09:13 +0100, Michal Kazior wrote: On 2 December 2016 at 03:29, wrote: From: Ben Greear This appears to fix a problem where ath10k firmware would crash, mac80211 would

Re: [PATCH 1/2] mac80211: do not iterate active interfaces when in re-configure

2016-12-05 Thread Ben Greear
On 12/05/2016 07:00 AM, Johannes Berg wrote: On Mon, 2016-12-05 at 06:57 -0800, Ben Greear wrote: I think clearing sdata-in-driver would fix the ath10k problem, at least, but I was afraid it would break something else in mac80211 or maybe in other thick firmware drivers. It's pretty much

Re: [PATCH 1/2] mac80211: do not iterate active interfaces when in re-configure

2016-12-05 Thread Johannes Berg
On Mon, 2016-12-05 at 06:57 -0800, Ben Greear wrote: > I think clearing sdata-in-driver would fix the ath10k problem, at > least, but I was afraid it would break something else in mac80211 or > maybe in other thick firmware drivers. It's pretty much an internal thing - not sure what it'd break.

Re: [PATCH 1/2] mac80211: do not iterate active interfaces when in re-configure

2016-12-05 Thread Johannes Berg
On Mon, 2016-12-05 at 09:13 +0100, Michal Kazior wrote: > On 2 December 2016 at 03:29,   wrote: > > > > From: Ben Greear > > > > This appears to fix a problem where ath10k firmware would crash, > > mac80211 would start re-adding interfaces to

Re: [PATCH 1/2] mac80211: do not iterate active interfaces when in re-configure

2016-12-05 Thread Michal Kazior
On 2 December 2016 at 03:29, wrote: > From: Ben Greear > > This appears to fix a problem where ath10k firmware would crash, > mac80211 would start re-adding interfaces to the driver, but the > iterate-active-interfaces logic would then try to

[PATCH 1/2] mac80211: do not iterate active interfaces when in re-configure

2016-12-01 Thread greearb
From: Ben Greear This appears to fix a problem where ath10k firmware would crash, mac80211 would start re-adding interfaces to the driver, but the iterate-active-interfaces logic would then try to use the half-built interfaces. With a bit of extra debug to catch the