Re: [PATCH v2 9/9] wifi: ath10k: Use RMW accessors for changing LNKCTL

On Fri, May 26, 2023 at 02:48:44PM +0300, Ilpo Järvinen wrote: > On Thu, 25 May 2023, Ilpo Järvinen wrote: > > On Wed, 24 May 2023, Bjorn Helgaas wrote: > > > On Wed, May 17, 2023 at 01:52:35PM +0300, Ilpo Järvinen wrote: > > > > Don't assume that only the driver would be accessing LNKCTL. ASPM >

Re: [PATCH v2 9/9] wifi: ath10k: Use RMW accessors for changing LNKCTL

On Thu, May 25, 2023 at 01:11:51PM +0300, Ilpo Järvinen wrote: > On Wed, 24 May 2023, Bjorn Helgaas wrote: > > On Wed, May 17, 2023 at 01:52:35PM +0300, Ilpo Järvinen wrote: > > > Don't assume that only the driver would be accessing LNKCTL. ASPM > > > policy changes can trigger write to LNKCTL

Re: [PATCH v2 9/9] wifi: ath10k: Use RMW accessors for changing LNKCTL

On Thu, 25 May 2023, Ilpo Järvinen wrote: > On Wed, 24 May 2023, Bjorn Helgaas wrote: > > > On Wed, May 17, 2023 at 01:52:35PM +0300, Ilpo Järvinen wrote: > > > Don't assume that only the driver would be accessing LNKCTL. ASPM > > > policy changes can trigger write to LNKCTL outside of driver's

Re: [PATCH v2 9/9] wifi: ath10k: Use RMW accessors for changing LNKCTL

On Wed, 24 May 2023, Bjorn Helgaas wrote: > On Wed, May 17, 2023 at 01:52:35PM +0300, Ilpo Järvinen wrote: > > Don't assume that only the driver would be accessing LNKCTL. ASPM > > policy changes can trigger write to LNKCTL outside of driver's control. > > > > Use RMW capability accessors which

Re: [PATCH v2 9/9] wifi: ath10k: Use RMW accessors for changing LNKCTL

On Wed, May 17, 2023 at 01:52:35PM +0300, Ilpo Järvinen wrote: > Don't assume that only the driver would be accessing LNKCTL. ASPM > policy changes can trigger write to LNKCTL outside of driver's control. > > Use RMW capability accessors which does proper locking to avoid losing > concurrent

Re: [PATCH v2 9/9] wifi: ath10k: Use RMW accessors for changing LNKCTL

Ilpo Järvinen writes: > Don't assume that only the driver would be accessing LNKCTL. ASPM > policy changes can trigger write to LNKCTL outside of driver's control. > > Use RMW capability accessors which does proper locking to avoid losing > concurrent updates to the register value. On restore,

[PATCH v2 9/9] wifi: ath10k: Use RMW accessors for changing LNKCTL

Don't assume that only the driver would be accessing LNKCTL. ASPM policy changes can trigger write to LNKCTL outside of driver's control. Use RMW capability accessors which does proper locking to avoid losing concurrent updates to the register value. On restore, clear the ASPMC field properly.