Re: [PATCH] ath10k: Fix channel info parsing for non tlv target
Rakesh Pillai wrote:
> The tlv targets such as WCN3990 send more data in the chan info event, which
> is
> not sent by the non tlv targets. There is a minimum size check in the wmi
> event
> for non-tlv targets and hence we cannot update the common channel info
> structure as it was done in commit 13104929d2ec ("ath10k: fill the channel
> survey results for WCN3990 correctly"). This broke channel survey results on
> 10.x firmware versions.
>
> If the common channel info structure is updated, the size check for chan info
> event for non-tlv targets will fail and return -EPROTO and we see the below
> error messages
>
>ath10k_pci :01:00.0: failed to parse chan info event: -71
>
> Add tlv specific channel info structure and restore the original size of the
> common channel info structure to mitigate this issue.
>
> Tested HW: WCN3990
> QCA9887
> Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1
> 10.2.4-1.0-00037
>
> Fixes: 13104929d2ec ("ath10k: fill the channel survey results for WCN3990
> correctly")
> Cc: sta...@vger.kernel.org # 5.0
> Signed-off-by: Rakesh Pillai
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
6be6c04bcc2e ath10k: fix channel info parsing for non tlv target
--
https://patchwork.kernel.org/patch/10844513/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH] ath10k: Fix channel info parsing for non tlv target
Rakesh Pillai wrote:
> The tlv targets such as WCN3990 send more data in the chan info event, which
> is
> not sent by the non tlv targets. There is a minimum size check in the wmi
> event
> for non-tlv targets and hence we cannot update the common channel info
> structure as it was done in commit 13104929d2ec ("ath10k: fill the channel
> survey results for WCN3990 correctly"). This broke channel survey results on
> 10.x firmware versions.
>
> If the common channel info structure is updated, the size check for chan info
> event for non-tlv targets will fail and return -EPROTO and we see the below
> error messages
>
>ath10k_pci :01:00.0: failed to parse chan info event: -71
>
> Add tlv specific channel info structure and restore the original size of the
> common channel info structure to mitigate this issue.
>
> Tested HW: WCN3990
> QCA9887
> Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1
> 10.2.4-1.0-00037
>
> Fixes: 13104929d2ec ("ath10k: fill the channel survey results for WCN3990
> correctly")
> Cc: sta...@vger.kernel.org # 5.0
> Signed-off-by: Rakesh Pillai
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
6be6c04bcc2e ath10k: fix channel info parsing for non tlv target
--
https://patchwork.kernel.org/patch/10844513/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: [PATCH] ath10k: Fix channel info parsing for non tlv target
Rakesh Pillai writes:
> The tlv targets such as WCN3990 send more data in
> the chan info event, which is not sent by the non tlv
> targets. There is a minimum size check in the wmi event for
> non-tlv targets and hence we cannot update the common
> channel info structure.
>
> If the common channel info structure is updated, the
> size check for chan info event for non-tlv targets
> will fail and return -EPROTO
This is the code in question:
static int ath10k_wmi_op_pull_ch_info_ev(struct ath10k *ar, struct sk_buff *skb,
struct wmi_ch_info_ev_arg *arg)
{
struct wmi_chan_info_event *ev = (void *)skb->data;
if (skb->len < sizeof(*ev))
return -EPROTO;
skb_pull(skb, sizeof(*ev));
arg->err_code = ev->err_code;
arg->freq = ev->freq;
arg->cmd_flags = ev->cmd_flags;
arg->noise_floor = ev->noise_floor;
arg->rx_clear_count = ev->rx_clear_count;
arg->cycle_count = ev->cycle_count;
return 0;
}
And here I see a disconnection between firmware and ath10k. The design
philosophy in firmware is that if the firmware does not provide all
fields, for example cycle_count in this event, the host driver is
supposed to replace the missing field with value zero and continue
normally. Obviously ath10k does not do that and instead it drops the
whole WMI event, which causes breakup like this.
The quick fix (having separate structs for TLV and 10.x interfaces) in
this patch is ok, but in the future if similar field additions arise we
need to remember to fix ath10k event parsing so that both new ath10k
will continue to work with older firmwares.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: [PATCH] ath10k: Fix channel info parsing for non tlv target
Rakesh Pillai writes:
> The tlv targets such as WCN3990 send more data in
> the chan info event, which is not sent by the non tlv
> targets. There is a minimum size check in the wmi event for
> non-tlv targets and hence we cannot update the common
> channel info structure.
>
> If the common channel info structure is updated, the
> size check for chan info event for non-tlv targets
> will fail and return -EPROTO and we see the below
> error messages
>
>ath10k_pci :01:00.0: failed to parse chan info event: -71
>
> Add tlv specific channel info structure and restore the
> original size of the common channel info structure to
> mitigate this issue.
>
> Tested HW: WCN3990
> QCA9887
> Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1
> 10.2.4-1.0-00037
>
> Fixes: 13104929d2ec ("ath10k: fill the channel survey results for WCN3990
> correctly")
> Signed-off-by: Rakesh Pillai
I'll queue this v5.3, and also for stable v5.0 and later.
--
Kalle Valo
