Re: [PATCH v4] dt-bindings: net: Convert ATH10K to YAML
Konrad Dybcio wrote: > Convert the ath10k bindings to YAML. > > Dropped properties that are absent at the current state of mainline: > - qcom,msi_addr > - qcom,msi_base > > Somewhat based on the ath11k bindings. > > Signed-off-by: Konrad Dybcio > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. ed09c61eb19d dt-bindings: net: Convert ath10k to YAML -- https://patchwork.kernel.org/project/linux-wireless/patch/20230406-topic-ath10k_bindings-v4-1-9f67a6bb0...@linaro.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH v4] dt-bindings: net: Convert ATH10K to YAML
Konrad Dybcio writes: > On 17.04.2023 12:12, Kalle Valo wrote: >> Konrad Dybcio writes: >> >>> qcom,coexist-support and qcom,coexist-gpio-pin do very little and should >>> be reconsidered on the driver side, especially the latter one. >> >> I'm curious, what do you mean very little? We set ath10k firmware >> parameters based on these coex properties. How would you propose to >> handle these? > > Right, I first thought they did nothing and then realized they're > sent to the fw.. I never amended the commit message though.. Ok, I can remove that sentence before I commit the patch. >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml >>> @@ -0,0 +1,358 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/net/wireless/qcom,ath10k.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Qualcomm Technologies ATH10K wireless devices >> >> [...] >> >>> + wifi-firmware: >>> +type: object >>> +additionalProperties: false >>> +description: | >>> + The ATH10K Wi-Fi node can contain one optional firmware subnode. >>> + Firmware subnode is needed when the platform does not have Trustzone. >> >> Is there a reason why you write ath10k in upper case? There are two case >> of that in the yaml file. We usually write it in lower case, can I >> change to that? > > No particular reason, my brain just implicitly decided that it > should be this way.. Please unify it (or LMK if you want me to > perform another resend)! No need to resend. I already changed these to lower case in my pending branch: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending=ca448a93d8669a3af5aa644725444aa61b4ca255 I'll remove the coex sentence later. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH v4] dt-bindings: net: Convert ATH10K to YAML
On 17.04.2023 12:12, Kalle Valo wrote: > Konrad Dybcio writes: > >> Convert the ATH10K bindings to YAML. >> >> Dropped properties that are absent at the current state of mainline: >> - qcom,msi_addr >> - qcom,msi_base > > Very good, thanks. Clearly I had missed that those were unused during > the review. > >> qcom,coexist-support and qcom,coexist-gpio-pin do very little and should >> be reconsidered on the driver side, especially the latter one. > > I'm curious, what do you mean very little? We set ath10k firmware > parameters based on these coex properties. How would you propose to > handle these? Right, I first thought they did nothing and then realized they're sent to the fw.. I never amended the commit message though.. > >> Somewhat based on the ath11k bindings. >> >> Signed-off-by: Konrad Dybcio > > [...] > >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml >> @@ -0,0 +1,358 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/wireless/qcom,ath10k.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Technologies ATH10K wireless devices > > [...] > >> + wifi-firmware: >> +type: object >> +additionalProperties: false >> +description: | >> + The ATH10K Wi-Fi node can contain one optional firmware subnode. >> + Firmware subnode is needed when the platform does not have Trustzone. > > Is there a reason why you write ath10k in upper case? There are two case > of that in the yaml file. We usually write it in lower case, can I > change to that? No particular reason, my brain just implicitly decided that it should be this way.. Please unify it (or LMK if you want me to perform another resend)! Konrad > ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH v4] dt-bindings: net: Convert ATH10K to YAML
Konrad Dybcio writes: > Convert the ATH10K bindings to YAML. > > Dropped properties that are absent at the current state of mainline: > - qcom,msi_addr > - qcom,msi_base Very good, thanks. Clearly I had missed that those were unused during the review. > qcom,coexist-support and qcom,coexist-gpio-pin do very little and should > be reconsidered on the driver side, especially the latter one. I'm curious, what do you mean very little? We set ath10k firmware parameters based on these coex properties. How would you propose to handle these? > Somewhat based on the ath11k bindings. > > Signed-off-by: Konrad Dybcio [...] > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml > @@ -0,0 +1,358 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/wireless/qcom,ath10k.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies ATH10K wireless devices [...] > + wifi-firmware: > +type: object > +additionalProperties: false > +description: | > + The ATH10K Wi-Fi node can contain one optional firmware subnode. > + Firmware subnode is needed when the platform does not have Trustzone. Is there a reason why you write ath10k in upper case? There are two case of that in the yaml file. We usually write it in lower case, can I change to that? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH v4] dt-bindings: net: Convert ATH10K to YAML
On 11/04/2023 20:19, Konrad Dybcio wrote: > Convert the ATH10K bindings to YAML. > > Dropped properties that are absent at the current state of mainline: > - qcom,msi_addr > - qcom,msi_base > > qcom,coexist-support and qcom,coexist-gpio-pin do very little and should > be reconsidered on the driver side, especially the latter one. > > Somewhat based on the ath11k bindings. > > Signed-off-by: Konrad Dybcio Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
