[ath9k-devel] [PATCH 4/6] ath10k: include all management frames to ATH10K_DBG_BEACON

2013-05-20 Thread Kalle Valo
Change ATH10K_DBG_BEACON to include all management frame tx and rx functionality. That way it doesn't spam rest of wmi debug logs. Rename the flag to ATH10K_DBG_MGMT to better reflect the functionality. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/debug.h

[ath9k-devel] [PATCH 5/6] ath10k: add ATH10K_DBG_DATA

2013-05-20 Thread Kalle Valo
Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/debug.h |1 + drivers/net/wireless/ath/ath10k/txrx.c |2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/debug.h b/drivers/net/wireless/ath/ath10k

[ath9k-devel] [PATCH 6/6] ath10k: preliminary VHT support

2013-05-20 Thread Kalle Valo
Adds preliminary VHT (802.11ac) support to ath10k. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/mac.c | 66 + drivers/net/wireless/ath/ath10k/wmi.c | 13 ++- drivers/net/wireless/ath/ath10k/wmi.h | 10 + 3

Re: [ath9k-devel] [PATCH 1/2] ath10k: Convert ath10k_dbg uses

2013-05-20 Thread Kalle Valo
Joe Perches j...@perches.com writes: On Mon, 2013-05-20 at 10:12 +0300, Kalle Valo wrote: Michal Kazior michal.kaz...@tieto.com writes: On 16/05/13 09:03, Joe Perches wrote: Neaten and shorten the uses of ath10k_dbg and ath10k_dbg_dump. Add macros to hold the ATH10K_DBG_ mask portion

Re: [ath9k-devel] [PATCH] ath10k: kill ath_common() wrapper function

2013-05-15 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: No need for this silly abstraction. Also rename the structure member so it makes more sense when used. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, applied. -- Kalle Valo ___ ath9k

Re: [ath9k-devel] [RFC/RFT 6/7] ath10k: add active htc ul pipe polling support

2013-05-15 Thread Kalle Valo
the data path is idle? And is it absolutely necessary to use a timer? Can't we use tx completions or some other existing event from firmware to accomplish the same? -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https

Re: [ath9k-devel] ath9k_htc: Target is unresponsive

2013-05-15 Thread Kalle Valo
. Try to find if ath9k_htc has a cold/warm reset and see if that helps. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: serialize CE completions properly

2013-05-13 Thread Kalle Valo
skbuffs per tx. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH v2 1/3] ath10k: FW API update for version .629

2013-05-13 Thread Kalle Valo
that the patches are ok. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: Add new service IDs

2013-05-13 Thread Kalle Valo
Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH v2 1/3] ath10k: WMI add AP PS

2013-05-13 Thread Kalle Valo
Janusz Dziedzic janusz.dzied...@tieto.com writes: Add AP power save (UAPSD) structures, enums. Signed-off-by: Janusz Dziedzic janusz.dzied...@tieto.com Thanks, all three applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: improve firmware crash message

2013-05-13 Thread Kalle Valo
Janusz Dziedzic janusz.dzied...@tieto.com writes: print hardware name/id, firware version, make register dump more compact Signed-off-by: Janusz Dziedzic janusz.dzied...@tieto.com Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k

Re: [ath9k-devel] [RFT] ath10k: retry target reset

2013-05-09 Thread Kalle Valo
up\n); + goto exit; You have same warnings messages in different places now. I recommend adding ..for start and ...for reset, or something like that, to exactly identify the warning location. Example: ath10k_warn(target did not wake up for reset\n); -- Kalle Valo

Re: [ath9k-devel] [RFC/RFT v2 1/2] ath10k: WMI add AP PS

2013-05-09 Thread Kalle Valo
Janusz Dziedzic janusz.dzied...@tieto.com writes: Add AP power save (UAPSD) structures, enums. Signed-off-by: Janusz Dziedzic janusz.dzied...@tieto.com I see that you resent this as PATCH so I will skip these patches. -- Kalle Valo ___ ath9k-devel

Re: [ath9k-devel] [RFC/RFT 1/3] ath10k: report mgmt tx retry status as no_ack

2013-05-09 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: Signed-off-by: Michal Kazior michal.kaz...@tieto.com Why? -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [RFC/RFT 0/3] ath10k: fix beacon loss handling

2013-05-09 Thread Kalle Valo
Bartosz Markowski bartosz.markow...@tieto.com writes: Kalle, could you please submit/review these? I will not commit any patches which have either RFC or RFT tag. And I also review them in lower priority. So if you want me to commit something I recommend to use only PATCH. -- Kalle Valo

Re: [ath9k-devel] [PATCH 2/3] ath10k: add AP UAPSD support

2013-05-09 Thread Kalle Valo
Janusz Dziedzic janusz.dzied...@tieto.com writes: Add support for AP (P2P_GO) UAPSD. Signed-off-by: Janusz Dziedzic janusz.dzied...@tieto.com You should briefly mention in the commit log how you have tested this. -- Kalle Valo ___ ath9k-devel

Re: [ath9k-devel] [PATCH 3/3] ath10k: enable STA UAPSD support

2013-05-09 Thread Kalle Valo
(%d)\n, ret); Ditto. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: remove stale peers upon vif removal

2013-05-09 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: Fixes leak of ath10k_peer structures if FW stops responding suddenly and we unload the driver (e.g. eject the device while we're associated and unload the driver). Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, applied. -- Kalle

Re: [ath9k-devel] [RFT] ath10k: retry target reset

2013-05-09 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 09/05/13 08:57, Kalle Valo wrote: Michal Kazior michal.kaz...@tieto.com writes: Sometimes the device just won't reset cleanly without retrying. This seems to depend on the host hardware. Signed-off-by: Michal Kazior michal.kaz...@tieto.com

Re: [ath9k-devel] [PATCH 1/3] ath10k: WMI add AP PS

2013-05-09 Thread Kalle Valo
janusz.dzied...@tieto.com writes: -Original Message- From: Kalle Valo [mailto:kv...@qca.qualcomm.com] Sent: 9 maja 2013 09:10 To: Dziedzic Janusz Cc: ath9k-devel@lists.ath9k.org Subject: Re: [ath9k-devel] [PATCH 1/3] ath10k: WMI add AP PS Janusz Dziedzic janusz.dzied...@tieto.com writes

Re: [ath9k-devel] [PATCH 3/3] ath10k: enable STA UAPSD support

2013-05-09 Thread Kalle Valo
and no code duplication. Yes, much better. I hate macros :) -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 0/3] ath10k: fix beacon loss handling

2013-05-09 Thread Kalle Valo
retry status as no_ack ath10k: cleanup tx completion ath10k: pass NullFunc frames through mgmt tx path Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 1/3] ath10k: Strip the QoS header only for QoS data frames

2013-05-08 Thread Kalle Valo
(with the exact firmware version). -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 3/3] ath10k: Set the default TX encapsulation type

2013-05-08 Thread Kalle Valo
Sujith Manoharan suj...@msujith.org writes: From: Sujith Manoharan c_man...@qca.qualcomm.com Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com Needs a proper commit log answering: Why? What is the change user sees from this patch? -- Kalle Valo

[ath9k-devel] [RFC PATCH 1/6] ath10k: set vht_nss correctly

2013-05-07 Thread Kalle Valo
name: HP ProBook 6540b [ 1336.366943] Rate marked as a VHT rate but data is invalid: MCS: 27, NSS: 0 Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/txrx.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k

[ath9k-devel] [RFC PATCH 2/6] ath10k: change chan_to_phymode() use chandef

2013-05-07 Thread Kalle Valo
That's more logical instead of passing chandef fields one at a time. Also change ath10k_update_channel_list to hardcode the band directly. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/mac.c | 49 + 1 file changed, 31

[ath9k-devel] [RFC PATCH 3/6] ath10k: remove band_center_freq()

2013-05-07 Thread Kalle Valo
We can take the frequency directly from struct cfg80211_chan_def. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/mac.c | 25 ++--- 1 file changed, 2 insertions(+), 23 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b

[ath9k-devel] [RFC PATCH 5/6] ath10k: add ATH10K_DBG_DATA

2013-05-07 Thread Kalle Valo
Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/debug.h |1 + drivers/net/wireless/ath/ath10k/txrx.c |2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/debug.h b/drivers/net/wireless/ath/ath10k

[ath9k-devel] [RFC PATCH 4/6] ath10k: include all management frames to ATH10K_DBG_BEACON

2013-05-07 Thread Kalle Valo
Change ATH10K_DBG_BEACON to include all management frame tx and rx functionality. That way it doesn't spam rest of wmi debug logs. Rename the flag to ATH10K_DBG_MGMT to better reflect the functionality. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/debug.h

[ath9k-devel] [RFC PATCH 6/6] ath10k: preliminary VHT support

2013-05-07 Thread Kalle Valo
Adds preliminary VHT (802.11ac) support to ath10k. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/mac.c | 66 + drivers/net/wireless/ath/ath10k/wmi.c | 13 ++- drivers/net/wireless/ath/ath10k/wmi.h | 10 + 3

Re: [ath9k-devel] [PATCH 0/2] ath10k: module parameter fine tuning

2013-05-07 Thread Kalle Valo
Kalle Valo kv...@qca.qualcomm.com writes: When running some build tests I found few issues releated to module parameters. --- Kalle Valo (2): ath10k: rename debug_mask ath10k: rename ath10k_p2p module parameter to p2p Applied. -- Kalle Valo

Re: [ath9k-devel] [PATCH 3/5] ath10k: increase scan timeout

2013-05-07 Thread Kalle Valo
); + * false. Add a 200ms margin to account event/command + * processing. */ + mod_timer(ar-scan.timeout, jiffies + + ((arg-max_scan_time+200)*HZ)/1000); This patch is ok (no need to resend), but this code could use msecs_to_jiffies(). -- Kalle Valo

Re: [ath9k-devel] [PATCH 6/7] ath10k: cleanup pci suspend

2013-05-07 Thread Kalle Valo
* HZ); Actually I would prefered the name left as the variable contains more than just a normal error code, it also contains the time left before timeout. But I have applied the patch anyway. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel

Re: [ath9k-devel] [PATCH 0/7] ath10k: random fixes/cleanups

2013-05-07 Thread Kalle Valo
suspend ath10k: use ath10k_err for non-recoverable failures Thanks, all applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: avoid infinite loop

2013-05-07 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: fix htt debug flag

2013-05-07 Thread Kalle Valo
Bartosz Markowski bartosz.markow...@tieto.com writes: Use HTT_DUMP for tx frag/msdu. Signed-off-by: Bartosz Markowski bartosz.markow...@tieto.com Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https

Re: [ath9k-devel] [PATCH] ath10k: fix possible htt rx memleak

2013-05-07 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: fix rx descriptor definition

2013-05-07 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: Fortunately we don't use these fields but it's good to have them defined correctly. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list

Re: [ath9k-devel] [PATCH 0/8] ath10k: fixes

2013-05-03 Thread Kalle Valo
ath10k: handle CE init failure ath10k: handle rx pipe post failure ath10k: handle CE start failure ath10k: print warning on ep0 htc rx ath10k: free skb if ath10k_htc_send() fails Thanks, all applied. -- Kalle Valo ___ ath9k-devel mailing

Re: [ath9k-devel] [PATCH v2 1/5] ath10k: Remove unneeded locks during HTT RX attach

2013-05-03 Thread Kalle Valo
-by: Sujith Manoharan c_man...@qca.qualcomm.com AFAICS this is already applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH v2 0/5] ath10k pending patches

2013-05-03 Thread Kalle Valo
RX attach ath10k: Fix mpdu spacing to 8us ath10k: Fix TXOP handling ath10k: Move debug structures to debug.h ath10k: Add host statistics Patch 2 applied. Patches 1 and 3 already applied. Patches 4 and 5 I send feedback already before. -- Kalle Valo

Re: [ath9k-devel] [PATCH 1/2] ath10k: Move debug structures to debug.h

2013-05-03 Thread Kalle Valo
Sujith Manoharan suj...@msujith.org writes: Kalle Valo wrote: The idea is that everything within ar variable can be found from core.h. That way people don't need to track down where it's actually defined. That doesn't seem to be the way things are organized. ar contains instances of HTT

[ath9k-devel] [PATCH 0/2] ath10k: module parameter fine tuning

2013-05-03 Thread Kalle Valo
When running some build tests I found few issues releated to module parameters. --- Kalle Valo (2): ath10k: rename debug_mask ath10k: rename ath10k_p2p module parameter to p2p drivers/net/wireless/ath/ath10k/core.c |8 drivers/net/wireless/ath/ath10k/debug.c |4

[ath9k-devel] [PATCH 1/2] ath10k: rename debug_mask

2013-05-03 Thread Kalle Valo
/ath6kl/built-in.o:/home/kvalo/ath10k/src/ath10k/include/linux/list.h:188: first defined here This changes just the variable, the name of kernel module parameters stays the same. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/core.c |4 ++-- drivers

[ath9k-devel] [PATCH 2/2] ath10k: rename ath10k_p2p module parameter to p2p

2013-05-03 Thread Kalle Valo
AFAICS there's no need to have the ath10k_ prefix in p2p kernel module parameter so remove that. The name of the actual variable in code stays the same, ath10k_p2p. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/core.c |4 ++-- 1 file changed, 2

Re: [ath9k-devel] [PATCH 2/2] ath10k: only warn about incompatible firmware versions

2013-05-03 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 02/05/13 11:02, Kalle Valo wrote: Most of the time it does more harm than good to halt the driver initialisation if the firmware version is not supported. For example, sometimes it's good to test something from older versions etc. So just

Re: [ath9k-devel] [PATCH 0/2] ath10k: firmware version related changes

2013-05-03 Thread Kalle Valo
Kalle Valo kv...@qca.qualcomm.com writes: Few simple changes how we handle firmware versions. --- Kalle Valo (2): ath10k: print firmware version string during boot ath10k: only warn about incompatible firmware versions Applied. -- Kalle Valo

Re: [ath9k-devel] [PATCH 1/2] ath10k: Move debug structures to debug.h

2013-05-02 Thread Kalle Valo
this patch. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [RFC/RFT 1/2] ath10k: WMI add AP PS

2013-05-02 Thread Kalle Valo
: WARNING: line over 80 characters drivers/net/wireless/ath/ath10k/mac.c:916: WARNING: line over 80 characters drivers/net/wireless/ath/ath10k/mac.c:919: WARNING: line over 80 characters drivers/net/wireless/ath/ath10k/mac.c:922: WARNING: line over 80 characters -- Kalle Valo

Re: [ath9k-devel] [PATCH v3] ath10k: Remove unneeded locks during HTT RX attach

2013-05-02 Thread Kalle Valo
-by: Sujith Manoharan c_man...@qca.qualcomm.com Thanks, applied. There were conflicts and sha1 ids did not match so I had to fix the conflicts manually. Please check my changes. Also please try to fix your setup so that sha1 ids are valid in the patches. -- Kalle Valo

Re: [ath9k-devel] [PATCH] ath10k: Fix TXOP handling

2013-05-02 Thread Kalle Valo
Sujith Manoharan suj...@msujith.org writes: Kalle Valo wrote: Please add a comment. [PATCH v2] ath10k: Fix TXOP handling I had to edit these out manually. This kind of comments should be after '--' so that git-am can rip them out manually. The channel time duration programmed in the HW

Re: [ath9k-devel] [PATCH] ath10k: unify header inclusion guard names

2013-05-02 Thread Kalle Valo
Bartosz Markowski bartosz.markow...@tieto.com writes: Signed-off-by: Bartosz Markowski bartosz.markow...@tieto.com Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k

Re: [ath9k-devel] [PATCH 1/2] ath10k: Move debug structures to debug.h

2013-05-02 Thread Kalle Valo
Sujith Manoharan suj...@msujith.org writes: Kalle Valo wrote: I would like to have have all struct ath10k substructures in core.h so that they don't get too much spread around. Hence I need to drop this patch. debug.h seems an appropriate place to have debug-specific structures. The idea

Re: [ath9k-devel] [PATCH 02/20] ath10k: Merge mac.h with core.h

2013-05-02 Thread Kalle Valo
Sujith Manoharan suj...@msujith.org writes: Kalle Valo wrote: Why do you want to delete mac.h? My idea was to avoid bloating core.h and that's why I wanted to have header files for each .c file. mac.h contains a few prototypes and most of the data structures are in core.h. I don't think

[ath9k-devel] [PATCH 1/2] ath10k: print firmware version string during boot

2013-05-02 Thread Kalle Valo
Currently we don't print firmware version at all. Move the current firmware dowloaded message later once firmware has booted and include firmware version in the message. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/core.c |3 ++- 1 file changed, 2

[ath9k-devel] [PATCH 2/2] ath10k: only warn about incompatible firmware versions

2013-05-02 Thread Kalle Valo
Most of the time it does more harm than good to halt the driver initialisation if the firmware version is not supported. For example, sometimes it's good to test something from older versions etc. So just change the check to a warning. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers

Re: [ath9k-devel] [PATCH 6/6] ath10k: cleanup ath10k_pci_stop_intr()

2013-04-30 Thread Kalle Valo
(ar_pci-pdev-irq + i, ar); I'm not sure about this. If num_msi_intrs is 5 we still free only the first irq? Did I understood this correctly? -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo

Re: [ath9k-devel] [PATCH 0/2] ath10k: fw download refactor

2013-04-30 Thread Kalle Valo
/wireless/ath/ath10k/core.c: In function 'ath10k_push_board_ext_data': drivers/net/wireless/ath/ath10k/core.c:225:7: warning: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'size_t' [-Wformat] -- Kalle Valo ___ ath9k

Re: [ath9k-devel] [PATCH] ath10k: fix (void *) casts in wmi submodule

2013-04-30 Thread Kalle Valo
Bartosz Markowski bartosz.markow...@tieto.com writes: Signed-off-by: Bartosz Markowski bartosz.markow...@tieto.com Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k

Re: [ath9k-devel] [PATCH 7/7] ath10k: strip protected flag

2013-04-30 Thread Kalle Valo
to explain why we are doing this. I'll apply this anyway, but we need to discuss more about this. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 0/7] ath10k: htt rx fixes

2013-04-30 Thread Kalle Valo
a frame in frag rx ath10k: move ath10k_htt_rx_free_msdu_chain() ath10k: drop all msdus in case of htt rx failure ath10k: fix tkip fragment rx ath10k: strip protected flag Thanks, all seven applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k

Re: [ath9k-devel] [PATCH 0/2] ath10k: ce cleanup

2013-04-30 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: Trivial cleanup. Michal Kazior (2): ath10k: use ALIGN() kernel macros ath10k: use void pointer instead of char pointer Thanks, both applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel

Re: [ath9k-devel] [PATCH 7/7] ath10k: strip protected flag

2013-04-30 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 30/04/13 09:58, Kalle Valo wrote: Michal Kazior michal.kaz...@tieto.com writes: We already do decryption and all crypto verification in HW. mac80211 tries to verify CCMP for fragmented rx and fails without this patch. This fixes fragmented

Re: [ath9k-devel] [PATCH] ath10k: Use IBSS SSID provided by mac80211.

2013-04-30 Thread Kalle Valo
Marek Puzyniak marek.puzyn...@tieto.com writes: IBSS ssid is provided by mac80211, use it in vdev start. Signed-off-by: Marek Puzyniak marek.puzyn...@tieto.com You sent this patch two times, I didn't find any difference from them so I just took the latter one. Thanks. -- Kalle Valo

Re: [ath9k-devel] [PATCH] ath10k: fix pci feature bitmap

2013-04-30 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: The array size evaluated to zero. This caused hw v1 workaround to fail. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel

Re: [ath9k-devel] Fwd: Missing WMI_BSSINFO_EVENTID from AR6004

2013-04-30 Thread Kalle Valo
. Any idea of such behavior. Wrong list: http://wireless.kernel.org/en/users/Drivers/ath6kl#Support -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH v2 0/6] ath10k: coding style cleanup

2013-04-30 Thread Kalle Valo
ath10k: drop unnecessary else branch ath10k: cleanup ath10k_pci_stop_intr() Thanks, all applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 0/5] ath10k: fix checkpatch warnings 20130426

2013-04-30 Thread Kalle Valo
Kalle Valo kv...@qca.qualcomm.com writes: Trying to get the number of checkpatch warnings smaller. --- Kalle Valo (5): ath10k: fix checkpatch warnings in mac.c ath10k: fix some checkpatch warnings in wmi.c ath10k: fix some checkpatch warnings in pci.c ath10k: fix

Re: [ath9k-devel] [PATCH] ath10k: Fix TXOP handling

2013-04-30 Thread Kalle Valo
/drivers/net/wireless/ath/ath10k/mac.c @@ -2188,7 +2188,7 @@ static int ath10k_conf_tx(struct ieee80211_hw *hw, p-cwmin = params-cw_min; p-cwmax = params-cw_max; p-aifs = params-aifs; - p-txop = params-txop; + p-txop = params-txop * 32; Please add a comment. -- Kalle

Re: [ath9k-devel] [PATCH 01/20] ath10k: Remove duplicate UART init code

2013-04-30 Thread Kalle Valo
Sujith Manoharan suj...@msujith.org writes: Kalle Valo wrote: These are dropped: 18, 20 I hope I didn't miss anything. An updated version of patch 20 (after addressing Michal's comments) was posted and is here: http://msujith.org/patches/wl/Apr-30-2013/0019-ath10k-Remove-unneeded

Re: [ath9k-devel] [PATCH 01/20] ath10k: Remove duplicate UART init code

2013-04-30 Thread Kalle Valo
Sujith Manoharan suj...@msujith.org writes: Kalle Valo wrote: But in the future please don't send more than 12 patches at a time, it's way too much pain to handle this many unrelated patches. Sure, though I am not sure what you mean by unrelated patches. :-) I meant that they don't depend

[ath9k-devel] [PATCH 00/27] ath10k: checkpatch fixes 20130430

2013-04-30 Thread Kalle Valo
them. That's why I want to apply these ASAP. Please review. --- Kalle Valo (27): ath10k: fix new warning in ath10k_push_board_ext_data() ath10k: fix long line in ath10k_htt_htc_attach() ath10k: fix long line in ath10k_read_wmi_services() ath10k: simple long line fixes

[ath9k-devel] [PATCH 02/27] ath10k: fix long line in ath10k_htt_htc_attach()

2013-04-30 Thread Kalle Valo
Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/htt.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/htt.c b/drivers/net/wireless/ath/ath10k/htt.c index 8116e6c..f9601d3 100644 --- a/drivers/net

[ath9k-devel] [PATCH 01/27] ath10k: fix new warning in ath10k_push_board_ext_data()

2013-04-30 Thread Kalle Valo
drivers/net/wireless/ath/ath10k/core.c: In function 'ath10k_push_board_ext_data': drivers/net/wireless/ath/ath10k/core.c:225:7: warning: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'size_t' [-Wformat] Signed-off-by: Kalle Valo kv...@qca.qualcomm.com

[ath9k-devel] [PATCH 03/27] ath10k: fix long line in ath10k_read_wmi_services()

2013-04-30 Thread Kalle Valo
Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/debug.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c index 3357917..6cfcb95 100644

[ath9k-devel] [PATCH 05/27] ath10k: fix long lines related htd credit reporting

2013-04-30 Thread Kalle Valo
Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/htc.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/htc.c b/drivers/net/wireless/ath/ath10k/htc.c index be41e11..a12c05b 100644 --- a/drivers

[ath9k-devel] [PATCH 04/27] ath10k: simple long line fixes

2013-04-30 Thread Kalle Valo
Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/core.c |9 ++--- drivers/net/wireless/ath/ath10k/htc.c| 12 drivers/net/wireless/ath/ath10k/htt_rx.c |3 ++- drivers/net/wireless/ath/ath10k/pci.c|3 ++- drivers/net

[ath9k-devel] [PATCH 06/27] ath10k: fix long lines in htc.c

2013-04-30 Thread Kalle Valo
Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/htc.c|5 - drivers/net/wireless/ath/ath10k/htt_rx.c |7 +-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/htc.c b/drivers/net/wireless/ath

[ath9k-devel] [PATCH 07/27] ath10k: get rid of unnecessary else branch

2013-04-30 Thread Kalle Valo
We can handle the same with a simple goto. Also this gets rid of few long lines. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/htc.c | 137 + 1 file changed, 70 insertions(+), 67 deletions(-) diff --git a/drivers/net

[ath9k-devel] [PATCH 08/27] ath10k: fix long lines in htt_rx.c

2013-04-30 Thread Kalle Valo
Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/htt_rx.c | 43 -- 1 file changed, 28 insertions(+), 15 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c index ed61dd3

[ath9k-devel] [PATCH 09/27] ath10k: fix comment style in htt.h

2013-04-30 Thread Kalle Valo
Fixes few long lines at the same time. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/htt.h | 166 + 1 file changed, 125 insertions(+), 41 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/htt.h b/drivers/net

[ath9k-devel] [PATCH 11/27] ath10k: rename WMI_CMD_GRP_START_ID()

2013-04-30 Thread Kalle Valo
Just to make lines shorter. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/wmi.h | 56 + 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath

[ath9k-devel] [PATCH 10/27] ath10k: fix long lines in ce.c

2013-04-30 Thread Kalle Valo
Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/ce.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/ce.c b/drivers/net/wireless/ath/ath10k/ce.c index 480b809..d439181

[ath9k-devel] [PATCH 12/27] ath10k: rename struct wmi_p2p_noa_info::noa_descriptors

2013-04-30 Thread Kalle Valo
The word noa is useless as a field name. This makes few lines shorter. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/wmi.c |9 - drivers/net/wireless/ath/ath10k/wmi.h |2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git

[ath9k-devel] [PATCH 13/27] ath10k: shorten ath10k_wmi_pdev_set_wmm_params() declaration

2013-04-30 Thread Kalle Valo
To keep checkpatch happy. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/wmi.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h index 231f7b6..d286f3e 100644

[ath9k-devel] [PATCH 14/27] ath10k: fix few long lines in wmi.c

2013-04-30 Thread Kalle Valo
Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/wmi.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index 9d72f29..5e235d4 100644

[ath9k-devel] [PATCH 15/27] ath10k: change config initialisation in ath10k_wmi_cmd_init()

2013-04-30 Thread Kalle Valo
Less long lines that way. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/wmi.c | 84 - 1 file changed, 52 insertions(+), 32 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k

[ath9k-devel] [PATCH 16/27] ath10k: rename hif_ce_completion_state to ath10k_pci_compl

2013-04-30 Thread Kalle Valo
Makes few lines shorter at the same time. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/pci.c | 22 +++--- drivers/net/wireless/ath/ath10k/pci.h |2 +- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/net

[ath9k-devel] [PATCH 17/27] ath10k: fix a long line in ath10k_pci_hif_dump_area()

2013-04-30 Thread Kalle Valo
Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/pci.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index c973f6f..f8ade52 100644 --- a/drivers/net

[ath9k-devel] [PATCH 19/27] ath10k: pci: rename receive post buffer functions

2013-04-30 Thread Kalle Valo
To make lines shorter. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/pci.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 76f44da

[ath9k-devel] [PATCH 20/27] ath10k: rename msg_callbacks variable in ath10k_pci_process_ce()

2013-04-30 Thread Kalle Valo
Shorter lines that way. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/pci.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 24ab76e

[ath9k-devel] [PATCH 21/27] ath10k: rename struct ath10k_hif_cb field names

2013-04-30 Thread Kalle Valo
Shorter lines that way. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/hif.h | 12 ++-- drivers/net/wireless/ath/ath10k/htc.c |4 ++-- drivers/net/wireless/ath/ath10k/pci.c | 15 --- 3 files changed, 16 insertions(+), 15 deletions

[ath9k-devel] [PATCH 22/27] ath10k: simplify arg variable initialisation in ath10k_vdev_start()

2013-04-30 Thread Kalle Valo
Shorter lines that way. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/mac.c | 36 ++--- 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k

[ath9k-devel] [PATCH 23/27] ath10k: simplify arg variable initialisation in ath10k_monitor_start()

2013-04-30 Thread Kalle Valo
Shorter lines that way. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/mac.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k

[ath9k-devel] [PATCH 24/27] ath10k: fix long lines in ath10k_config_ps_iter()

2013-04-30 Thread Kalle Valo
Makes checkpatch happy. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/mac.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index bd74c84

[ath9k-devel] [PATCH 25/27] ath10k: use min_t() instead of min()

2013-04-30 Thread Kalle Valo
Checkpatch warned about this. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/bmi.c|2 +- drivers/net/wireless/ath/ath10k/htc.c|4 +++- drivers/net/wireless/ath/ath10k/htt_tx.c |2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff

[ath9k-devel] [PATCH 26/27] ath10k: whitespace fixes found by checkpatch

2013-04-30 Thread Kalle Valo
Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/ce.h |3 ++- drivers/net/wireless/ath/ath10k/htc.c |2 +- drivers/net/wireless/ath/ath10k/mac.c |2 +- drivers/net/wireless/ath/ath10k/pci.c |4 ++-- 4 files changed, 6 insertions(+), 5 deletions

[ath9k-devel] [PATCH 27/27] ath10k: remove multiple assignments

2013-04-30 Thread Kalle Valo
checkpatch warns about these. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/ce.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/ce.c b/drivers/net/wireless/ath/ath10k/ce.c index d439181

[ath9k-devel] [PATCH 10/10] ath10k: space prohibited before semicolon

2013-04-30 Thread Kalle Valo
A warning from checkpatch. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/wmi.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h index d286f3e..2ad0431

<    1   2   3   4   5   >