Re: [ath9k-devel] [PATCH 0/7] ath10k: non-functional cleanups

2013-04-18 Thread Kalle Valo
ath10k_warn() instead of WARN() ath10k: remove old function prototype Thanks, all seven applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath10k: add bmi_read32/bmi_write32 function

2013-04-18 Thread Kalle Valo
= le32_to_cpu(tmp);\ ret;\ }) -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k

Re: [ath9k-devel] [PATCH v2 0/5] ath10k: pci memleak fix

2013-04-18 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 18/04/13 12:29, Kalle Valo wrote: Kalle Valo kv...@qca.qualcomm.com writes: Michal Kazior michal.kaz...@tieto.com writes: The v2 fixes patch 2, and introduces new patches 4 and 5. There were two possible memleaks. Michal Kazior (5

Re: [ath9k-devel] [PATCH 0/3] remaining ath10k_ prefixes for sub-modules

2013-04-17 Thread Kalle Valo
into htt_tx functions ath10k: add ath10k_ prefixes into htt_rx functions Thanks, all applied. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 0/4] small cleanups

2013-04-17 Thread Kalle Valo
Bartosz Markowski bartosz.markow...@tieto.com writes: Bartosz Markowski (4): ath10k: fix indentation ath10k: remove odd 'todo' comment ath10k: remove 'todo' comments ath10k: remove obsolete define Thanks, all four applied. -- Kalle Valo

Re: [ath9k-devel] [PATCH] ath10k: split way to long line of code

2013-04-17 Thread Kalle Valo
that's any better either. I'll split the output into two lines. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 1/2] ath10k: wmi_mgmt_rx setup band

2013-04-17 Thread Kalle Valo
(u32 phy_mode) I also removed the extra new line. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 1/2] ath10k: wmi_mgmt_rx setup band

2013-04-17 Thread Kalle Valo
Kalle Valo kv...@qca.qualcomm.com writes: Janusz Dziedzic janusz.dzied...@tieto.com writes: Setup band using wmi_event and phy_mode reported by FW/HW. Signed-off-by: Janusz Dziedzic janusz.dzied...@tieto.com Both applied, thanks. Forgot to mention that there were conflicts with both

Re: [ath9k-devel] mac80211: regression: fd0f979 no long authenticates w/ath9k_htc

2013-03-06 Thread Kalle Valo
. You should use trace-cmd. Something like this: trace-cmd record -e mac80211 -e cfg80211 And then send compressed trace.dat to Johannes. More info: http://wireless.kernel.org/en/developers/Documentation/mac80211/tracing -- Kalle Valo ___ ath9k-devel

Re: [ath9k-devel] [PATCH 4/6] ath9k: Only spectral scan relay file when it was created

2013-01-31 Thread Kalle Valo
as well, but I didn't check that carefully. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath9k: Support ethtool getstats api.

2012-05-08 Thread Kalle Valo
Ben Greear gree...@candelatech.com writes: No, there is a check later that does a BUG_ON if our we have screwed up the indexing of the stats. Please, no BUG_ON() calls in wifi drivers. They just make users life miserable. WARN_ON() with a safe bailout is enough. -- Kalle Valo

Re: [ath9k-devel] [RFC] ath9k: validate for non-zero BSSID

2011-11-29 Thread Kalle Valo
seem to be beacons and their BSSID is '0', as our curbssid is also '0' they seem to be wrongly identified as 'my_beacons'. This is a perfect addition to the commit log. Remember that the commit log should especially answer the question why?. -- Kalle Valo

Re: [ath9k-devel] [PATCH] ath9k: Improve ath_tx_aggr_stop to avoid TID stuck in cleanup state.

2011-11-21 Thread Kalle Valo
retried). If this happened ath_tx_aggr_stop would leave TID in cleanup state permanently. Fix this by making ath_tx_flush_tid remove AGGR_ADDBA_COMPLETE and AGGR_CLEANUP flags from TID status if TID is empty. And word wrap your commits to 72 chars or so. -- Kalle Valo

Re: [ath9k-devel] [PATCH] ath9k: rename ath9k_platform.h to ath_platform.h

2011-11-17 Thread Kalle Valo
Hi Sangwook, On 11/16/2011 01:34 PM, Sangwook Lee wrote: On 15 November 2011 16:37, Kalle Valo kv...@adurom.com mailto:kv...@adurom.com wrote: Hi Sangwook, On 11/15/2011 01:23 PM, Sangwook Lee wrote: The patch series proposes to rename ath9k_platform.h

Re: [ath9k-devel] [PATCH] ath9k: rename ath9k_platform.h to ath_platform.h

2011-11-15 Thread Kalle Valo
Hi Sangwook, On 11/15/2011 01:23 PM, Sangwook Lee wrote: The patch series proposes to rename ath9k_platform.h to ath_platform.h This header file handles platform data used only for ath9k, but it can used by ath6k as well. We can take wl12xx.h as as a example. Please let us change this file

Re: [ath9k-devel] [PATCH] ath9k: fix MGMT packets when using TKIP

2011-08-22 Thread Kalle Valo
Bill Jordan bjor...@rajant.com writes: Prevent 8 bytes from being truncated from MGMT packets when using TKIP. A bit more information in the commit log would be nice. Is this is a regression or an old bug? Maybe a stable candidate? -- Kalle Valo

Re: [ath9k-devel] ath9k ps poll performance

2009-12-13 Thread Kalle Valo
. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH v2 2/4] ath9k_hw: distinguish single-chip solutions on initial probe print

2009-10-26 Thread Kalle Valo
+ AR_RADIO_SREV_MAJOR)), + ah-hw_version.phyRev); + } +} I think you should provide the size of hw_name to this function and use snprintf() to avoid writing out of bounds. -- Kalle Valo ___ ath9k-devel mailing

Re: [ath9k-devel] [PATCH v2 2/4] ath9k_hw: distinguish single-chip solutions on initial probe print

2009-10-26 Thread Kalle Valo
to be careful. Yeah, you never know if someone (for example a crazy Finn just after a refreshing sauna) comes along, changes the function a bit to clean it up and creates a subtle bug ;) -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel

Re: [ath9k-devel] ath9k module-Unable to set channel-since ath comes

2009-05-18 Thread Kalle Valo
have no idea if it's practical or not. -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH] ath9k: Fix basic connectivity issue

2009-01-10 Thread Kalle Valo
configuration. [...] +static int btcoex_enable; +module_param(btcoex_enable, bool, 0); +MODULE_PARM_DESC(btcoex_enable, Enable Bluetooth coexistence support); Somehow I guessed that this was coming :) I still think that a proper nl80211 interface for this is in order. -- Kalle Valo

<    1   2   3   4   5