Hi Adrian,
On Wed, Dec 14, 2016 at 7:45 AM, Adrian Chadd <adr...@freebsd.org> wrote:
> hi,
>
> On 12 December 2016 at 12:05, Martin Blumenstingl
> <martin.blumensti...@googlemail.com> wrote:
>
>>
>> It seems that there are a few devices out there where
Hello Kalle,
On Fri, Nov 25, 2016 at 4:06 PM, Valo, Kalle <kv...@qca.qualcomm.com> wrote:
> Kalle Valo <kv...@codeaurora.org> writes:
>
>> Martin Blumenstingl <martin.blumensti...@googlemail.com> writes:
>>
>>> There are two types of swapping th
On Fri, Nov 25, 2016 at 4:06 PM, Valo, Kalle <kv...@qca.qualcomm.com> wrote:
> Kalle Valo <kv...@codeaurora.org> writes:
>
>> Martin Blumenstingl <martin.blumensti...@googlemail.com> writes:
>>
>>> There are two types of swapping the EEPROM data in the
On Wed, Oct 5, 2016 at 10:31 PM, Rob Herring <robh...@kernel.org> wrote:
> On Wed, Oct 5, 2016 at 1:36 PM, Felix Fietkau <n...@nbd.name> wrote:
>> On 2016-10-05 20:25, Martin Blumenstingl wrote:
>>> On Mon, Oct 3, 2016 at 5:22 PM, Rob Herring <robh...@kernel.org
etree to
ath9k_platform_data" (for example in OpenWrt and LEDE) which becomes
obsolete with this patch.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
drivers/net/wireless/ath/ath9k/init.c | 42 +++
1 file changed, 42 insertions(+)
diff --g
Add documentation how devicetree can be used to configure ath9k based
devices.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
.../devicetree/bindings/net/wireless/qca,ath9k.txt | 48 ++
1 file changed, 48 insertions(+)
create mode
This can be used when the ath_bus_type has to be presented in a log
message or firmware filename.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
drivers/net/wireless/ath/ath.h | 6 ++
drivers/net/wireless/ath/main.c | 7 +++
2 files changed, 13 inse
in the documentation (keeping it at a bare
minimum: removed the PCI bridge, use a better real-world example with
less-confusing device/fn numbers, added the actual size of the config
space to the reg property)
Martin Blumenstingl (3):
Documentation: dt: net: add ath9k wireless device
On Sun, Oct 9, 2016 at 3:28 AM, Rob Herring <r...@kernel.org> wrote:
> On Sun, Oct 02, 2016 at 11:47:41PM +0200, Martin Blumenstingl wrote:
>> Add documentation how devicetree can be used to configure ath9k based
>> devices.
>>
>> Signed-off-by: Mart
On Mon, Oct 3, 2016 at 5:22 PM, Rob Herring <robh...@kernel.org> wrote:
> On Sun, Oct 2, 2016 at 5:50 PM, Martin Blumenstingl
> <martin.blumensti...@googlemail.com> wrote:
>> There are at least two drivers (ath9k and mt76) out there, where
>> devicetree authors need
-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
Documentation/devicetree/bindings/net/wireless/qca,ath9k.txt | 2 ++
drivers/net/wireless/ath/ath9k/init.c| 4
2 files changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindin
a generic implementation for IEEE 802.11 device
configuration OF properties, which can be used by all drivers.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
drivers/of/Kconfig | 4 +++
drivers/of/Makefile | 1 +
drivers/of/of_ieee80211.c
This adds the documentation for the generic IEEE 802.111 binding, which
currently allows enabling and disabling the 2.4GHz and 5GHz band.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
Documentation/devicetree/bindings/net/wireless/ieee80211.txt | 12 +
el.org/index.php/Main_Page
Martin Blumenstingl (3):
Documentation: dt-bindings: add IEEE 802.11 binding documentation
of: add IEEE 802.11 device configuration support code
ath9k: add OF configuration to disable the 2.4GHz or 5GHz band
.../devicetree/bindings/net/wireless/ieee80211.tx
_to_cpu.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
drivers/net/wireless/ath/ath9k/eeprom.c | 27 ++-
drivers/net/wireless/ath/ath9k/eeprom.h | 75 ++
drivers/net/wireless/ath/ath9k/eeprom_4k.c | 94 +-
This replaces a magic number with a named #define. Additionally it
removes two "eeprom format" specific #defines for the "big endianness"
bit which are the same on all eeprom formats.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
driv
more.
[0]
https://github.com/freebsd/freebsd/blob/50719b56d9ce8d7d4beb53b16e9edb2e9a4a7a18/sys/dev/ath/ath_hal/ah_eeprom_9287.c#L351
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
drivers/net/wireless/ath/ath9k/eeprom.c | 57 -
1 fil
This allows deciding if we have to swap the EEPROM data (so it matches
the system's native endianness) even if no byte-swapping (swab16, based on
the first two bytes in the EEPROM) is needed.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
drivers/net/wirele
MINOR_MASK.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
drivers/net/wireless/ath/ath9k/eeprom.h | 4 +--
drivers/net/wireless/ath/ath9k/eeprom_4k.c | 32 ++
drivers/net/wireless/ath/ath9k/eeprom_9287.c | 19 +++--
drivers/
get_eeprom(ah, EEP_MINOR_REV) and get_eeprom_rev(ah) are both doing the
same thing: returning the EEPROM revision (12 lowest bits). Make the
code consistent by using get_eeprom_rev(ah) everywhere.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
drivers/net/wi
state that the values
are little endian - there are no functional changes with this patch.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 10 +-
drivers/net/wireless/ath/ath9k/ar9003_eeprom.h | 3 +++
2
b16e9edb2e9a4a7a18/sys/dev/ath/ath_hal/ah_eeprom_9287.c#L351
[4] https://marc.info/?l=linux-wireless=147544488619822=2
Martin Blumenstingl (7):
ath9k: Add a #define for the EEPROM "eepmisc" endianness bit
ath9k: indicate that the AR9003 EEPROM template values are little
endia
etree to
ath9k_platform_data" (for example in OpenWrt and LEDE) which becomes
obsolete with this patch.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
drivers/net/wireless/ath/ath9k/init.c | 42 +++
1 file changed, 42 insertions(+)
diff --g
Add documentation how devicetree can be used to configure ath9k based
devices.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
.../devicetree/bindings/net/wireless/qca,ath9k.txt | 30 ++
1 file changed, 30 insertions(+)
create mode
This can be used when the ath_bus_type has to be presented in a log
message or firmware filename.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
drivers/net/wireless/ath/ath.h | 6 ++
drivers/net/wireless/ath/main.c | 7 +++
2 files changed, 13 inse
On Fri, Sep 16, 2016 at 2:45 PM, Rob Herring <r...@kernel.org> wrote:
> On Fri, Sep 09, 2016 at 10:57:06PM +0200, Martin Blumenstingl wrote:
>> On Fri, Sep 9, 2016 at 9:48 AM, Oleksij Rempel <li...@rempel-privat.de>
>> wrote:
>> >> +Optional prope
On Fri, Sep 9, 2016 at 9:48 AM, Oleksij Rempel wrote:
>> +Optional properties:
>> +- reg: Address and length of the register set for the device.
>> +- qca,clk-25mhz: Defines that a 25MHz clock is used
>
> Some SoCs even Atheros WiSoCs use WiFi clock for System Clock. In
in the documentation (keeping it at a bare
minimum: removed the PCI bridge, use a better real-world example with
less-confusing device/fn numbers, added the actual size of the config
space to the reg property)
Martin Blumenstingl (3):
Documentation: dt: net: add ath9k wireless device binding
ath9k
This can be used when the ath_bus_type has to be presented in a log
message or firmware filename.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
drivers/net/wireless/ath/ath.h | 6 ++
drivers/net/wireless/ath/main.c | 7 +++
2 files changed, 13 inse
This allows configuring ath9k based PCI devices using devicetree.
There is some out-of-tree code to "convert devicetree to
ath9k_platform_data" (for example in OpenWrt and LEDE) which becomes
obsolete with this patch.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@g
Add documentation how devicetree can be used to configure ath9k based
devices.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
.../devicetree/bindings/net/wireless/qca,ath9k.txt | 39 ++
1 file changed, 39 insertions(+)
create mode
On Mon, Aug 22, 2016 at 1:52 PM, Arnd Bergmann <a...@arndb.de> wrote:
> On Sunday, August 21, 2016 4:49:06 PM CEST Martin Blumenstingl wrote:
>> +- qca,check-eeprom-endianness: When enabled, the driver checks if the
>> + endianness of the EEP
On Mon, Aug 22, 2016 at 11:08 AM, Arnd Bergmann <a...@arndb.de> wrote:
> On Sunday, August 21, 2016 4:31:03 PM CEST Martin Blumenstingl wrote:
>> +pci {
>> + pcie@0 {
>> + reg = <0 0 0 0 0>;
>
> It's not clear what these two nodes re
On Mon, Aug 22, 2016 at 5:31 PM, Arnd Bergmann <a...@arndb.de> wrote:
> On Monday, August 22, 2016 1:56:46 PM CEST Martin Blumenstingl wrote:
>> On Mon, Aug 22, 2016 at 1:47 PM, Arnd Bergmann <a...@arndb.de> wrote:
>> > On Sunday, August 21, 2016 4:49:03 PM CEST Marti
On Mon, Aug 22, 2016 at 1:47 PM, Arnd Bergmann <a...@arndb.de> wrote:
> On Sunday, August 21, 2016 4:49:03 PM CEST Martin Blumenstingl wrote:
>> We will default to the system's native endianness for the eepmisc value.
>> This may be overwritten by the ac
This allows configuring ath9k based PCI devices using devicetree.
There is some out-of-tree code to "convert devicetree to
ath9k_platform_data" (for example in OpenWrt and LEDE) which becomes
obsolete with this patch.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@g
The endianness swapping is disabled by default since many devices have
EEPROMs with incorrect endianness magic bytes (at the beginning).
Devices where the EEPROM is known to indicate the correct endianness
can enable the new flag to enable swapping when required.
This behavior is consistent with
There are two ways of swapping the EEPROM data in the ath9k driver:
1) swab16 based on the first two EEPROM "magic" bytes (same for all
EEPROM formats)
2) field and EEPROM format specific swab16/swab32 (different for
eeprom_def, eeprom_4k and eeprom_9287)
The result of the first check was
This allows deciding if we have to swap the EEPROM data (so it matches
the system's native endianness) even if no byte-swapping (swab16, based on
the first two bytes in the EEPROM) is needed.
---
drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 8 +++-
drivers/net/wireless/ath/ath9k/eeprom.h
We will default to the system's native endianness for the eepmisc value.
This may be overwritten by the actual calibration data. If it is not
overwritten we interpret the template data in it's native endianness,
meaning that no swapping is required.
---
This replaces a magic number with a named #define. Additionally it
removes two "eeprom format" specific #defines for the "big endianness"
bit which are the same on all eeprom formats.
---
drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 3 ++-
drivers/net/wireless/ath/ath9k/ar9003_eeprom.h | 1 -
nics.net/lists/linux-wireless/msg152634.html
[1] https://marc.info/?l=linux-wireless=147178988827847=2
Martin Blumenstingl (5):
ath9k: Add a #define for the EEPROM "eepmisc" endianness bit
ath9k: Set the "big endian" bit of the AR9003 EEPROM templates
ath9k: Add an eeprom
This can be used when the ath_bus_type has to be presented in a log
message or firmware filename.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
drivers/net/wireless/ath/ath.h | 6 ++
drivers/net/wireless/ath/main.c | 7 +++
2 files changed, 13 inse
eprom-endianness" for now - this will be part
of a separate patch
- update documentation to fix the "compatible" string (as there is a
PCI device specific format)
Martin Blumenstingl (3):
Documentation: dt: net: add ath9k wireless device binding
ath9k: add a helper to get the s
On Mon, Jul 11, 2016 at 12:01 AM, Arnd Bergmann wrote:
>> ath9k reads the data from the EEPROM into memory. With that property
>> disabled ath9k simply assumes that the endianness of the values in the
>> EEPROM are having the correct endianness for the host system (in other
>>
On Sun, Jul 10, 2016 at 2:19 AM, Bjørn Mork <bj...@mork.no> wrote:
> Martin Blumenstingl <martin.blumensti...@googlemail.com> writes:
>
>> + if (of_property_read_bool(np, "qca,clk-25mhz"))
>> + ah->is_clk_25mhz = true;
>> +
>>
On Sun, Jul 10, 2016 at 10:52 PM, Arnd Bergmann <a...@arndb.de> wrote:
> On Sunday, July 10, 2016 1:28:32 AM CEST Martin Blumenstingl wrote:
>> +- qca,check-eeprom-endianness: When enabled, the driver checks if the
>> + endianness of the EEP
This makes it possible to configure ath9k based devices using
devicetree. That makes some out-of-tree "convert devicetree to
ath9k_platform_data glue"-code obsolete.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
drivers/net/wireless/ath/a
nted
out typos.
- use an array for accessing the string representation of the bus types
(as suggested by Felix)
Martin Blumenstingl (3):
Documentation: dt: net: add ath9k wireless device binding
ath9k: add a helper to get the string representation of ath_bus_type
ath9k: parse
This can be used when the ath_bus_type has to be presented in a log
message or firmware filename.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
drivers/net/wireless/ath/ath.h | 6 ++
drivers/net/wireless/ath/main.c | 7 +++
2 files changed, 13 inse
Add documentation how devicetree can be used to configure ath9k based
devices.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
.../devicetree/bindings/net/wireless/qca,ath9k.txt | 59 ++
1 file changed, 59 insertions(+)
create mode
tform_data.
With this change all eeprom data handling is now unified in eeprom.c.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
Changes since v1:
- rebased to currrent ath.git/ath-next to resolve a small merge
conflict with commit
"0f27ac40fb64 ath9k: retu
Hello,
I have a question regarding the ath9k EEPROM format.
Most EEPROM versions have two magic bytes at the beginning, indicating
the endianness of the data in this EEPROM.
Let's take the AR9287 EEPROM as an example:
during ath9k initialization
ath9k/eeprom_9287.c:ath9k_hw_ar9287_check_eeprom
On Mon, Jun 27, 2016 at 12:26 PM, Felix Fietkau <n...@nbd.name> wrote:
> On 2016-06-24 14:34, Martin Blumenstingl wrote:
>> Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
>> ---
>> this is a new patch which didn't exist in v2 yet
On Mon, Jun 27, 2016 at 2:57 PM, Mark Rutland wrote:
>> > Please find a better way to identify relevant FW. What exactly affects
>> > which FW can be used, or would ideally be used? Are different FWs
>> > required for the same HW in some contexts?
>> >
>> > Can we not figure
On Sat, Jun 25, 2016 at 9:26 PM, Christian Lamparter
wrote:
> The problem with the owl-loader is/was that it sticks around
> when it has initialized all the cards. Unloading a module by
> itself is tough. One way out would be to add it to ath9k's pci.c.
> The question is:
On Sat, Jun 25, 2016 at 2:01 PM, Christian Lamparter
<chunk...@googlemail.com> wrote:
> On Friday, June 24, 2016 02:34:30 PM Martin Blumenstingl wrote:
>> This makes it possible to configure ath9k based devices using
>> devicetree. That makes some out-of-tre
This makes it possible to configure ath9k based devices using
devicetree. That makes some out-of-tree "convert devicetree to
ath9k_platform_data glue"-code obsolete.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
changes in v2 -> v3:
- repla
Add documentation how devicetree can be used to configure ath9k based
devices.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
changes in v2 -> v3:
- improved wording of the qca,disable-2ghz and qca,disable-5ghz properties
- replaced qca,eeprom-name with qca,
This series adds support for configuring ath9k based devices via
devicetree. This was tested on PCI(e) based devices. This should work
for AHB based devices as well as soon as the ath79 platform is ready
to populate the ath9k wmac via devicetree.
This series depends on my previous series:
"ath9k:
On Thu, Jun 23, 2016 at 9:25 PM, Arend Van Spriel
wrote:
>> +Optional properties:
>> +- reg: Address and length of the register set for the device.
>
> Is 'reg' property handled. I don't see it in patch 2/2.
for AHB we would probably have to handle it separately, but
On Thu, Jun 23, 2016 at 7:58 PM, Mark Rutland <mark.rutl...@arm.com> wrote:
> On Thu, Jun 23, 2016 at 07:45:35PM +0200, Martin Blumenstingl wrote:
>> Add documentation how devicetree can be used to configure ath9k based
>> devices.
>>
>> Signed-off-by: Mart
This makes it possible to configure ath9k based devices using
devicetree. That makes some out-of-tree "convert devicetree to
ath9k_platform_data glue"-code obsolete.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
changes in v1 -> v2:
- use vendor p
Add documentation how devicetree can be used to configure ath9k based
devices.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
changes in v1 -> v2:
- use vendor prefix "qca" instead of "ath"
- extend the example so it includes the "com
This series adds support for configuring ath9k based devices via
devicetree. This was tested on PCI(e) based devices. This should work
for AHB based devices as well as soon as the ath79 platform is ready
to populate the ath9k wmac via devicetree.
This series depends on my previous series:
"ath9k:
This series improves handling of ath9k_platform_data inside ath9k. A
quick summary of the changes is:
- led_active_high can now be configured via ath9k_platform_data:
This change is based on a patch originally written by Vittorio
Gambaletta which is part of OpenWrt's ath9k patches.
- small
Some devices running OpenWrt need this and it makes sense to add this
to ath9k_platform_data as the next patches will add a devicetree
(boolean) property for it as well.
Suggested-by: Vittorio Gambaletta <open...@vittgam.net>
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googl
No functional changes - this only removes a variable which is set but
never read.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
drivers/net/wireless/ath/ath9k/hw.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/hw.c
b/d
This makes it possible to configure ath9k based devices using
devicetree. That makes some out-of-tree "convert devicetree to
ath9k_platform_data glue"-code obsolete.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
drivers/net/wireless/ath/a
No functional changes, this simply makes the code easier to understand
because all initialization based on ath9k_platform_data is now within
one function.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
drivers/net/wireless/ath/ath9k/init.
Add documentation how devicetree can be used to configure ath9k based
devices.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
.../devicetree/bindings/net/wireless/ath,ath9k.txt | 40 ++
1 file changed, 40 insertions(+)
create mode
This series adds support for configuring ath9k based devices via
devicetree. This was tested on PCI(e) based devices. This should work
for AHB based devices as well as soon as the ath79 platform is ready
to populate the ath9k wmac via devicetree.
This series depends on my previous series:
"ath9k:
Currently setting the MAC address via ath9k_platform_data works only due
to the order in which init.c sets common->macaddr, which is done after
ath9k_hw_init_macaddr was executed. It would be better if the latter
was independent of the order in which it's being called.
Signed-off-by: Mar
tform_data.
With this change all eeprom data handling is now unified in eeprom.c.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
This supersedes the following patch by Eduardo Abinader
<eduardo.abina...@riverbed.com>:
"ath9k: return false when reading
ath9k_hw_init_macaddr unconditionally returns 0 in all cases, making the
return value unnecessary.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
drivers/net/wireless/ath/ath9k/hw.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff
ifics from the other implementations.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
V2: Use the AH_NO_EEP_SWAP flag to decide if swapping is required.
If this flag is set then we assume that the contents of the
EEPROM are using the correct endianness even
On Thu, Oct 15, 2015 at 12:33 AM, Martin Blumenstingl
<martin.blumensti...@googlemail.com> wrote:
> I have tested my patch on a single AR9227 device and there it's
> working fine. It would be great if more people would give this a go
> before merging this patch.
I have just tested
ath9k has some code which is supposed to adjust the endianness of the
eeprom's contents in case it does not match the CPU endianness.
However, it seems that this code was only working properly for chips
that used eeprom_def.
I personally have a device with an AR9227 chipset which uses an
eeprom
ifics from the other implementations.
Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
---
drivers/net/wireless/ath/ath9k/eeprom.c | 75 +++
drivers/net/wireless/ath/ath9k/eeprom.h | 3 ++
drivers/net/wireless/ath/ath9k/ee
79 matches
Mail list logo