Re: [ath9k-devel] [PATCH] ath9k: Prevent radar detection and spectral scan to be used concurrently

2016-11-21 Thread Michal Kazior
On 21 November 2016 at 15:41, Zefir Kurtisi wrote: > On 11/21/2016 03:04 PM, Benjamin Berg wrote: >> In the case that a spectral scan is enabled the PHY errors sent by the >> hardware as part of the scanning might trigger the radar detection and >> channels might be

Re: [ath9k-devel] [PATCH] ath9k: Prevent radar detection and spectral scan to be used concurrently

2016-11-21 Thread Michal Kazior
On 21 November 2016 at 15:04, Benjamin Berg wrote: > In the case that a spectral scan is enabled the PHY errors sent by the > hardware as part of the scanning might trigger the radar detection and > channels might be marked as 'unusable' incorrectly. This patch fixes >

Re: [ath9k-devel] [Make-wifi-fast] [RFC/RFT 5/5] ath9k: Count RX airtime in airtime deficit

2016-06-13 Thread Michal Kazior
On 10 June 2016 at 10:53, Toke Høiland-Jørgensen wrote: > >>> I initially thought that using the timestamp put into the frame by the >>> hardware could be a way to get timing. But there's only a timestamp of >>> the first symbol in rs_tstamp, and getting a time to compare it with is

Re: [ath9k-devel] [Make-wifi-fast] [RFC/RFT 5/5] ath9k: Count RX airtime in airtime deficit

2016-06-13 Thread Michal Kazior
On 10 June 2016 at 11:08, Toke Høiland-Jørgensen <t...@toke.dk> wrote: > Michal Kazior <michal.kaz...@tieto.com> writes: > >> For A-MPDU all MPDU rx status (except last one) should share the same >> timestamp. Last one has a different one so all you need is to >

Re: [ath9k-devel] [Make-wifi-fast] [RFC] ath9k: Measure per-station airtime usage

2016-05-30 Thread Michal Kazior
On 26 May 2016 at 15:50, Toke Høiland-Jørgensen wrote: > This is my attempt to add per-station airtime usage accounting to ath9k. > For now I just export it to a new debugfs entry, but my plan is to use > it to make (station) scheduling decisions. However, before attempting > that I

[ath9k-devel] [PATCH] ath9k: fix moredata flag endianness in cabq tx

2015-07-09 Thread Michal Kazior
that would never come. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath9k/xmit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c index 3ad79bb4f2c2..d8cc45106f85

Re: [ath9k-devel] [PATCH 1/3] ath9k: handle RoC abort correctly

2015-06-22 Thread Michal Kazior
On 22 June 2015 at 13:56, Krishna Chaitanya chaitanya.m...@gmail.com wrote: On Mon, Jun 22, 2015 at 5:13 PM, Janusz Dziedzic janusz.dzied...@tieto.com wrote: In case we will get ROC abort we should not call ieee80211_remain_on_channel_expired(). In other case I hit such warning on MIPS and

Re: [ath9k-devel] Connecting multiple times to same base station

2015-06-15 Thread Michal Kazior
On 15 June 2015 at 09:47, Kilian Risse kri...@student.ethz.ch wrote: Hi all I tried to simulate multiple clients through a single ar93xx card. I noticed that even though I connect with the base station multiple times through several interfaces, the MAC address with which I send packets (and

Re: [ath9k-devel] test on latest hostapd with acs

2013-09-20 Thread Michal Kazior
On 18 September 2013 17:17, Sarah Rumpel sarah.rum...@barco.com wrote: I figured out that I always have this issue with the large numbers on the channel in use. I can prove this and my results by using iw dev wlan0 survey dump. So it seems like these results of acs are correct, but the driver

Re: [ath9k-devel] test on latest hostapd with acs

2013-09-18 Thread Michal Kazior
On 18 September 2013 09:49, Sarah Rumpel sarah.rum...@barco.com wrote: Hi, Hi Sarah, I did some tests on the latest hosapd with ACS (commit 50f4f2a066e60be7cc03e291635e9a0f953922bd 31 Aug 2013). I ran it without and with additionally generated continuous interference on channel 11, but I

Re: [ath9k-devel] [PATCH v3 1/9] ath10k: decouple pci start/stop logic

2013-07-05 Thread Michal Kazior
On 5 July 2013 08:29, Kalle Valo kv...@qca.qualcomm.com wrote: Michal Kazior michal.kaz...@tieto.com writes: Split logic that prepares the device for BMI phase/cleans up related resources. This is necessary for ath10k to be able to restart hw on the fly without reloading the module

Re: [ath9k-devel] [PATCH v3 5/9] ath10k: decouple suspend code

2013-07-05 Thread Michal Kazior
On 5 July 2013 08:51, Kalle Valo kv...@qca.qualcomm.com wrote: Michal Kazior michal.kaz...@tieto.com writes: +#ifdef CONFIG_PM +static int ath10k_suspend(struct ieee80211_hw *hw, + struct cfg80211_wowlan *wowlan) +{ + struct ath10k *ar = hw-priv; + int ret

Re: [ath9k-devel] [PATCH v2 1/3] ath10k: implement device recovery

2013-07-05 Thread Michal Kazior
On 5 July 2013 09:47, Kalle Valo kv...@qca.qualcomm.com wrote: Michal Kazior michal.kaz...@tieto.com writes: Restart the hardware if FW crashes. If FW crashes during recovery we leave the hardware in a wedged state to avoid recursive recoveries. When in wedged state userspace may bring

Re: [ath9k-devel] Anyone tried using the QCA9880 NIC from the TPLINK AC1750 AP?

2013-06-27 Thread Michal Kazior
On 27 June 2013 05:14, Ben Greear gree...@candelatech.com wrote: I've already got a few v1 APs on order, maybe they will at least give me something to get started with. If you are at liberty to say, what sorts of issues should I expect with the v1? Or perhaps a better question: How is the

[ath9k-devel] [PATCH v3 2/9] ath10k: decouple core start/stop logic

2013-06-25 Thread Michal Kazior
Enables code reuse for proper hw reconfiguration that is in turn required for proper suspend/hibernation/wowlan support. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.c | 44 +++- drivers/net/wireless/ath/ath10k/core.h

[ath9k-devel] [PATCH v3 1/9] ath10k: decouple pci start/stop logic

2013-06-25 Thread Michal Kazior
Split logic that prepares the device for BMI phase/cleans up related resources. This is necessary for ath10k to be able to restart hw on the fly without reloading the module. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/hif.h | 20 ++ drivers

[ath9k-devel] [PATCH v3 3/9] ath10k: allow deferred regd update

2013-06-25 Thread Michal Kazior
Regulatory domain notification hook can be called regardless of the hw state (i.e. before start mac80211 callback). Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.h |7 +++ drivers/net/wireless/ath/ath10k/mac.c | 26

[ath9k-devel] [PATCH v3 4/9] ath10k: reset BMI state upon init

2013-06-25 Thread Michal Kazior
This is necessary if we want to be able to restart hw on-the-fly. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/bmi.c |6 ++ drivers/net/wireless/ath/ath10k/bmi.h |1 + drivers/net/wireless/ath/ath10k/core.c |2 ++ 3 files changed, 9

[ath9k-devel] [PATCH v3 6/9] ath10k: move free_vdev_map initialization

2013-06-25 Thread Michal Kazior
This is necessary for hw reconfiguration to work. Since mac80211 is not calling remove_interface() is such case we must reset free_vdev_map. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[ath9k-devel] [PATCH v3 0/9] ath10k: device setup refactor

2013-06-25 Thread Michal Kazior
from that patchset. Michal Kazior (9): ath10k: decouple pci start/stop logic ath10k: decouple core start/stop logic ath10k: allow deferred regd update ath10k: reset BMI state upon init ath10k: decouple suspend code ath10k: move free_vdev_map initialization ath10k: make sure all

[ath9k-devel] [PATCH v3 9/9] ath10k: store firmware files in memory

2013-06-25 Thread Michal Kazior
Different FW versions may provide different functions thus mean different hw capabilities advertised to mac80211. It is safe to swap firmware files on disk during driver/device runtime without worries. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k

[ath9k-devel] [PATCH v3 8/9] ath10k: defer hw setup to start/stop mac80211 hooks

2013-06-25 Thread Michal Kazior
be initialized once before registering to mac80211 because FW determinates what hw capabilities can be advertised. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.c | 46 +- drivers/net/wireless/ath/ath10k/mac.c | 56

[ath9k-devel] [PATCH v3 7/9] ath10k: make sure all resources are freed upon ath10k_stop()

2013-06-25 Thread Michal Kazior
This is necessary for proper hw reconfiguration and to avoid memory leaks. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/mac.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b

[ath9k-devel] [PATCH v3 5/9] ath10k: decouple suspend code

2013-06-25 Thread Michal Kazior
low-power mode. In case WoW is not available mac80211 will go through regular interface teradown and use start/stop. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.c | 28 - drivers/net/wireless/ath/ath10k/core.h |3 - drivers/net/wireless/ath

[ath9k-devel] [PATCH v3 10/10] ath10k: skip fw stats debugfs interface if device is down

2013-06-25 Thread Michal Kazior
Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- I've missed this patch. It should go along with this patchset. Sorry for the mess. drivers/net/wireless/ath/ath10k/debug.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/drivers/net

[ath9k-devel] [PATCH v2 0/3] ath10k: hardware recovery

2013-06-25 Thread Michal Kazior
Respin of hw recovery. I've addressed some issues raised in the previous review. I haven't found a way to address the 'scattered logic' issue (i.e. the way restart_work is handled). Michal Kazior (3): ath10k: implement device recovery ath10k: implement fw crash simulation command ath10k

[ath9k-devel] [PATCH v2 1/3] ath10k: implement device recovery

2013-06-25 Thread Michal Kazior
-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.c | 30 ++ drivers/net/wireless/ath/ath10k/core.h | 16 + drivers/net/wireless/ath/ath10k/htc.c |3 + drivers/net/wireless/ath/ath10k/mac.c | 101 ++-- drivers

[ath9k-devel] [PATCH v2 2/3] ath10k: implement fw crash simulation command

2013-06-25 Thread Michal Kazior
This can be useful to test FW crash handling. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/wmi.c | 19 +++ drivers/net/wireless/ath/ath10k/wmi.h | 19 +++ 2 files changed, 38 insertions(+) diff --git a/drivers/net

[ath9k-devel] [PATCH v2 3/3] ath10k: create debugfs interface to trigger fw crash

2013-06-25 Thread Michal Kazior
This can be useful for testing. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/debug.c | 54 +++ 1 file changed, 54 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k

[ath9k-devel] [PATCH] ath10k: fix MSI-X setup failpath

2013-06-25 Thread Michal Kazior
Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/pci.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 1a59638..63c58b5 100644 --- a/drivers/net

[ath9k-devel] [PATCH 1/3] ath10k: prevent HTC from being used after stopping

2013-06-24 Thread Michal Kazior
It was possible to submit new HTC commands after/while HTC stopped. This led to memory corruption in some rare cases. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/htc.c | 28 +--- drivers/net/wireless/ath/ath10k/htc.h |4

[ath9k-devel] [PATCH 0/3] ath10k: fixes

2013-06-24 Thread Michal Kazior
Michal Kazior (3): ath10k: prevent HTC from being used after stopping ath10k: fix 5ghz channel definitions ath10k: leave MMIC generation to the HW drivers/net/wireless/ath/ath10k/htc.c | 28 +-- drivers/net/wireless/ath/ath10k/htc.h |4 +-- drivers/net/wireless/ath

[ath9k-devel] [PATCH 3/3] ath10k: leave MMIC generation to the HW

2013-06-24 Thread Michal Kazior
Apparently HW doesn't require us to generate MMIC for TKIP suite. This fixes issues with some APs. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/mac.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b

[ath9k-devel] [PATCH 2/3] ath10k: fix 5ghz channel definitions

2013-06-24 Thread Michal Kazior
Nonsense channel flags were being set. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/mac.c | 48 - 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net

Re: [ath9k-devel] [PATCH 5/6] ath10k: wait for CE to drain when shutting down

2013-06-14 Thread Michal Kazior
On 13/06/13 20:08, Kalle Valo wrote: Michal Kazior michal.kaz...@tieto.com writes: ath10k_pci_process_ce() is used to process completions. Only one thread can do that though. If one thread starts handling completions then the other one (i.e. possibly PCI shutdown) would exit immediatelely

Re: [ath9k-devel] [PATCH v2 01/10] ath10k: decouple pci init/deinit logic

2013-06-14 Thread Michal Kazior
the aforementioned proper alloc/init/setup separation to be done first. -- Pozdrawiam / Best regards, Michal Kazior. ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH v2 03/10] ath10k: allow deferred regd update

2013-06-14 Thread Michal Kazior
On 13/06/13 20:08, Kalle Valo wrote: Michal Kazior michal.kaz...@tieto.com writes: Regulatory domain notification hook can be called regardless of the hw state (i.e. before start mac80211 callback). We should have the same check also in debugfs files, right? Good catch. As always, thanks

Re: [ath9k-devel] [PATCH v2 08/10] ath10k: defer hw setup to start/stop mac80211 hooks

2013-06-14 Thread Michal Kazior
On 14/06/13 14:23, Kalle Valo wrote: Michal Kazior michal.kaz...@tieto.com writes: [...] static int ath10k_start(struct ieee80211_hw *hw) { struct ath10k *ar = hw-priv; -int ret; +int ret = 0; mutex_lock(ar-conf_mutex); +if (ar-state != ATH10K_STATE_OFF

Re: [ath9k-devel] [PATCH 3/3] ath10k: create debugfs interface to trigger fw crash

2013-06-14 Thread Michal Kazior
On 14/06/13 14:34, Kalle Valo wrote: Michal Kazior michal.kaz...@tieto.com writes: This can be useful for testing. Signed-off-by: Michal Kazior michal.kaz...@tieto.com This is handy. +static ssize_t ath10k_read_simulate_fw_crash(struct file *file

[ath9k-devel] [PATCH 1/6] ath10k: embed HTC struct inside ath10k

2013-06-12 Thread Michal Kazior
This reduces number of allocations and simplifies memory managemnt. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.c | 28 drivers/net/wireless/ath/ath10k/core.h |2 +- drivers/net/wireless/ath/ath10k/htc.c

[ath9k-devel] [PATCH 4/6] ath10k: abort scan properly if wmi_scan_stop fails

2013-06-12 Thread Michal Kazior
Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/mac.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index def1e68..4867f30 100644 --- a/drivers/net/wireless/ath

[ath9k-devel] [PATCH 0/6] ath10k: fixes

2013-06-12 Thread Michal Kazior
This includes 2 patches from my previous patchset that had conflicts. It is now rebased and should apply cleanly on the github master branch. Michal Kazior (6): ath10k: embed HTC struct inside ath10k ath10k: embed HTT struct inside ath10k ath10k: improve locking ath10k: abort scan

[ath9k-devel] [PATCH 3/6] ath10k: improve locking

2013-06-12 Thread Michal Kazior
Add more lockdep asserts and a few conf_mutex locks. It's better to be on the safe side. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/mac.c | 57 +++-- 1 file changed, 55 insertions(+), 2 deletions(-) diff --git a/drivers

[ath9k-devel] [PATCH 6/6] ath10k: add missing debug prints

2013-06-12 Thread Michal Kazior
Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/wmi.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index 681e941..b7e7e45 100644 --- a/drivers/net/wireless/ath

[ath9k-devel] [PATCH 2/6] ath10k: embed HTT struct inside ath10k

2013-06-12 Thread Michal Kazior
This reduces number of allocations and simplifies memory managemnt. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.c | 12 ++-- drivers/net/wireless/ath/ath10k/core.h |7 +++ drivers/net/wireless/ath/ath10k/htt.c| 25

[ath9k-devel] [PATCH 5/6] ath10k: wait for CE to drain when shutting down

2013-06-12 Thread Michal Kazior
-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/pci.c | 21 + drivers/net/wireless/ath/ath10k/pci.h |2 +- 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath

[ath9k-devel] [PATCH v2 01/10] ath10k: decouple pci init/deinit logic

2013-06-12 Thread Michal Kazior
Split logic that prepares the device for BMI phase/cleans up related resources. This is necessary for ath10k to be able to restart hw on the fly without reloading the module. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/hif.h | 20 ++ drivers

[ath9k-devel] [PATCH v2 02/10] ath10k: decouple core start/stop logic

2013-06-12 Thread Michal Kazior
Enables code reuse for proper hw reconfiguration that is in turn required for proper suspend/hibernation/wowlan support. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.c | 44 +++- drivers/net/wireless/ath/ath10k/core.h

[ath9k-devel] [PATCH v2 00/10] ath10k: device setup refactor

2013-06-12 Thread Michal Kazior
for easier review. Michal Kazior (10): ath10k: decouple pci init/deinit logic ath10k: decouple core start/stop logic ath10k: allow deferred regd update ath10k: reset BMI state upon init ath10k: decouple suspend code ath10k: move free_vdev_map initialization ath10k: make sure all

[ath9k-devel] [PATCH v2 03/10] ath10k: allow deferred regd update

2013-06-12 Thread Michal Kazior
Regulatory domain notification hook can be called regardless of the hw state (i.e. before start mac80211 callback). Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.h |7 +++ drivers/net/wireless/ath/ath10k/mac.c | 26

[ath9k-devel] [PATCH v2 06/10] ath10k: move free_vdev_map initialization

2013-06-12 Thread Michal Kazior
This is necessary for hw reconfiguration to work. Since mac80211 is not calling remove_interface() is such case we must reset free_vdev_map. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[ath9k-devel] [PATCH v2 04/10] ath10k: reset BMI state upon init

2013-06-12 Thread Michal Kazior
This is necessary if we want to be able to restart hw on-the-fly. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/bmi.c |6 ++ drivers/net/wireless/ath/ath10k/bmi.h |1 + drivers/net/wireless/ath/ath10k/core.c |2 ++ 3 files changed, 9

[ath9k-devel] [PATCH v2 07/10] ath10k: make sure all resources are freed upon ath10k_stop()

2013-06-12 Thread Michal Kazior
This is necessary for proper hw reconfiguration and to avoid memory leaks. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/mac.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net

[ath9k-devel] [PATCH v2 05/10] ath10k: decouple suspend code

2013-06-12 Thread Michal Kazior
low-power mode. In case WoW is not available mac80211 will go through regular interface teradown and use start/stop. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.c | 28 - drivers/net/wireless/ath/ath10k/core.h |3 - drivers/net/wireless/ath

[ath9k-devel] [PATCH v2 08/10] ath10k: defer hw setup to start/stop mac80211 hooks

2013-06-12 Thread Michal Kazior
be initialized once before registering to mac80211 because FW determinates what hw capabilities can be advertised. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.c | 46 +--- drivers/net/wireless/ath/ath10k/core.h |1 + drivers

[ath9k-devel] [PATCH v2 09/10] ath10k: skip updating some params during resume

2013-06-12 Thread Michal Kazior
ath10k handles some hw configuration per-vdev (i.e. per-vif). When resuming/restarting hw configuration vdevs may not be re-added yet. Setting vdev params for non existent vdevs crashes the firmware. The parameters are updated when interface is re-added. Signed-off-by: Michal Kazior michal.kaz

[ath9k-devel] [PATCH v2 10/10] ath10k: store firmware files in memory

2013-06-12 Thread Michal Kazior
Different FW versions may provide different functions thus mean different hw capabilities advertised to mac80211. It is safe to swap firmware files on disk during driver/device runtime without worries. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k

[ath9k-devel] [PATCH 0/3] ath10k: hardware recovery

2013-06-12 Thread Michal Kazior
'. Split for easier review. Michal Kazior (3): ath10k: implement device recovery ath10k: implement fw crash simulation command ath10k: create debugfs interface to trigger fw crash drivers/net/wireless/ath/ath10k/core.c | 30 drivers/net/wireless/ath/ath10k/core.h

[ath9k-devel] [PATCH 2/3] ath10k: implement fw crash simulation command

2013-06-12 Thread Michal Kazior
This can be useful to test FW crash handling. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/wmi.c | 19 +++ drivers/net/wireless/ath/ath10k/wmi.h | 19 +++ 2 files changed, 38 insertions(+) diff --git a/drivers/net

[ath9k-devel] [PATCH 1/3] ath10k: implement device recovery

2013-06-12 Thread Michal Kazior
-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.c | 30 ++ drivers/net/wireless/ath/ath10k/core.h |3 +++ drivers/net/wireless/ath/ath10k/htc.c |3 +++ drivers/net/wireless/ath/ath10k/mac.c | 32

Re: [ath9k-devel] [PATCH 03/10] ath10k: allow deferred regd update

2013-06-10 Thread Michal Kazior
On 10/06/13 18:56, Kalle Valo wrote: Michal Kazior michal.kaz...@tieto.com writes: Regulatory domain notification hook can be called regardless of the hw state (i.e. before start mac80211 callback). Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k

Re: [ath9k-devel] [PATCH 02/10] ath10k: decouple core init/deinit logic

2013-06-10 Thread Michal Kazior
On 10/06/13 18:53, Kalle Valo wrote: Michal Kazior michal.kaz...@tieto.com writes: Enables code reuse for proper hw reconfiguration that is in turn required for proper suspend/hibernation/wowlan support. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Let's have a terminology check

Re: [ath9k-devel] [PATCH 09/10] ath10k: handle hw reconfiguration properly

2013-06-10 Thread Michal Kazior
On 10/06/13 19:08, Kalle Valo wrote: Michal Kazior michal.kaz...@tieto.com writes: If resume fails mac80211 calls start() hook without any other notification to the driver. If that happens we must make sure we free up and clean up our stuff. Signed-off-by: Michal Kazior michal.kaz

[ath9k-devel] [PATCH 1/4] ath10k: fix teardown ordering

2013-06-06 Thread Michal Kazior
This should fix memory corruption if HIF is tried to be restarted. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/pci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless

[ath9k-devel] [PATCH 0/4] ath10k: fixes

2013-06-06 Thread Michal Kazior
This is part 1 of 4 of a bigger patchset. Split for easier review. Contains functional fixes. Michal Kazior (4): ath10k: fix teardown ordering ath10k: fix possible deadlock ath10k: setup rts/frag thresholds upon vdev creation ath10k: do not setup rts/frag thresholds for suspended

[ath9k-devel] [PATCH 3/4] ath10k: setup rts/frag thresholds upon vdev creation

2013-06-06 Thread Michal Kazior
mac80211 configures rts/frag thresholds per-hw not per-vif. ath10k FW expects those values to be set per-vdev (i.e. per-vif). ath10k should now respect rts/frag thresholds set before a given interface was brought up. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless

[ath9k-devel] [PATCH 2/4] ath10k: fix possible deadlock

2013-06-06 Thread Michal Kazior
It was possible to have a deadlock due to inverted locking of local-iflist_mtx and ath10k-conf_mutex. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/mac.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net

[ath9k-devel] [PATCH 4/4] ath10k: do not setup rts/frag thresholds for suspended interfaces

2013-06-06 Thread Michal Kazior
mac80211 calls for rts/frag threshold hooks before any interface is brought back up again when resuming. We would set vdev parameters before given vdev is created lading to a FW crash. rts/frag thresholds will be re-set accordingly in add_interface() hook anyway. Signed-off-by: Michal Kazior

[ath9k-devel] [PATCH 1/7] ath10k: remove ath10k_bus

2013-06-06 Thread Michal Kazior
It serves no purpose. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.c |2 -- drivers/net/wireless/ath/ath10k/core.h |6 -- drivers/net/wireless/ath/ath10k/pci.c |3 +-- 3 files changed, 1 insertion(+), 10 deletions(-) diff --git

[ath9k-devel] [PATCH 0/7] ath10k: more fixes

2013-06-06 Thread Michal Kazior
This is part 2 of 4 of a bigger patchset. Split for easier review. Contains non-functional fixes. Note: it is not based on master branch. Michal Kazior (7): ath10k: remove ath10k_bus ath10k: fix typo in define name ath10k: silent warning in IBSS mode ath10k: lower print level

[ath9k-devel] [PATCH 2/7] ath10k: fix typo in define name

2013-06-06 Thread Michal Kazior
Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/ce.c |2 +- drivers/net/wireless/ath/ath10k/pci.c |6 +++--- drivers/net/wireless/ath/ath10k/pci.h |4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath

[ath9k-devel] [PATCH 4/7] ath10k: lower print level for a message

2013-06-06 Thread Michal Kazior
Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/htc.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/htc.c b/drivers/net/wireless/ath/ath10k/htc.c index 74363c9..7b5c334 100644 --- a/drivers/net

[ath9k-devel] [PATCH 3/7] ath10k: silent warning in IBSS mode

2013-06-06 Thread Michal Kazior
There is no TIM IE generated in IBSS beacons by mac80211. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/wmi.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath

[ath9k-devel] [PATCH 5/7] ath10k: provide errno if bmi read/write fails

2013-06-06 Thread Michal Kazior
Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/bmi.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/bmi.c b/drivers/net/wireless/ath/ath10k/bmi.c index 1a2ef51..aeae029 100644 --- a/drivers

[ath9k-devel] [PATCH 6/7] ath10k: change function to take struct ath10k as arg

2013-06-06 Thread Michal Kazior
This aligns it to the argument list of other similar functions. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/pci.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net

[ath9k-devel] [PATCH 7/7] ath10k: rename hif callback

2013-06-06 Thread Michal Kazior
The `set_callbacks` is a more appopriate name for the function. Let's leave `init` for something else. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/hif.h | 10 +- drivers/net/wireless/ath/ath10k/htc.c |2 +- drivers/net/wireless/ath

[ath9k-devel] [PATCH 00/10] ath10k: device setup refactor

2013-06-06 Thread Michal Kazior
doesn't work if resume fails (the device doesn't respond despite going through power-cycle/setup in the code; this is not a regression as it wasn't handled before at all) * wowlan is not supported, yet Note: it is not based on master branch. Michal Kazior (10): ath10k: decouple

[ath9k-devel] [PATCH 03/10] ath10k: allow deferred regd update

2013-06-06 Thread Michal Kazior
Regulatory domain notification hook can be called regardless of the hw state (i.e. before start mac80211 callback). Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.h |2 ++ drivers/net/wireless/ath/ath10k/mac.c | 23 ++- 2

[ath9k-devel] [PATCH 02/10] ath10k: decouple core init/deinit logic

2013-06-06 Thread Michal Kazior
Enables code reuse for proper hw reconfiguration that is in turn required for proper suspend/hibernation/wowlan support. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.c | 50 ++-- drivers/net/wireless/ath/ath10k/core.h

[ath9k-devel] [PATCH 06/10] ath10k: defer hw setup to start/stop mac80211 hooks

2013-06-06 Thread Michal Kazior
be initialized once before registering to mac80211 because FW determinates what hw capabilities can be advertised. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.c | 46 +--- drivers/net/wireless/ath/ath10k/mac.c | 15

[ath9k-devel] [PATCH 04/10] ath10k: reset BMI state upon init

2013-06-06 Thread Michal Kazior
This is necessary if we want to be able to restart hw on-the-fly. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k

[ath9k-devel] [PATCH 05/10] ath10k: decouple suspend code

2013-06-06 Thread Michal Kazior
low-power mode. In case WoW is not available mac80211 will go through regular interface teradown and use start/stop. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.c | 28 - drivers/net/wireless/ath/ath10k/core.h |3 - drivers/net/wireless/ath

[ath9k-devel] [PATCH 10/10] ath10k: move free_vdev_map initialization

2013-06-06 Thread Michal Kazior
This is necessary for hw reconfiguration to work. Since mac80211 is not calling remove_interface() is such case we must reset free_vdev_map. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions

[ath9k-devel] [PATCH 09/10] ath10k: handle hw reconfiguration properly

2013-06-06 Thread Michal Kazior
If resume fails mac80211 calls start() hook without any other notification to the driver. If that happens we must make sure we free up and clean up our stuff. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/mac.c |9 + 1 file changed, 9

[ath9k-devel] [PATCH 07/10] ath10k: store firmware files in memory

2013-06-06 Thread Michal Kazior
Different FW versions may provide different functions thus mean different hw capabilities advertised to mac80211. It is now impossible to swap firmware files. It is safe to swap firmware files on disk during driver/device runtime. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers

[ath9k-devel] [PATCH 08/10] ath10k: make sure all resources are freed upon ath10k_stop()

2013-06-06 Thread Michal Kazior
This is necessary for proper hw reconfiguration and to avoid memory leaks. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/mac.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c

[ath9k-devel] [PATCH 0/2] ath10k: cleanup

2013-06-06 Thread Michal Kazior
This is part 4 of 4 of a bigger patchset. Split for easier review. Note: it is not based on master branch. Michal Kazior (2): ath10k: embed HTC struct inside ath10k ath10k: embed HTT struct inside ath10k drivers/net/wireless/ath/ath10k/core.c | 40

[ath9k-devel] [PATCH 1/2] ath10k: embed HTC struct inside ath10k

2013-06-06 Thread Michal Kazior
This reduces number of allocations and simplifies memory managemnt. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.c | 28 drivers/net/wireless/ath/ath10k/core.h |2 +- drivers/net/wireless/ath/ath10k/htc.c

[ath9k-devel] [PATCH 2/2] ath10k: embed HTT struct inside ath10k

2013-06-06 Thread Michal Kazior
This reduces number of allocations and simplifies memory managemnt. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.c | 12 ++-- drivers/net/wireless/ath/ath10k/core.h |7 +++ drivers/net/wireless/ath/ath10k/htt.c| 24

Re: [ath9k-devel] [PATCH 05/10] ath10k: decouple suspend code

2013-06-06 Thread Michal Kazior
On 06/06/13 13:48, Sujith Manoharan wrote: Michal Kazior wrote: Split up fw-related and hw-related suspension code. Although we don't advertise WoW support to mac80211 yet it's useful to keep the code in suspend/resume hooks. At this point there's no need to keep pci pm ops. In case

Re: [ath9k-devel] [PATCH 6/7] ath10k: introduce proper htt tx flow control

2013-05-29 Thread Michal Kazior
On 28/05/13 17:06, Kalle Valo wrote: Michal Kazior michal.kaz...@tieto.com writes: There were cases where we'd run out of msdu_ids. This can be fixed by telling mac80211 to stop sending us more frames if we run out of resources. It was possible to trigger with massive TCP RX ~300mbps (e.g

[ath9k-devel] [PATCH] ath10k: fix sparse warning

2013-05-29 Thread Michal Kazior
The line was over 80 characters long. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/htt_tx.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/htt_tx.c b/drivers/net/wireless/ath/ath10k/htt_tx.c

[ath9k-devel] [PATCH] ath10k: fix hw scan cancelling

2013-05-22 Thread Michal Kazior
If mac80211 decides to cancel a hw scan and FW is not behaving properly (i.e. doesn't want to abort scan at all) we must call ieee80211_scan_completed(). Otherwise no more scans will be initiated, ever. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k

[ath9k-devel] [PATCH] ath10k: sync WMI interface to FW 636

2013-05-22 Thread Michal Kazior
Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/wmi.h | 32 1 file changed, 32 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h index f08dbb2..9555f5a 100644

Re: [ath9k-devel] [PATCH 6/6] ath10k: preliminary VHT support

2013-05-21 Thread Michal Kazior
regards, Michal Kazior. ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

[ath9k-devel] [PATCH] ath10k: program FW with appropriate regdomain

2013-05-17 Thread Michal Kazior
We already setup scan channel list upon regdomain update but we should also setup the regpair to the FW. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/mac.c | 13 + drivers/net/wireless/ath/ath10k/wmi.c | 18 ++ drivers

Re: [ath9k-devel] [PATCH 1/2] ath10k: Convert ath10k_dbg uses

2013-05-16 Thread Michal Kazior
. WMI symbol definition because it doesn't exist (ATH10K_DBG_WMI is what you actually want). Although you don't look for this symbol often so I guess it's okay-ish. -- Pozdrawiam / Best regards, Michal Kazior. ___ ath9k-devel mailing list ath9k-devel

[ath9k-devel] [PATCH] ath10k: remove CTRY_DEFAULT assignment

2013-05-16 Thread Michal Kazior
The country is be overwritten by the eeprom regdomain that we read from WMI event anyway. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/mac.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net

[ath9k-devel] [PATCH] ath10k: remove static mac address mask

2013-05-16 Thread Michal Kazior
FW can dynamically adjust to multiple mac addresses. It reports it's preferred base mac address, but we can freely create derivative addresses for vdevs. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/wmi.c |8 1 file changed, 8 deletions

[ath9k-devel] [PATCH 0/7] ath10k: tx flow control fixes

2013-05-16 Thread Michal Kazior
: introduce proper htt tx flow control` (this was deadlocking, and is no longer necessary anyway) Michal Kazior (7): ath10k: change errno if we run out of msdu_ids ath10k: ath10k_htc_prepare_tx_skb() never fails ath10k: add lockdep asserts to htc skb dequeuing ath10k: simplify htc flow

  1   2   3   >