Re: [ath9k-devel] [RFC/RFT] ath9k: support for multiple beacon intervals

2011-07-03 Thread Steve Brown
On Thu, 2011-06-30 at 01:15 +0800, Adrian Chadd wrote: > On 29 June 2011 21:22, Steve Brown wrote: > > On Wed, 2011-06-29 at 09:31 +0800, Adrian Chadd wrote: > >> Is mesh+ap on the same interface currently supported? > >> > > > > No, only with this patch.

Re: [ath9k-devel] [RFC/RFT] ath9k: support for multiple beacon intervals

2011-07-03 Thread Steve Brown
On Fri, 2011-07-01 at 10:49 +0200, Björn Smedman wrote: > If possible I would prefer an implementation that sets SWBA interrupts > to the greatest common divisor of all beacon intervals. > /Björn The purpose of the patch is to support a Mesh Access Point by allowing both ap and mesh vifs on the

Re: [ath9k-devel] [RFC/RFT] ath9k: support for multiple beacon intervals

2011-06-29 Thread Steve Brown
On Wed, 2011-06-29 at 09:09 +0800, kang haiyang wrote: > On 06/29/2011 06:12 AM, Steve Brown wrote: > > This patch maintains a beacon interval for each beacon. > Why do we need this feature? > The purpose is to support what the 802.11s spec calls a mesh access point (MAP). That a

Re: [ath9k-devel] [RFC/RFT] ath9k: support for multiple beacon intervals

2011-06-29 Thread Steve Brown
On Wed, 2011-06-29 at 09:31 +0800, Adrian Chadd wrote: > I say NACK (but like the idea), and here's why: > > So you've not only modified the driver to support >1 beacon interval, > but you've also changed how things are handled for IFTYPE_MESHPOINT. > Please split the patch up into (at least) two

[ath9k-devel] [RFC/RFT] ath9k: support for multiple beacon intervals

2011-06-28 Thread Steve Brown
This patch maintains a beacon interval for each beacon. The SWBA interrupts are based on the shortest interval of the active beacons. This has been tested as a mesh access point with both AP and MESH on one interface. Signed-off-by: Steve Brown --- A patch to wireshark has been posted to

[ath9k-devel] [RFC 2/2] ath9k: support multiple beacon intervals

2011-01-27 Thread Steve Brown
This patch maintains a beacon interval for each beacon. The SWBA interrupts are based on the shortest interval. If an interface with a relatively short beacon is deleted, there is no attempt to change the SWBA rate. It's probably an uncommon operation and doesn't seem to carry much overhead. ---

[ath9k-devel] [RFC 1/2] ath9k: Remove redundant beacon_interval from struct ath_softc

2011-01-27 Thread Steve Brown
The variable appears in both in ath_softc and ath_beacon_config. The struct ath_beacon_config is embedded in ath_softc. The extra variable was added by commit id 57c4d7b4c4986037be51476b8e3025d5ba18d8b8. --- --- a/drivers/net/wireless/ath/ath9k/ath9k.h +++ b/drivers/net/wireless/ath/ath9k/ath9k.

[ath9k-devel] [RFC 0/2] ath9k: Support beacons with multiple intervals

2011-01-27 Thread Steve Brown
This was tested on three routers and a client station with compat-wireless 2011-01-24. The test setup was: router 1: bridged mp (test1) & ethernet, with ethernet connected to internet. router 2: bridged mp (test1) & mp (test2). router 3: bridged mp (test2) & ap There was a station connected to

Re: [ath9k-devel] Why 2 beacon_interval variables?

2011-01-20 Thread Steve Brown
On Thu, 2011-01-20 at 18:16 +0100, Björn Smedman wrote: > On Wed, Jan 19, 2011 at 12:58 PM, Steve Brown wrote: > > Thanks for the reference. The beacon_interval in that commit looks > > redundant to me too. It turned up while I was testing some code for > > beacons at diff

Re: [ath9k-devel] Why 2 beacon_interval variables?

2011-01-19 Thread Steve Brown
On Wed, 2011-01-19 at 12:06 +0530, Mohammed Shafi wrote: > On Wed, Jan 19, 2011 at 12:56 AM, Steve Brown wrote: > > I'm looking at the issue of beacons with different intervals. > > > > There is a beacon_interval in struct ath_softc as well as one in struct > >

[ath9k-devel] Why 2 beacon_interval variables?

2011-01-18 Thread Steve Brown
I'm looking at the issue of beacons with different intervals. There is a beacon_interval in struct ath_softc as well as one in struct ath_beacon_config which is also part of ath_softc. Are both needed? Steve ___ ath9k-devel mailing list ath9k-devel@l

Re: [ath9k-devel] [RFC 1/2] ath9k: Fix up hardware mode and beacons with multiple vifs.

2011-01-14 Thread Steve Brown
On Sat, 2011-01-15 at 00:19 +0100, Björn Smedman wrote: > Thank you for your efforts to get multi-vifs working better. > > This is another comment that is a little out of place but when I see > the identifier beacon_interval in this context I cannot help bringing > up per-vif settings as a relate

Re: [ath9k-devel] [RFC 1/2] ath9k: Fix up hardware mode and beacons with multiple vifs.

2011-01-14 Thread Steve Brown
On Fri, 2011-01-14 at 09:27 -0800, gree...@candelatech.com wrote: > From: Ben Greear > > When using a mixture of AP and Station interfaces, > the hardware mode was using the type of the > last VIF registered. Instead, we should keep track > of the number of different types of vifs and set the >

Re: [ath9k-devel] AR9260 hang during connection to AP

2009-02-25 Thread Steve Brown
Sujith wrote: Steve Brown wrote: hostapd.conf channel=6 ht_capab=[HT40-][SHORT-GI-40][DSSS_CCK-40] iw phy phy1 info Wiphy phy1 Band 1: HT capabilities: 0x104e * 20/40 MHz operation * SM PS disabled

Re: [ath9k-devel] AR9260 hang during connection to AP

2009-02-24 Thread Steve Brown
Sujith wrote: Steve Brown wrote: This is the bug, the AP advertises 20/40, but sets the operating channel to 20 Mhz, but ath9k chooses the wrong rate table since it doesn't honor the AP's current channel width. Can you try this patch ? This will apply on top of today&

Re: [ath9k-devel] AR9260 hang during connection to AP

2009-02-23 Thread Steve Brown
Sujith wrote: > Steve Brown wrote: > >> Feb 20 11:01:29 ubuntu kernel: [15783.068821] ath9k: Set channel: 2437 MHz >> Feb 20 11:01:29 ubuntu kernel: [15783.068825] ath9k: tx chmask: 1, rx >> chmask: 1 >> Feb 20 11:01:29 ubuntu kernel: [15783.068909] ath9

Re: [ath9k-devel] AR9260 hang during connection to AP

2009-02-20 Thread Steve Brown
Sujith wrote: Alex Williams wrote: Thank you for reply! Please, tell me: did you saw working card on ar9160 ever??? May be with other interfaces, such as PCI or USB? Is support for ar9160 finished? Or it's now unusable? No idea. But I found a mini-PCI AR9160 card and it works fine here

Re: [ath9k-devel] AR9260 hang during connection to AP

2009-02-19 Thread Steve Brown
(forgot to cc the list) Sujith wrote: > Alex Williams wrote: > >> Thank you for reply! >> Please, tell me: did you saw working card on ar9160 ever??? May be >> with other interfaces, such as PCI or USB? Is support for ar9160 >> finished? Or it's now unusable? >> > > No idea. But I found a