Re: [ath9k-devel] difference between AR9271 and AR9271L?

2013-08-01 Thread Sujith Manoharan
Oleksij Rempel wrote: Hello devs, what is the difference AR9271 and AR9271L? The L stands for Low-Cost. Sujith ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] Anyone tried using the QCA9880 NIC from the TPLINK AC1750 AP?

2013-06-26 Thread Sujith Manoharan
Ben Greear wrote: I'm dying to get my hands on some ath10k hardware, but can't find anyone actually shipping NICs. But, it looks like the TPLINK AC1750 AP has a QCA9880 NIC in it. Has anyone tried putting one of these in a normal-ish PC and see if it works with the ath10k driver? The

Re: [ath9k-devel] Recurring “Failed to stop TX DMA” error

2013-06-21 Thread Sujith Manoharan
Robbie Smith wrote: Is there a wireless-testing suite of just the networking modules, like a backports-git where I can get the latest fixes? I’d rather not potentially introduce all sorts of other complications (i.e. ATi Catalyst issues—the open-source drivers don’t work properly on my

Re: [ath9k-devel] ath9k_htc: station unable to authenticate

2013-06-20 Thread Sujith Manoharan
Ignacy Gawedzki wrote: After reverting the commit, authentication succeeds very quickly (without the need to up a monitor vif), just as expected. Note that I have kernel 3.8.0 (as per Ubuntu 13.04) and that original ath9k_htc driver works as expected. This has been also tested on Debian

Re: [ath9k-devel] ath9k_htc: station unable to authenticate

2013-06-20 Thread Sujith Manoharan
Ignacy Gawedzki wrote: Can you test if this patch helps (without reverting the mac80211 commit) ? It works indeed, at least with the DG834Gv4. Thanks for testing. I've posted the patch: https://patchwork.kernel.org/patch/2753741/ Sujith ___

Re: [ath9k-devel] ath9k_htc: station unable to authenticate

2013-06-20 Thread Sujith Manoharan
Oleksij Rempel wrote: here i need some help. Why it was not always reproducible? It depends on timing, protocol, moon position? The bug was consistently reproducible at my end. Sujith ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org

Re: [ath9k-devel] Recurring “Failed to stop TX DMA” error

2013-06-18 Thread Sujith Manoharan
Robbie Smith wrote: I’ve got a Atheros AR9485 network card, and I’m currently running the 3.9.6 kernel (x86_64) on Arch Linux, though this issue occurs on every 3.x kernel I’ve tested. I’ve tried running the compat-drivers on older kernels, but I can’t compile it on the current release, nor

Re: [ath9k-devel] [PATCH 06/10] ath10k: defer hw setup to start/stop mac80211 hooks

2013-06-06 Thread Sujith Manoharan
Michal Kazior wrote: This fixes suspend-to-disk. The hardware is now re-initialized upon freeze/thaw properly. This also makes suspend/resume re-initialize the hardware as WoWLAN support is not done yet. With some little work it should be possible to support hw reconfiguration for hw/fw

Re: [ath9k-devel] [PATCH 0/4] ath10k: fixes

2013-06-06 Thread Sujith Manoharan
Michal Kazior wrote: This is part 1 of 4 of a bigger patchset. Split for easier review. Contains functional fixes. Michal Kazior (4): ath10k: fix teardown ordering ath10k: fix possible deadlock ath10k: setup rts/frag thresholds upon vdev creation ath10k: do not setup rts/frag

Re: [ath9k-devel] [PATCH 3/4] ath10k: setup rts/frag thresholds upon vdev creation

2013-06-06 Thread Sujith Manoharan
Michal Kazior wrote: + frag = clamp_t(u32, ar-hw-wiphy-frag_threshold, +ATH10K_FRAGMT_THRESHOLD_MIN, +ATH10K_FRAGMT_THRESHOLD_MAX); + ret = ath10k_wmi_vdev_set_param(ar, arvif-vdev_id, +

Re: [ath9k-devel] [PATCH 0/7] ath10k: more fixes

2013-06-06 Thread Sujith Manoharan
Michal Kazior wrote: This is part 2 of 4 of a bigger patchset. Split for easier review. Contains non-functional fixes. Note: it is not based on master branch. Michal Kazior (7): ath10k: remove ath10k_bus ath10k: fix typo in define name ath10k: silent warning in IBSS mode

Re: [ath9k-devel] [PATCH 03/10] ath10k: allow deferred regd update

2013-06-06 Thread Sujith Manoharan
Michal Kazior wrote: Regulatory domain notification hook can be called regardless of the hw state (i.e. before start mac80211 callback). Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.h |2 ++ drivers/net/wireless/ath/ath10k/mac.c |

Re: [ath9k-devel] [PATCH 06/10] ath10k: defer hw setup to start/stop mac80211 hooks

2013-06-06 Thread Sujith Manoharan
Sujith Manoharan wrote: Is there really no other alternative to fix s2disk without moving Fw download to start() ? This approach seems reasonable too. Sujith ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman

Re: [ath9k-devel] [PATCH 0/2] ath9k: add STBC Rx flags (repost untill some one asnwers)

2013-06-03 Thread Sujith Manoharan
Oleksij Rempel wrote: One more repost of old patches. I need, please, at least some kind of answer: we don't wont patches from you or you are doing some thing wrong. Both the patches have already been merged in wireless-testing. commit b0a1ae976d6cd40ff90ba87883e17eb2610dae3d Author: Oleksij

[ath9k-devel] [PATCH v2 1/3] ath10k: FW API update for version .629

2013-05-09 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/hw.h | 2 +- drivers/net/wireless/ath/ath10k/wmi.c | 18 - drivers/net/wireless/ath/ath10k/wmi.h | 49

[ath9k-devel] [PATCH v2 3/3] ath10k: Set the default TX encapsulation type

2013-05-09 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com The firmware needs to know which frame type is to be used for TX encapsulation. Specifiy this explicitly as NWIFI mode and allow the HW to perform encapsulation. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless

[ath9k-devel] [PATCH] ath10k: Add new service IDs

2013-05-09 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com With the new firmware, various new services have been added. Add them to the service list and display them in the wmi_services file. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/debug.c | 7

Re: [ath9k-devel] [PATCH RFC] ath9k: collect statistics about Rx-Dup and Rx-STBC packets

2013-05-08 Thread Sujith Manoharan
Felix Fietkau wrote: The problem I have with the current stats is they're just an arbitrary collection of random stuff that is probably useless for 99% of all users. In many cases the way the stats are collected also makes the data completely meaningless (e.g. because the source/destination

Re: [ath9k-devel] [PATCH 2/3] ath10k: FW API update for version .629

2013-05-08 Thread Sujith Manoharan
Michal Kazior wrote: I think it would be a good idea to include the adequate cmdid structures too, e.g. for WMI_PDEV_SET_BASE_MACADDR_CMDID. Sure, feel free to add them. I was tracking only the command IDs. Sujith ___ ath9k-devel mailing list

Re: [ath9k-devel] [RFT] ath10k: serialize CE completions properly

2013-05-08 Thread Sujith Manoharan
Michal Kazior wrote: This fixes memory leak when doing heavy TX. ath10k_pci_check_process_ce() was checking `compl_processing` and would call ath10k_pci_process_ce() if its false. The ath10k_pci_process_ce() would then set it to true if there's at least one completion. The lock protecting

Re: [ath9k-devel] [PATCH] ath9k: Disable spectral scan code to fix crash on rmmod.

2013-05-08 Thread Sujith Manoharan
gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com With CONFIG_ATH9K_DEBUGFS enabled, and slub memory poisoning enabled, I see this crash on rmmod of ath9k. I'm not sure how to fix this properly, but in the meantime, this patch to disable the spectral scan code works

[ath9k-devel] [PATCH 1/3] ath10k: Strip the QoS header only for QoS data frames

2013-05-07 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Also, use ieee80211_hdrlen() to simplify things. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/mac.c | 50 +++ 1 file changed, 9 insertions(+), 41 deletions(-) diff

Re: [ath9k-devel] [PATCH v2 0/5] ath10k pending patches

2013-05-03 Thread Sujith Manoharan
Kalle Valo wrote: Patch 2 applied. Patches 1 and 3 already applied. Patches 4 and 5 I send feedback already before. I can send an updated for patch-5, but it is on top of patch-4. I have replied to your feedback for patch-4. Sujith ___ ath9k-devel

Re: [ath9k-devel] [PATCH 1/2] ath10k: Move debug structures to debug.h

2013-05-03 Thread Sujith Manoharan
Kalle Valo wrote: That's what the original codebase had (separate structures for each module), but we started moving it to the direction of having complete struct ath10k in core.h. It's a lot easier to manage everything that way. I have lost interest - please drop this patch. Sujith

Re: [ath9k-devel] [PATCH 1/2] ath10k: Move debug structures to debug.h

2013-05-03 Thread Sujith Manoharan
Sujith Manoharan wrote: Kalle Valo wrote: That's what the original codebase had (separate structures for each module), but we started moving it to the direction of having complete struct ath10k in core.h. It's a lot easier to manage everything that way. I have lost interest - please

Re: [ath9k-devel] [PATCH 1/2] ath10k: Move debug structures to debug.h

2013-05-03 Thread Sujith Manoharan
Sujith Manoharan wrote: Sujith Manoharan wrote: Kalle Valo wrote: That's what the original codebase had (separate structures for each module), but we started moving it to the direction of having complete struct ath10k in core.h. It's a lot easier to manage everything that way

Re: [ath9k-devel] [PATCH 1/2] ath10k: Move debug structures to debug.h

2013-05-02 Thread Sujith Manoharan
Kalle Valo wrote: The idea is that everything within ar variable can be found from core.h. That way people don't need to track down where it's actually defined. That doesn't seem to be the way things are organized. ar contains instances of HTT, HTC, WMI, BMI, HIF - which all have separate

Re: [ath9k-devel] [PATCH 02/20] ath10k: Merge mac.h with core.h

2013-05-02 Thread Sujith Manoharan
Kalle Valo wrote: Sujith Manoharan suj...@msujith.org writes: Kalle Valo wrote: Why do you want to delete mac.h? My idea was to avoid bloating core.h and that's why I wanted to have header files for each .c file. mac.h contains a few prototypes and most of the data structures

[ath9k-devel] [PATCH v2 0/5] ath10k pending patches

2013-05-01 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Hi, Pending patches, rebased over HEAD. I've dropped the txrx.c merge and mac.h removal patches, rebasing them was messy. Sujith Sujith Manoharan (5): ath10k: Remove unneeded locks during HTT RX attach ath10k: Fix mpdu spacing to 8us

[ath9k-devel] [PATCH v2 2/5] ath10k: Fix mpdu spacing to 8us

2013-05-01 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com The FW doesn't fill the mpdu density field in the HT capabilities received in the service_ready event and the host driver ends up advertising 0 in its capabilities. Fix this by hard-coding the spacing time to 8us. Signed-off-by: Sujith Manoharan

[ath9k-devel] [PATCH v2 1/5] ath10k: Remove unneeded locks during HTT RX attach

2013-05-01 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Fix two issues: * Bail out properly when RX buffer allocation fails at init time. * Do not acquire the rx ring lock during attach() since we don't rearm the replenish timer. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers

[ath9k-devel] [PATCH v2 3/5] ath10k: Fix TXOP handling

2013-05-01 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com The channel time duration programmed in the HW is in absolute microseconds, while mac80211 gives the txop in units of 32 microseconds. Handle this properly. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath

[ath9k-devel] [PATCH v2 4/5] ath10k: Move debug structures to debug.h

2013-05-01 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/core.h | 76 + drivers/net/wireless/ath/ath10k/debug.h | 75 2 files changed, 76

[ath9k-devel] [PATCH 2/2] ath10k: Add host statistics

2013-04-30 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/debug.c | 55 +++- drivers/net/wireless/ath/ath10k/debug.h | 22 + drivers/net/wireless/ath/ath10k/htt_rx.c

Re: [ath9k-devel] [PATCH 01/20] ath10k: Remove duplicate UART init code

2013-04-30 Thread Sujith Manoharan
Kalle Valo wrote: These are dropped: 18, 20 I hope I didn't miss anything. An updated version of patch 20 (after addressing Michal's comments) was posted and is here: http://msujith.org/patches/wl/Apr-30-2013/0019-ath10k-Remove-unneeded-locks-during-HTT-RX-attach.patch Sujith

[ath9k-devel] [PATCH v3] ath10k: Remove unneeded locks during HTT RX attach

2013-04-30 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Fix two issues: * Bail out properly when RX buffer allocation fails at init time. * Do not acquire the rx ring lock during attach() since we don't rearm the replenish timer. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers

Re: [ath9k-devel] [PATCH 01/20] ath10k: Remove duplicate UART init code

2013-04-30 Thread Sujith Manoharan
Kalle Valo wrote: Please resend it to the list. Sent. Sujith ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 01/20] ath10k: Remove duplicate UART init code

2013-04-30 Thread Sujith Manoharan
Kalle Valo wrote: But in the future please don't send more than 12 patches at a time, it's way too much pain to handle this many unrelated patches. Sure, though I am not sure what you mean by unrelated patches. :-) Sujith ___ ath9k-devel mailing list

Re: [ath9k-devel] [PATCH] ath10k: Fix TXOP handling

2013-04-30 Thread Sujith Manoharan
Kalle Valo wrote: Please add a comment. [PATCH v2] ath10k: Fix TXOP handling The channel time duration programmed in the HW is in absolute microseconds, while mac80211 gives the txop in units of 32 microseconds. Handle this properly. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com

Re: [ath9k-devel] [PATCH 02/20] ath10k: Merge mac.h with core.h

2013-04-30 Thread Sujith Manoharan
Kalle Valo wrote: Why do you want to delete mac.h? My idea was to avoid bloating core.h and that's why I wanted to have header files for each .c file. mac.h contains a few prototypes and most of the data structures are in core.h. I don't think core.h is getting bloated, it has barely 300+

Re: [ath9k-devel] [PATCH 10/20] ath10k: Remove credits_used from SKB CB

2013-04-29 Thread Sujith Manoharan
Michal Kazior wrote: The comment could be updated too to reflect there's more space in the ath10k_skb_cb now. Sure, I'll do that in a followup patch. Sujith ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org

Re: [ath9k-devel] [PATCH 18/20] ath10k: Move htt_rx_ind_get_mpdu_ranges to htt_rx.c

2013-04-29 Thread Sujith Manoharan
Michal Kazior wrote: I'm not really convinced with this. The idea is the function defines how to access the variadic structure member position so it should stay close to the structure definition. This could as well be a #define but an inline function looks cleaner IMHO. Alright, we can

[ath9k-devel] [PATCH] ath10k: Fix mpdu spacing to 8us

2013-04-29 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com The FW doesn't fill the mpdu density field in the HT capabilities received in the service_ready event and the host driver ends up advertising 0 in its capabilities. Fix this by hard-coding the spacing time to 8us. Signed-off-by: Sujith Manoharan

[ath9k-devel] [PATCH] ath10k: Fix TXOP handling

2013-04-29 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com The channel time duration programmed in the HW is in absolute microseconds, while mac80211 gives the txop in units of 32 microseconds. Handle this properly. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath

Re: [ath9k-devel] [PATCH 20/20] ath10k: Remove unneeded locks during HTT RX attach

2013-04-29 Thread Sujith Manoharan
Sujith Manoharan wrote: If the system is so memory-starved that basic allocation during driver bring-up fails, we should just bail out gracefully and not jump through hoops, hoping that things might improve. ...and it doesn't seem correct to proceed with init after htt_rx_attach() has failed

Re: [ath9k-devel] [PATCH 20/20] ath10k: Remove unneeded locks during HTT RX attach

2013-04-29 Thread Sujith Manoharan
-time. An updated patch: [PATCH] ath10k: Remove unneeded locks during HTT RX attach Fix two issues: * Bail out properly when RX buffer allocation fails at init time. * Do not acquire the rx ring lock during attach() since we don't rearm the replenish timer. Signed-off-by: Sujith Manoharan c_man

Re: [ath9k-devel] [PATCH 20/20] ath10k: Remove unneeded locks during HTT RX attach

2013-04-29 Thread Sujith Manoharan
. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- Looks good to me now. Alright. Thanks for the review ! Sujith ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

[ath9k-devel] [PATCH 01/20] ath10k: Remove duplicate UART init code

2013-04-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/core.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c index

[ath9k-devel] [PATCH 02/20] ath10k: Merge mac.h with core.h

2013-04-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/core.c | 1 - drivers/net/wireless/ath/ath10k/core.h | 20 +++ drivers/net/wireless/ath/ath10k/htt_tx.c | 1 - drivers/net/wireless/ath

[ath9k-devel] [PATCH 04/20] ath10k: Remove ar inside WMI structure

2013-04-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/core.h | 2 -- drivers/net/wireless/ath/ath10k/wmi.c | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/core.h b

[ath9k-devel] [PATCH 03/20] ath10k: Rename HIF callback post_init as init

2013-04-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/hif.h | 10 +- drivers/net/wireless/ath/ath10k/htc.c | 2 +- drivers/net/wireless/ath/ath10k/pci.c | 2 +- 3 files changed, 7 insertions(+), 7

[ath9k-devel] [PATCH 05/20] ath10k: Remove htc inside HTT struct

2013-04-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/core.c | 2 +- drivers/net/wireless/ath/ath10k/htt.c| 5 ++--- drivers/net/wireless/ath/ath10k/htt.h| 4 +--- drivers/net/wireless/ath/ath10k

[ath9k-devel] [PATCH 06/20] ath10k: Move debug routines to debug.c

2013-04-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/debug.c | 119 ++ drivers/net/wireless/ath/ath10k/debug.h | 124 ++-- 2 files changed, 124

[ath9k-devel] [PATCH 07/20] ath10k: Remove void pointers in HTC endpoints

2013-04-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/htc.c| 13 ++--- drivers/net/wireless/ath/ath10k/htc.h| 9 - drivers/net/wireless/ath/ath10k/htt.c| 11 --- drivers

[ath9k-devel] [PATCH 08/20] ath10k: Use lockless SKB queue routines

2013-04-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com The HTC TX queue is protected by tx_lock. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/htc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath

[ath9k-devel] [PATCH 09/20] ath10k: Optimize HTC queue handling

2013-04-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Credit based flow control is enabled only for WMI service and WMI doesn't register any handlers for queue stop/wake, so there is no point in calling recalc_queue() for it. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net

[ath9k-devel] [PATCH 10/20] ath10k: Remove credits_used from SKB CB

2013-04-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/core.h | 4 drivers/net/wireless/ath/ath10k/htc.c | 26 -- 2 files changed, 12 insertions(+), 18 deletions(-) diff --git

[ath9k-devel] [PATCH 11/20] ath10k: Disable credit flow control for EP0

2013-04-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com As the comment says, EP0 doesn't require flow control, so disable it explicitly. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/htc.c | 20 ++-- 1 file changed, 6 insertions(+), 14

[ath9k-devel] [PATCH 12/20] ath10k: Optimize credit allocation

2013-04-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com The chances of a WMI command exceeding the target credit size is low, so use likely() and friends. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/htc.c | 8 1 file changed, 4 insertions

[ath9k-devel] [PATCH 13/20] ath10k: Remove unused variable in processing credit report

2013-04-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/htc.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/htc.c b/drivers/net/wireless/ath

[ath9k-devel] [PATCH 14/20] ath10k: Print HTC service name

2013-04-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/htc.c | 54 --- 1 file changed, 44 insertions(+), 10 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/htc.c b

[ath9k-devel] [PATCH 15/20] ath10k: Fix typo

2013-04-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/ce.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/ce.c b/drivers/net/wireless/ath/ath10k

[ath9k-devel] [PATCH 16/20] ath10k: Merge txrx.c with HTT

2013-04-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/Makefile | 1 - drivers/net/wireless/ath/ath10k/htt.c| 129 +- drivers/net/wireless/ath/ath10k/htt.h| 16 ++ drivers/net/wireless/ath

[ath9k-devel] [PATCH 17/20] ath10k: Use IS_ALIGNED macro to check alignment

2013-04-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/htc.c| 4 +++- drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +- drivers/net/wireless/ath/ath10k/htt_tx.c | 4 ++-- drivers/net/wireless/ath/ath10k

[ath9k-devel] [PATCH 18/20] ath10k: Move htt_rx_ind_get_mpdu_ranges to htt_rx.c

2013-04-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/htt.h| 12 drivers/net/wireless/ath/ath10k/htt_rx.c | 12 2 files changed, 12 insertions(+), 12 deletions(-) diff --git

[ath9k-devel] [PATCH 20/20] ath10k: Remove unneeded locks during HTT RX attach

2013-04-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com We can dispense with the lockdep assert since the refill timer just calls the replenish routine which is held under the ring lock. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/htt_rx.c | 6

[ath9k-devel] [PATCH 19/20] ath10k: Simplify excessively nested HTT structure layout

2013-04-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com There are various sructures inside HTT/RX_RING that contain very few elements. Simplify these. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/htt.c| 2 +- drivers/net/wireless/ath/ath10k/htt.h

[ath9k-devel] [PATCH v2 2/3] ath10k: Merge debug levels

2013-04-24 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com BMI, BOOT with CORE and RX with HTT. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/bmi.c | 8 drivers/net/wireless/ath/ath10k/core.c | 4 ++-- drivers/net/wireless/ath/ath10k/debug.h

[ath9k-devel] [PATCH v2 1/3] ath10k: WMI API updates

2013-04-24 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com To sync with new FW ver .614 Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/hw.h | 3 ++- drivers/net/wireless/ath/ath10k/wmi.c | 1 + drivers/net/wireless/ath/ath10k/wmi.h | 12 3

[ath9k-devel] [PATCH v2 3/3] ath10k: Initialize CW mode

2013-04-24 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Set the channel width mode to static by default. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/mac.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/mac.c

Re: [ath9k-devel] [RFC 0/2] ath10k: fix qos workaround

2013-04-24 Thread Sujith Manoharan
Michal Kazior wrote: From what I've observed so far is frames in monitor mode (non promiscuous) are corrupted. They have the QoS Control stripped, with LLC header finding itself in the QoS Control. Wireshark shows such packets as A-MSDU corrupted frames. I tried restoring the QoS Control but

Re: [ath9k-devel] [PATCH 2/2] ath10k: don't advertise we want monitor vif

2013-04-24 Thread Sujith Manoharan
Michal Kazior wrote: We were triggering warnings in our code and mac80211. We could fix the monitor state machine in ath10k but it doesn't make much sense. We don't benefit from having the monitor vif create in the first place so just drop it. What warnings ? I think this flag is required,

Re: [ath9k-devel] [PATCH v2 1/3] ath10k: WMI API updates

2013-04-24 Thread Sujith Manoharan
Sujith Manoharan wrote: From: Sujith Manoharan c_man...@qca.qualcomm.com To sync with new FW ver .614 A rebased patch below. (Also, http://msujith.org/patches/wl/Apr-24-2013/0005-ath10k-WMI-API-updates.patch). Sujith [PATCH] ath10k: WMI API updates To sync with new FW ver .614 Signed-off

Re: [ath9k-devel] [PATCH 2/2] ath10k: don't advertise we want monitor vif

2013-04-24 Thread Sujith Manoharan
Michal Kazior wrote: [ 1989.477975] ath10k: Only one monitor interface allowed [ 1989.478016] ath10k: ath10k_htc_notify_tx_completion: ep 2 skb 880220e480c0 [ 1989.481481] [ cut here ] [ 1989.486963] WARNING: at net/mac80211/iface.c:386

[ath9k-devel] [PATCH 1/3] ath10k: WMI API updates

2013-04-23 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com To sync with new FW. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/wmi.h | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless

[ath9k-devel] [PATCH 2/3] ath10k: Merge debug levels

2013-04-23 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com BMI, BOOT with CORE and RX with HTT. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/bmi.c | 8 drivers/net/wireless/ath/ath10k/core.c | 4 ++-- drivers/net/wireless/ath/ath10k/debug.h

[ath9k-devel] [PATCH 3/3] ath10k: Initialize CW mode

2013-04-23 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Set the channel width mode to static by default. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/mac.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/mac.c

Re: [ath9k-devel] [PATCH 1/3] ath10k: WMI API updates

2013-04-23 Thread Sujith Manoharan
Kalle Valo wrote: To sync with new FW. What version? I think with version .603. Sujith ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] How to block a concrete channel?

2013-04-23 Thread Sujith Manoharan
Francisco Cuesta wrote: Then, is it better to erase the channel from those files instead of setting a flag?? Could you tell me what implies marking a channel with IEEE80211_CHAN_DISABLED? I mean, what level would it be disabled at or what would be consequences of using that flag at level user?

Re: [ath9k-devel] [PATCH 1/3] ath10k: WMI API updates

2013-04-23 Thread Sujith Manoharan
Kalle Valo wrote: Please add the firmware version to the commit log and update SUPPORTED_FW_BUILD accordingly. Ok. I'll send a v2 once the new FW is uploaded. Sujith ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org

Re: [ath9k-devel] [PATCH 3/3] ath10k: Initialize CW mode

2013-04-23 Thread Sujith Manoharan
Kalle Valo wrote: Why? What's the change from user's point of view? Dynamic CWM needs to be tested properly. For now static channel bandwidth can be used (whatever hostapd gives the driver). Sujith ___ ath9k-devel mailing list

[ath9k-devel] [PATCH] ath10k: Fix PCI probe

2013-04-22 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com The target should always be woken up when the device is being probed and this shouldn't depend on the module parameter ath10k_target_ps, which is used to enable target PowerSave. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com

Re: [ath9k-devel] [PATCH] ath10k: fix HW version/revision names

2013-04-19 Thread Sujith Manoharan
Michal Kazior wrote: static const struct ath10k_hw_params ath10k_hw_params_list[] = { { .id = AR9888_HW_1_0_VERSION, - .name = ar9888 rev1 (build 44), + .name = qca9880 hw1.0, Is it 9888 or is it 9880? Both actually. QCA9888 is the chip part for

Re: [ath9k-devel] [PATCH 3/7] ath10k: remove excessive ifdef checks

2013-04-18 Thread Sujith Manoharan
Markowski Bartosz wrote: Everywhere? The PCI suspend/resume callbacks are still wrapped up. Sorry, I didn't even look at the patch. ;) Sujith ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] [PATCH 3/7] ath10k: remove excessive ifdef checks

2013-04-17 Thread Sujith Manoharan
Bartosz Markowski wrote: No need to check CONFIG_PM_SLEEP everywhere, the PCI suspend hooks is the only place we need to check it. The PM_SLEEP wrappers are required for OpenWrt. Sujith ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org

[ath9k-devel] [PATCH 2/2] ath10k: Reduce maximum VDEV count

2013-04-16 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Fix this at 8 until the large-ap feature is ported to ath10k. Tested with FW ver 604 using CUS223 v1 and v2. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/hw.h | 2 +- 1 file changed, 1 insertion

[ath9k-devel] [PATCH 1/2] ath10k: WMI overhaul

2013-04-16 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Sync with internal WMI changes. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/wmi.c | 15 +- drivers/net/wireless/ath/ath10k/wmi.h | 278 -- 2 files changed, 136

Re: [ath9k-devel] OP_INVALID ... defines in the htc.h

2013-04-14 Thread Sujith Manoharan
Bill Wang wrote: Seems that the defines below should be changed to bit numbers since set_bit/test_bit take bit number as arguments. Makes sense. Can you please send a patch ? Sujith ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org

Re: [ath9k-devel] AR9287 ; 2-wire coexistence expected behavior

2013-04-06 Thread Sujith Manoharan
sandeep suresh wrote: But the question is for 2-wire coexistence, are there any weight register? No. Do you know if AR9287 also supports MCI mode? No. Sujith ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org

Re: [ath9k-devel] AR9287 ; 2-wire coexistence expected behavior

2013-04-06 Thread Sujith Manoharan
Sujith Manoharan wrote: Do you know if AR9287 also supports MCI mode? No. I mean - AR9287 doesn't have MCI. :) Sujith ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Re: [ath9k-devel] AR9287 ; 2-wire coexistence expected behavior

2013-04-05 Thread Sujith Manoharan
sandeep suresh wrote: I had a look at the source code for Ath9k. For 2-wire coexistence, other than GPIO configuration (direction, Mux etc) for WLAN_ACTIVE and BT_ACTIVITY, is there also weight register configuration for BT and WLAN for 2-wire? What exactly is the meaning of these weight

Re: [ath9k-devel] Fix A-MPDU Length

2013-03-28 Thread Sujith Manoharan
Ahmad Showail wrote: If possible, do you have a pointer to the regulatory limit that you mentioned? I tried searching online, but couldn't find anything. The 802.11 standard document defines the maximum length of A-MPDU to 65 535 bytes. It states that the A-MPDU size may further be limited by

Re: [ath9k-devel] Fwd: Atheros 9580 driver

2013-03-28 Thread Sujith Manoharan
Francisco Cuesta wrote: I was using that command, but I had understood that some channels were available on the device even though they didn't appear with that command. For instance, if the version of iw is older that the running hardware those channels wouldn't be shown, am I mistaken? iw

Re: [ath9k-devel] Atheros 9580 driver

2013-03-27 Thread Sujith Manoharan
Francisco Cuesta wrote: I have an AR9580 chipset, which comes with my tp link WDR4300 router, I was looking for drivers for this device, but I have noticed that there is no version of AR9004 driver yet. So, I would like to know how is then my device managed. I mean, what driver is it using?

Re: [ath9k-devel] Fix A-MPDU Length

2013-03-26 Thread Sujith Manoharan
Ahmad Showail wrote: I have two questions regarding frame aggregation in ath9k: 1. The maximum A-MPDU length I managed to get by saturating the link is around 30 frames. How can I push the length to the theoretical limit which is 64 frames? I am monitoring the (Average AMPDU length) in the

Re: [ath9k-devel] Fix A-MPDU Length

2013-03-26 Thread Sujith Manoharan
Ahmad Showail wrote: I have two questions regarding frame aggregation in ath9k: 1. The maximum A-MPDU length I managed to get by saturating the link is around 30 frames. How can I push the length to the theoretical limit which is 64 frames? I am monitoring the (Average AMPDU length) in the

Re: [ath9k-devel] [RFC] ath9k: Detect and work-around tx-queue hang.

2013-03-13 Thread Sujith Manoharan
Ben Greear wrote: For instance, is there any good way to know for certain if packets in the queue are in power-save or not? I know we at least attempt to disable power-save, but possibly it gets re-enabled somehow? I am not sure if that could happen. This issue got lost somehow, but

Re: [ath9k-devel] [RFC] ath9k: Detect and work-around tx-queue hang.

2013-02-22 Thread Sujith Manoharan
Felix Fietkau wrote: Please also check if the station(s) that the frames are queued for are in powersave state for some reason. That would prevent the tx path from throwing them in the hw queue, yet they'd still take up pending-frame slots. I was planning on fixing this eventually by expiring

Re: [ath9k-devel] [RFC] ath9k: Detect and work-around tx-queue hang.

2013-02-21 Thread Sujith Manoharan
Ben Greear wrote: I'll be happy to test patches, but I'm not sure how to go about debugging the real problem on my own. Maybe some stats could be added to the xmit debugfs file to help diagnose the problem, or maybe some other debugfs info will help? I can't reproduce the problem with

Re: [ath9k-devel] [RFC] ath9k: Detect and work-around tx-queue hang.

2013-02-21 Thread Sujith Manoharan
Hi, This is definitely a work-around. :) I think we should debug a bit more to find out the actual bug rather than add more hacks to the already hackish TX poll routine. Sujith gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com We see TX lockups on ar9380 NICs when

<    1   2   3   4   5   >