Re: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption

2017-01-09 Thread Stam, Michel [FINT]
rg Cc: linux-wirel...@vger.kernel.org; Antonio Quartulli Subject: Re: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption Hello, I am trying to understand what's required by this patch to be merged upstream. Sven Eckelmann commented in another email by saying: "The p

Re: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption

2017-01-08 Thread Sebastian Gottschall
all patches have a unclear license since most patches are not comming with any licence declaration ;-) Am 27.10.2016 um 08:02 schrieb Kalle Valo: > Antonio Quartulli writes: > >> On Wed, Oct 26, 2016 at 05:05:14PM +0300, Kalle Valo wrote: >>> Antonio Quartulli writes: >>> From: Antonio Qua

Re: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption

2017-01-07 Thread Antonio Quartulli
On Wed, Oct 26, 2016 at 05:05:14PM +0300, Kalle Valo wrote: > Antonio Quartulli writes: > > > From: Antonio Quartulli > > > > This patch was crafted long time ago to work around a key cache > > corruption problem on ath9k chipsets. > > > > The workaround consists in periodically triggering a wor

Re: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption

2017-01-07 Thread Antonio Quartulli
Hello, I am trying to understand what's required by this patch to be merged upstream. Sven Eckelmann commented in another email by saying: "The patch itself has (at least) one big problem. It is using some mac80211 internals in ath_key_config_iter to make sure that the uploaded keys were actually

[ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption

2017-01-07 Thread Antonio Quartulli
From: Antonio Quartulli This patch was crafted long time ago to work around a key cache corruption problem on ath9k chipsets. The workaround consists in periodically triggering a worker that uploads all the keys to the HW cache. The worker is triggered also when the vif detects 21 undecryptable

Re: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption

2016-11-19 Thread Stam, Michel [FINT]
annes Berg; Sebastian Gottschall; Kalle Valo; Antonio Quartulli; ath9k-devel@lists.ath9k.org; linux-wirel...@vger.kernel.org; Antonio Quartulli Subject: Re: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption Hiya, maybe the right thing to do is to set a flag that says "please

Re: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption

2016-11-19 Thread Adrian Chadd
Hiya, maybe the right thing to do is to set a flag that says "please replumb", then do a reset, and have the reset path see if we need to replumb keys and do so? To make locking less terrible, maybe we need to cache the keys in the ath9k driver somewhere so replumbing doesn't require reaching int

Re: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption

2016-11-14 Thread Stam, Michel [FINT]
chall; Kalle Valo; Antonio Quartulli Cc: ath9k-devel@lists.ath9k.org; linux-wirel...@vger.kernel.org; Antonio Quartulli Subject: Re: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption On Thu, 2016-10-27 at 09:54 +0200, Sebastian Gottschall wrote: > all patches have a unclear

Re: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption

2016-10-27 Thread Johannes Berg
On Thu, 2016-10-27 at 09:54 +0200, Sebastian Gottschall wrote: > all patches have a unclear license since most patches are not comming > with any licence declaration ;-) You should read the DCO some time. Maybe you shouldn't be sending patches if you think so. johannes ___

Re: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption

2016-10-26 Thread Kalle Valo
Antonio Quartulli writes: > On Wed, Oct 26, 2016 at 05:05:14PM +0300, Kalle Valo wrote: >> Antonio Quartulli writes: >> >> > From: Antonio Quartulli >> > >> > This patch was crafted long time ago to work around a key cache >> > corruption problem on ath9k chipsets. >> > >> > The workaround con

Re: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption

2016-10-26 Thread Ferry Huberts
do a grep in the kernel: dual license bsd/gpl On 26/10/16 16:05, Kalle Valo wrote: > Antonio Quartulli writes: > >> From: Antonio Quartulli >> >> This patch was crafted long time ago to work around a key cache >> corruption problem on ath9k chipsets. >> >> The workaround consists in periodically

Re: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption

2016-10-26 Thread Kalle Valo
Antonio Quartulli writes: > From: Antonio Quartulli > > This patch was crafted long time ago to work around a key cache > corruption problem on ath9k chipsets. > > The workaround consists in periodically triggering a worker that > uploads all the keys to the HW cache. The worker is triggered als

Re: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption

2016-10-22 Thread Johannes Berg
> "The patch itself has (at least) one big problem. It is using some > mac80211 > internals in ath_key_config_iter to make sure that the uploaded keys > were > actually programmed in the hardware. Without this check the keys > could end up > in the lower slots and thus break all connections." The