On 21/07/2014 17:16, Bjorn Helgaas wrote:
[+cc Jingoo]
On Fri, Jul 18, 2014 at 12:50 PM, James Bottomley
Anyway, it's PCI code ... let the PCI maintainer decide. However, if he
does want this do it as one big bang patch via either the PCI or Trivial
tree (latter because Jiří has
[+cc Jingoo]
On Fri, Jul 18, 2014 at 12:50 PM, James Bottomley
james.bottom...@hansenpartnership.com wrote:
On Fri, 2014-07-18 at 11:17 -0700, Greg KH wrote:
On Fri, Jul 18, 2014 at 09:54:32AM -0700, James Bottomley wrote:
On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote:
On Fri, Jul 18,
From: Benoit Taine benoit.ta...@lip6.fr
Date: Fri, 18 Jul 2014 17:26:47 +0200
We should prefer `const struct pci_device_id` over
`DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
This issue was reported by checkpatch.
A simplified version of the semantic patch that makes
We should prefer `const struct pci_device_id` over
`DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
This issue was reported by checkpatch.
A simplified version of the semantic patch that makes this change is as
follows (http://coccinelle.lip6.fr/):
// smpl
@@
identifier i;
On Fri, 2014-07-18 at 17:26 +0200, Benoit Taine wrote:
We should prefer `const struct pci_device_id` over
`DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
This issue was reported by checkpatch.
What kernel coding style? checkpatch isn't the arbiter of style, if
that's the
On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote:
On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote:
We should prefer `const struct pci_device_id` over
`DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
This issue was reported by checkpatch.
On Fri, Jul 18, 2014 at 09:54:32AM -0700, James Bottomley wrote:
On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote:
On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote:
On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote:
We should prefer `const struct pci_device_id`
On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote:
On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote:
On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote:
We should prefer `const struct pci_device_id` over
`DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style
On Fri, 2014-07-18 at 11:17 -0700, Greg KH wrote:
On Fri, Jul 18, 2014 at 09:54:32AM -0700, James Bottomley wrote:
On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote:
On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote:
On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine
We have almost 1000 more uses of the non-macro version than the macro
version in the kernel today:
$ git grep -w DEFINE_PCI_DEVICE_TABLE | wc -l
262
$ git grep const struct pci_device_id | wc -l
1254
did you check for non-const ones? just to see if we have any of the
broken case in the
On Sat, Jul 19, 2014 at 07:14:12AM +1000, Dave Airlie wrote:
We have almost 1000 more uses of the non-macro version than the macro
version in the kernel today:
$ git grep -w DEFINE_PCI_DEVICE_TABLE | wc -l
262
$ git grep const struct pci_device_id | wc -l
1254
did you check for
11 matches
Mail list logo
