On Tuesday 14 June 2011 18:43:51 Joe Perches wrote:
> On Tue, 2011-06-14 at 12:31 -0400, Pavel Roskin wrote:
> > On 06/14/2011 12:02 AM, Joe Perches wrote:
> > > /* Get the message ID */
> > > - msg_id = (__be16 *) ((void *) htc_hdr +
> > > - s
On Tue, 2011-06-14 at 12:31 -0400, Pavel Roskin wrote:
> On 06/14/2011 12:02 AM, Joe Perches wrote:
> > /* Get the message ID */
> > - msg_id = (__be16 *) ((void *) htc_hdr +
> > -sizeof(struct htc_frame_hdr));
> > + msg_id = (void *)h
On 06/14/2011 12:02 AM, Joe Perches wrote:
> /* Get the message ID */
> - msg_id = (__be16 *) ((void *) htc_hdr +
> - sizeof(struct htc_frame_hdr));
> + msg_id = (void *)htc_hdr + sizeof(struct htc_frame_hdr);
I would never do
>> diff --git a/drivers/net/wireless/mwifiex/11n.c
>> b/drivers/net/wireless/mwifiex/11n.c
>> @@ -191,7 +191,7 @@ int mwifiex_ret_11n_cfg(struct host_cmd_ds_command
>> *resp, void *data_buf)
>>struct host_cmd_ds_11n_cfg *htcfg = &resp->params.htcfg;
>>
>>if (data_buf) {
>> -
> - pt = (T *)pv;
> + pt = pv;
>
> Signed-off-by: Joe Perches j...@perches.com
...
> drivers/net/wireless/mwifiex/11n.c |5 ++---
> drivers/net/wireless/mwifiex/cmdevt.c |3 +--
> drivers/net/wireless/mwifiex/join.c|2 +-
> drivers/net/wireless/mwifiex/sca
On Tue, 2011-06-14 at 15:39 +1000, Julian Calaby wrote:
> My issue here is that you mention in the commit log that this relates
> to the removal of netdev_priv and dev_priv, but the casts removed
> (mostly) don't.
Sorry if that was unclear to you.
None of these patches remove casts of netdev_priv
Joe,
On Tue, Jun 14, 2011 at 15:32, Joe Perches wrote:
> On Tue, 2011-06-14 at 15:23 +1000, Julian Calaby wrote:
>> Joe,
>
> Hi Julian.
>
>> On Tue, Jun 14, 2011 at 14:02, Joe Perches wrote:
>> > Unnecessary casts of void * clutter the code.
>> > These are the remainder casts after several speci
On Tue, 2011-06-14 at 15:23 +1000, Julian Calaby wrote:
> Joe,
Hi Julian.
> On Tue, Jun 14, 2011 at 14:02, Joe Perches wrote:
> > Unnecessary casts of void * clutter the code.
> > These are the remainder casts after several specific
> > patches to remove netdev_priv and dev_priv.
> You seem to h
Joe,
On Tue, Jun 14, 2011 at 14:02, Joe Perches wrote:
> Unnecessary casts of void * clutter the code.
>
> These are the remainder casts after several specific
> patches to remove netdev_priv and dev_priv.
You seem to have removed a lot of casts that don't relate to these cleanups.
In particula
Unnecessary casts of void * clutter the code.
These are the remainder casts after several specific
patches to remove netdev_priv and dev_priv.
Done via coccinelle script:
$ cat cast_void_pointer.cocci
@@
type T;
T *pt;
void *pv;
@@
- pt = (T *)pv;
+ pt = pv;
Signed-off-by: Joe Perches
---
dr
10 matches
Mail list logo
