[ath9k-devel] [PATCH v2] ath9k: collect statistics about Rx-Dup and Rx-STBC packets

2013-04-27 Thread Oleksij Rempel
Collect statistics about recived duplicate and STBC packets. This information should help see if STBC is actually working. Tested on ar9285; Should work for all chips after ar9280. Changes: - v2. test for stbc vield only on ar9280 and later. reanme rx_gi to rx_short_gi Signed-off-by:

Re: [ath9k-devel] [PATCH v2] ath9k: collect statistics about Rx-Dup and Rx-STBC packets

2013-04-27 Thread Adrian Chadd
Hiya, Why not just bump rs_flags to be a u16, rather than a u8? then you don't need an rs_flags_2. (And then go and re-align things inside that struct so you don't waste space.) Adrian ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org

Re: [ath9k-devel] [PATCH v2] ath9k: collect statistics about Rx-Dup and Rx-STBC packets

2013-04-27 Thread Oleksij Rempel
Am 27.04.2013 20:51, schrieb Adrian Chadd: Hiya, Why not just bump rs_flags to be a u16, rather than a u8? then you don't need an rs_flags_2. ok (And then go and re-align things inside that struct so you don't waste space.) hmm.. what do you mean here? -- Regards, Oleksij

Re: [ath9k-devel] [PATCH v2] ath9k: collect statistics about Rx-Dup and Rx-STBC packets

2013-04-27 Thread Adrian Chadd
On 27 April 2013 11:53, Oleksij Rempel li...@rempel-privat.de wrote: (And then go and re-align things inside that struct so you don't waste space.) hmm.. what do you mean here? Structure alignment? Well, you typically want to have everything be dword aligned (32 bits) or word (16 bits)

Re: [ath9k-devel] [PATCH v2] ath9k: collect statistics about Rx-Dup and Rx-STBC packets

2013-04-27 Thread Oleksij Rempel
Am 27.04.2013 21:06, schrieb Adrian Chadd: On 27 April 2013 11:53, Oleksij Rempel li...@rempel-privat.de wrote: (And then go and re-align things inside that struct so you don't waste space.) hmm.. what do you mean here? Structure alignment? Well, you typically want to have everything be

Re: [ath9k-devel] [PATCH v2] ath9k: collect statistics about Rx-Dup and Rx-STBC packets

2013-04-27 Thread Felix Fietkau
On 2013-04-27 9:06 PM, Adrian Chadd wrote: On 27 April 2013 11:53, Oleksij Rempel li...@rempel-privat.de wrote: (And then go and re-align things inside that struct so you don't waste space.) hmm.. what do you mean here? Structure alignment? Well, you typically want to have everything be