Re: [ath9k-devel] [PATCHv2 2/3] mac80211: mesh power save doze scheduling

2013-02-26 Thread Johannes Berg
On Mon, 2013-02-25 at 11:06 +0100, Marco Porsch wrote: > > This is strange, why bother with the else if there's a continue? > > I don't quite get this comment. The current logic is like this: > > if (unrelated cases) { > continue; > } else if (related and blocking) { > allow = false;

Re: [ath9k-devel] [PATCHv2 2/3] mac80211: mesh power save doze scheduling

2013-02-25 Thread Marco Porsch
Hi Johannes, On 02/20/2013 04:01 PM, Johannes Berg wrote: > On Mon, 2013-02-18 at 17:08 +0100, Marco Porsch wrote: > >> +/** >> + * ieee80211_mps_init - register callbacks for mesh powersave mode >> + * >> + * @hw: the hardware >> + * @ops: callbacks for this device >> + * >> + * called by driver

Re: [ath9k-devel] [PATCHv2 2/3] mac80211: mesh power save doze scheduling

2013-02-20 Thread Johannes Berg
On Mon, 2013-02-18 at 17:08 +0100, Marco Porsch wrote: > +/** > + * ieee80211_mps_init - register callbacks for mesh powersave mode > + * > + * @hw: the hardware > + * @ops: callbacks for this device > + * > + * called by driver on mesh interface add/remove > + */ > +#ifdef CONFIG_MAC80211_MESH >

Re: [ath9k-devel] [PATCHv2 2/3] mac80211: mesh power save doze scheduling

2013-02-18 Thread Christian Lamparter
On Monday, February 18, 2013 05:08:28 PM Marco Porsch wrote: > --- > +/** > + * ieee80211_mps_sta_tbtt_update - update peer beacon wakeup schedule > + * > + * @sta: mesh STA > + * @mgmt: beacon frame > + * @tim: TIM IE of beacon frame > + * @tsf_local: current HW TSF > + */ > +void ieee80211_mps_st

[ath9k-devel] [PATCHv2 2/3] mac80211: mesh power save doze scheduling

2013-02-18 Thread Marco Porsch
Configure the HW for PS mode if the local mesh PS parameters allow so. Expose a callback ieee80211_mps_init for drivers to register mesh powersave ops: - hw_doze - put the radio to sleep now, wake up at given TBTT - hw_wakeup - wake the radio up for frame RX These ops may be extended in the future