On Mon, May 10, 2010 at 10:07:12AM +0530, Sujith wrote:
Dan Carpenter wrote:
The original code had ENDPOINT_MAX and HST_ENDPOINT_MAX switched.
Hm, no.
I'm afraid I don't understand. ENDPOINT_MAX is 22 and HST_ENDPOINT_MAX
is 8. The htc_target struct is defined as having 8 endpoints.
Dan Carpenter wrote:
I'm afraid I don't understand. ENDPOINT_MAX is 22 and HST_ENDPOINT_MAX
is 8. The htc_target struct is defined as having 8 endpoints.
drivers/net/wireless/ath/ath9k/htc_hst.h
137 struct htc_target {
138 void *hif_dev;
139 struct
On Mon, 2010-05-10 at 16:20 +0530, Sujith wrote:
Ah right. That should be fixed.
I suggest using ARRAY_SIZE(target-endpoint) to be sure.
--
Regards,
Pavel Roskin
___
ath9k-devel mailing list
ath9k-devel@lists.ath9k.org
Dan Carpenter wrote:
The original code had ENDPOINT_MAX and HST_ENDPOINT_MAX switched.
Also the first loop was off by one, it started past the end of the array
and went down to 1 instead of going down to 0. The test at the end of
the loop to see if we exited via a break wasn't right because
Dan Carpenter wrote:
The original code had ENDPOINT_MAX and HST_ENDPOINT_MAX switched.
Hm, no.
Also the first loop was off by one, it started past the end of the array
and went down to 1 instead of going down to 0. The test at the end of
the loop to see if we exited via a break wasn't right
